[PR PATCH] papis: update to 0.12.

[PR PATCH] papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages papis
https://github.com/void-linux/void-packages/pull/37672

papis: update to 0.12.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/37672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-papis-37672.patch --]
[-- Type: text/x-diff, Size: 2435 bytes --]

From 5d45dbd7988d61ad19a7e0f114310b1b6d2b159b Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 25 Jun 2022 00:47:10 +0530
Subject: [PATCH] papis: update to 0.12.

---
 srcpkgs/papis/template | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/papis/template b/srcpkgs/papis/template
index c97d9c49ddcb..9c76ee807479 100644
--- a/srcpkgs/papis/template
+++ b/srcpkgs/papis/template
@@ -1,22 +1,34 @@
 # Template file for 'papis'
 pkgname=papis
-version=0.11.1
-revision=2
+version=0.12
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-requests python3-yaml python3-chardet python3-BeautifulSoup4
- python3-colorama python3-click python3-slugify python3-prompt_toolkit
- python3-tqdm python3-Pygments python3-stevedore python3-parsing
- python3-filetype python3-bibtexparser python3-habanero python3-arxiv2bib
- python3-isbnlib python3 python3-setuptools python3-lxml
- python3-typing_extensions python3-doi"
+depends="python3-requests python3-filetype python3-parsing python3-arxiv2bib
+ python3-yaml python3-chardet python3-BeautifulSoup4 python3-colorama
+ python3-bibtexparser python3-click python3-habanero python3-isbnlib
+ python3-prompt_toolkit python3-tqdm python3-Pygments python3-stevedore
+ python3-doi python3-lxml python3-slugify python3-Whoosh"
+checkdepends="${depends} python3-pytest"
 short_desc="Command-line based document and bibliography manager"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/papis/papis"
+changelog="https://github.com/papis/papis/blob/master/CHANGELOG.md"
 distfiles="https://github.com/papis/papis/archive/v${version}.tar.gz"
-checksum=8ebb2f6f50e2e92e16a37ffc1a054983f6b50c6a56d3629d9f612f4197d7a7da
+checksum=75a91f827927a79ac648fbd810aacb1d2a0ba475f69f2f61c421c8b1dbf10cc9
 
-pre_build() {
-	sed -i '/configparser/d' setup.py
+do_patch() {
+	vsed -e '/configparser/d' -i setup.py
+	vsed -e '/--cov=papis/d' -i setup.cfg
+}
+
+do_check() {
+	# Require to generate egg_info so that tests can use entry points
+	python3 setup.py egg_info
+
+	# Deselected one test which fails dring upstream CI too
+	# https://github.com/papis/papis/runs/6558190874?check_suite_focus=true
+	PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest papis/ tests/ \
+		--deselect=tests/downloaders/test_project_euclid.py::test_1
 }

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906361166

Comment:
remove this and add `python3-pytest-cov` to `checkdepends`

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906353546

Comment:
this should be done in pre_check()

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906361505

Comment:
this can be turned into
```sh
make_check_pre="env PYTHONPATH=$wrksrc/build/lib"
make_check_args="--deselect=tests/downloaders/test_project_euclid.py::test_1"
make_check_target="papis tests"
```
and then defining do_check() is no longer needed

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906360984

Comment:
why is this removed? It's also a single-line change, it would be better as a small patch.

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906363639

Comment:
re-ordering all of these dependencies makes for a hard-to-parse diff, and shouldn't be necessary

Re: [PR REVIEW] papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906372255

Comment:
I was following the ordering in https://github.com/papis/papis/blob/v0.12/setup.py#L55 cause there are so many in case I miss something or something redundant gets into it.

Re: [PR REVIEW] papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906376953

Comment:
is it okay to remove the `pre_build()`? it doesn't seem to be needed anymore

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906378415

Comment:
yes, if it's empty

Re: [PR PATCH] [Updated] papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages papis
https://github.com/void-linux/void-packages/pull/37672

papis: update to 0.12.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/37672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-papis-37672.patch --]
[-- Type: text/x-diff, Size: 1861 bytes --]

From b69ea3bd3f2623c6847214a81b5cd587a8833437 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 25 Jun 2022 00:47:10 +0530
Subject: [PATCH] papis: update to 0.12.

---
 srcpkgs/papis/template | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/papis/template b/srcpkgs/papis/template
index c97d9c49ddcb..9f52b2f3f713 100644
--- a/srcpkgs/papis/template
+++ b/srcpkgs/papis/template
@@ -1,22 +1,26 @@
 # Template file for 'papis'
 pkgname=papis
-version=0.11.1
+version=0.12
 revision=2
 build_style=python3-module
+make_check_args="--deselect=tests/downloaders/test_project_euclid.py::test_1"
+make_check_target="papis tests"
 hostmakedepends="python3-setuptools"
 depends="python3-requests python3-yaml python3-chardet python3-BeautifulSoup4
  python3-colorama python3-click python3-slugify python3-prompt_toolkit
  python3-tqdm python3-Pygments python3-stevedore python3-parsing
  python3-filetype python3-bibtexparser python3-habanero python3-arxiv2bib
- python3-isbnlib python3 python3-setuptools python3-lxml
- python3-typing_extensions python3-doi"
+ python3-isbnlib python3-lxml python3-doi python3-Whoosh"
+checkdepends="${depends} python3-pytest-cov"
 short_desc="Command-line based document and bibliography manager"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/papis/papis"
+changelog="https://github.com/papis/papis/blob/master/CHANGELOG.md"
 distfiles="https://github.com/papis/papis/archive/v${version}.tar.gz"
-checksum=8ebb2f6f50e2e92e16a37ffc1a054983f6b50c6a56d3629d9f612f4197d7a7da
+checksum=75a91f827927a79ac648fbd810aacb1d2a0ba475f69f2f61c421c8b1dbf10cc9
 
-pre_build() {
-	sed -i '/configparser/d' setup.py
+pre_check() {
+	# Required to generate egg_info so that tests can use entry points
+	python3 setup.py egg_info
 }

Re: papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#issuecomment-1165919002

Comment:
Linter is complaining about `revision`, I don't know whether I was supposed to increment it in the forced push.

Re: papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#issuecomment-1165920986

Comment:
it should not be, because you updated the version. Updating the revision should only be done if the PR as a whole changes something that isn't a version bump, not within the PR

Re: [PR REVIEW] papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#discussion_r906609334

Comment:
I'd prefer not changing the order, it makes the history easier to use

Re: papis: update to 0.12.

[Goorzhel]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#issuecomment-1166154037

Comment:
But if you're updating the package, as the diff shows, then you'll wanna set `revision=1`.

Re: papis: update to 0.12.

[Goorzhel]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#issuecomment-1166154037

Comment:
But if you're updating the package, as the (current) diff shows, then you'll wanna set `revision=1`.

Re: [PR PATCH] [Updated] papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages papis
https://github.com/void-linux/void-packages/pull/37672

papis: update to 0.12.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/37672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-papis-37672.patch --]
[-- Type: text/x-diff, Size: 1875 bytes --]

From 242ceed786fad5aaaad7e4e44960dec251b8200a Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 25 Jun 2022 00:47:10 +0530
Subject: [PATCH] papis: update to 0.12.

---
 srcpkgs/papis/template | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/papis/template b/srcpkgs/papis/template
index c97d9c49ddcb..f693def810ea 100644
--- a/srcpkgs/papis/template
+++ b/srcpkgs/papis/template
@@ -1,22 +1,26 @@
 # Template file for 'papis'
 pkgname=papis
-version=0.11.1
-revision=2
+version=0.12
+revision=1
 build_style=python3-module
+make_check_args="--deselect=tests/downloaders/test_project_euclid.py::test_1"
+make_check_target="papis tests"
 hostmakedepends="python3-setuptools"
 depends="python3-requests python3-yaml python3-chardet python3-BeautifulSoup4
  python3-colorama python3-click python3-slugify python3-prompt_toolkit
  python3-tqdm python3-Pygments python3-stevedore python3-parsing
  python3-filetype python3-bibtexparser python3-habanero python3-arxiv2bib
- python3-isbnlib python3 python3-setuptools python3-lxml
- python3-typing_extensions python3-doi"
+ python3-isbnlib python3-lxml python3-doi python3-Whoosh"
+checkdepends="${depends} python3-pytest-cov"
 short_desc="Command-line based document and bibliography manager"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/papis/papis"
+changelog="https://github.com/papis/papis/blob/master/CHANGELOG.md"
 distfiles="https://github.com/papis/papis/archive/v${version}.tar.gz"
-checksum=8ebb2f6f50e2e92e16a37ffc1a054983f6b50c6a56d3629d9f612f4197d7a7da
+checksum=75a91f827927a79ac648fbd810aacb1d2a0ba475f69f2f61c421c8b1dbf10cc9
 
-pre_build() {
-	sed -i '/configparser/d' setup.py
+pre_check() {
+	# Required to generate egg_info so that tests can use entry points
+	python3 setup.py egg_info
 }

Re: papis: update to 0.12.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/37672#issuecomment-1166194340

Comment:
Thanks for the info and reviews, updated properly.

Re: [PR PATCH] [Merged]: papis: update to 0.12.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There's a merged pull request on the void-packages repository

papis: update to 0.12.
https://github.com/void-linux/void-packages/pull/37672

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64