Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: gperftools: refresh patches
Date: Sun, 03 Jul 2022 19:51:50 +0200	[thread overview]
Message-ID: <20220703175150.wrOTRE4WaZNny_pnrRtwVgsYWw1od5LXQiu5NxE5qZo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37816@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37816#issuecomment-1173143882

Comment:
> The inability to rebuild a package does affect me when I'm trying to recompile parts of Void for reproducibility (and/or local testing/hosting), and I believe it's useful to have a current set of buildable and re-buildable distribution for testing infrastructure like toolchain upgrades.

Definitely, but if the patches are off by a few lines (like here), the packages will still be build-able. The reason why this package didn't build for you was the whitespace issue that was triggered by us disabling loose whitespace matching in patch (we now use `patch` without `-l`).

Try applying this minimal patch and the package will build fine without the rest of the changes.

```patch
diff --git a/srcpkgs/gperftools/patches/ppc-musl.patch b/srcpkgs/gperftools/patches/ppc-musl.patch
index bbeb4cd393..d192ea6127 100644
--- a/srcpkgs/gperftools/patches/ppc-musl.patch
+++ b/srcpkgs/gperftools/patches/ppc-musl.patch
@@ -14,7 +14,7 @@ Compatibility fixes for musl.
                          pc_field_found=true)
         elif test "x$ac_cv_header_sys_ucontext_h" = xyes; then
           AC_TRY_COMPILE([#define _GNU_SOURCE 1
--                         #include <sys/ucontext.h>],
+-                        #include <sys/ucontext.h>],
 +                         #include <sys/ucontext.h>
 +                         #include <asm/ptrace.h>],
                          [ucontext_t u; return u.$pc_field == 0;],
```

  parent reply	other threads:[~2022-07-03 17:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 15:01 [PR PATCH] " chexum
2022-07-03 17:31 ` paper42
2022-07-03 17:37 ` chexum
2022-07-03 17:51 ` paper42 [this message]
2022-07-03 18:04 ` chexum
2022-07-03 18:14 ` paper42
2022-07-03 18:25 ` [PR PATCH] [Updated] " chexum
2022-07-03 18:28 ` chexum
2022-07-03 21:23 ` [PR PATCH] [Updated] " paper42
2022-07-03 21:23 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220703175150.wrOTRE4WaZNny_pnrRtwVgsYWw1od5LXQiu5NxE5qZo@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).