From: chexum <chexum@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: gperftools: refresh patches
Date: Sun, 03 Jul 2022 20:04:31 +0200 [thread overview]
Message-ID: <20220703180431.aqtS2V_O1pPd2BfclKvb1bztga4o33bP5pH5mt84JAU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37816@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37816#issuecomment-1173145718
Comment:
What I've attempted here is to make sure that the content (including line numbers) matches the original source, so that perhaps(!) it could survive more source upgrades in a safer way. I specifically excluded the fourth patch, as it still applied cleanly with no line numbering issues. It looks the current patches were for different versions originally - IMHO more lax patches have the danger of matching the wrong line and result in hard-to-trace issues.
Perhaps some method to revert to the original patch white-space behaviour could be nicer to avoid retouching old templates?
But I'm glad that templates are expected to be able to (re)build any arbitrary package if the binary package is lost, that means so much for reproducibility (even if not for the bit-for-bit meaning).
next prev parent reply other threads:[~2022-07-03 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 15:01 [PR PATCH] " chexum
2022-07-03 17:31 ` paper42
2022-07-03 17:37 ` chexum
2022-07-03 17:51 ` paper42
2022-07-03 18:04 ` chexum [this message]
2022-07-03 18:14 ` paper42
2022-07-03 18:25 ` [PR PATCH] [Updated] " chexum
2022-07-03 18:28 ` chexum
2022-07-03 21:23 ` [PR PATCH] [Updated] " paper42
2022-07-03 21:23 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220703180431.aqtS2V_O1pPd2BfclKvb1bztga4o33bP5pH5mt84JAU@z \
--to=chexum@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).