* Re: [PR REVIEW] python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
@ 2022-07-06 14:41 ` classabbyamp
2022-07-06 16:30 ` [PR PATCH] [Updated] " shak-mar
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-07-06 14:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/37895#discussion_r914924721
Comment:
expand $homepage here
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
2022-07-06 14:41 ` [PR REVIEW] " classabbyamp
@ 2022-07-06 16:30 ` shak-mar
2022-07-06 16:33 ` shak-mar
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: shak-mar @ 2022-07-06 16:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
There is an updated pull request by shak-mar against master on the void-packages repository
https://github.com/shak-mar/void-packages update-python3-PGPy-to-0.5.4
https://github.com/void-linux/void-packages/pull/37895
python3-PGPy: update to 0.5.4
The previous version of python3-PGPy (0.5.3) is not compatible with python 3.10 because of the `collections.MutableMapping` deprecation. You can reproduce the issue by installing `python3-PGPy`, then running `python3` and within that, `import pgpy`.
#### Testing the changes
- I tested the changes in this PR: **briefly**
A patch file from https://github.com/void-linux/void-packages/pull/37895.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-python3-PGPy-to-0.5.4-37895.patch --]
[-- Type: text/x-diff, Size: 1353 bytes --]
From c7f7b82dd3479916ddf5aba2edcb26e38c0e9898 Mon Sep 17 00:00:00 2001
From: Michael Struwe <michaelstruwe@gmx.net>
Date: Wed, 6 Jul 2022 15:17:20 +0200
Subject: [PATCH] python3-PGPy: update to 0.5.4
---
srcpkgs/python3-PGPy/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-PGPy/template b/srcpkgs/python3-PGPy/template
index fa73d46876ce..5eb12c22fcfe 100644
--- a/srcpkgs/python3-PGPy/template
+++ b/srcpkgs/python3-PGPy/template
@@ -1,17 +1,18 @@
# Template file for 'python3-PGPy'
pkgname=python3-PGPy
-version=0.5.3
-revision=3
+version=0.5.4
+revision=1
wrksrc=PGPy-${version}
build_style=python3-module
hostmakedepends="python3-setuptools python3-wheel"
+checkdepends="python3-pip" # Also needs python3-progressbar which we don't have
depends="python3-cryptography python3-pyasn1 python3-six"
short_desc="Pretty Good Privacy for Python"
maintainer="Anjandev Momi <anjan@momi.ca>"
license="BSD-3-Clause"
homepage="https://github.com/SecurityInnovation/PGPy"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=5f56454c92fe0c242397166df4618183992d6786c2568cbd21c4090344cf2635
+distfiles="https://github.com/SecurityInnovation/PGPy/archive/v${version}.tar.gz"
+checksum=beb2e7745ddebf85a24239aa681fa83a9ab8f8867d7ac55351fb0732279ac4fa
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
2022-07-06 14:41 ` [PR REVIEW] " classabbyamp
2022-07-06 16:30 ` [PR PATCH] [Updated] " shak-mar
@ 2022-07-06 16:33 ` shak-mar
2022-07-06 16:45 ` classabbyamp
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: shak-mar @ 2022-07-06 16:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
New comment by shak-mar on void-packages repository
https://github.com/void-linux/void-packages/pull/37895#issuecomment-1176434744
Comment:
Not sure what to do about the failed pipeline. Running the check phase fails with this error:
```
File "/builddir/PGPy-0.5.3/test_load_asc_bench.py", line 9, in <module>
from progressbar import ProgressBar, AnimatedMarker, Timer, Bar, Percentage, Widget
ModuleNotFoundError: No module named 'progressbar'
```
We don't have a package for progressbar yet. I've tried running the check phase on current master, and it fails too.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
` (2 preceding siblings ...)
2022-07-06 16:33 ` shak-mar
@ 2022-07-06 16:45 ` classabbyamp
2022-07-06 18:00 ` [PR PATCH] [Updated] " shak-mar
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-07-06 16:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/37895#issuecomment-1176446133
Comment:
you can either package progressbar or do
```
# requires progressbar
make_check=no
```
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
` (3 preceding siblings ...)
2022-07-06 16:45 ` classabbyamp
@ 2022-07-06 18:00 ` shak-mar
2022-07-06 20:14 ` shak-mar
2022-07-07 17:55 ` [PR PATCH] [Merged]: " classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: shak-mar @ 2022-07-06 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
There is an updated pull request by shak-mar against master on the void-packages repository
https://github.com/shak-mar/void-packages update-python3-PGPy-to-0.5.4
https://github.com/void-linux/void-packages/pull/37895
python3-PGPy: update to 0.5.4
The previous version of python3-PGPy (0.5.3) is not compatible with python 3.10 because of the `collections.MutableMapping` deprecation. You can reproduce the issue by installing `python3-PGPy`, then running `python3` and within that, `import pgpy`.
#### Testing the changes
- I tested the changes in this PR: **briefly**
A patch file from https://github.com/void-linux/void-packages/pull/37895.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-python3-PGPy-to-0.5.4-37895.patch --]
[-- Type: text/x-diff, Size: 1270 bytes --]
From 3fe2a4aa2e0976f9352caa11de126637b97f7d01 Mon Sep 17 00:00:00 2001
From: Michael Struwe <michaelstruwe@gmx.net>
Date: Wed, 6 Jul 2022 15:17:20 +0200
Subject: [PATCH] python3-PGPy: update to 0.5.4
---
srcpkgs/python3-PGPy/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-PGPy/template b/srcpkgs/python3-PGPy/template
index fa73d46876ce..7de7c554b74f 100644
--- a/srcpkgs/python3-PGPy/template
+++ b/srcpkgs/python3-PGPy/template
@@ -1,7 +1,7 @@
# Template file for 'python3-PGPy'
pkgname=python3-PGPy
-version=0.5.3
-revision=3
+version=0.5.4
+revision=1
wrksrc=PGPy-${version}
build_style=python3-module
hostmakedepends="python3-setuptools python3-wheel"
@@ -10,8 +10,10 @@ short_desc="Pretty Good Privacy for Python"
maintainer="Anjandev Momi <anjan@momi.ca>"
license="BSD-3-Clause"
homepage="https://github.com/SecurityInnovation/PGPy"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=5f56454c92fe0c242397166df4618183992d6786c2568cbd21c4090344cf2635
+distfiles="https://github.com/SecurityInnovation/PGPy/archive/v${version}.tar.gz"
+checksum=beb2e7745ddebf85a24239aa681fa83a9ab8f8867d7ac55351fb0732279ac4fa
+# requires progressbar
+make_check=no
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
` (4 preceding siblings ...)
2022-07-06 18:00 ` [PR PATCH] [Updated] " shak-mar
@ 2022-07-06 20:14 ` shak-mar
2022-07-07 17:55 ` [PR PATCH] [Merged]: " classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: shak-mar @ 2022-07-06 20:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New comment by shak-mar on void-packages repository
https://github.com/void-linux/void-packages/pull/37895#issuecomment-1176668005
Comment:
Ok thanks. I went with disabling the check phase
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Merged]: python3-PGPy: update to 0.5.4
2022-07-06 13:29 [PR PATCH] python3-PGPy: update to 0.5.4 shak-mar
` (5 preceding siblings ...)
2022-07-06 20:14 ` shak-mar
@ 2022-07-07 17:55 ` classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-07-07 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
There's a merged pull request on the void-packages repository
python3-PGPy: update to 0.5.4
https://github.com/void-linux/void-packages/pull/37895
Description:
The previous version of python3-PGPy (0.5.3) is not compatible with python 3.10 because of the `collections.MutableMapping` deprecation. You can reproduce the issue by installing `python3-PGPy`, then running `python3` and within that, `import pgpy`.
#### Testing the changes
- I tested the changes in this PR: **briefly**
^ permalink raw reply [flat|nested] 8+ messages in thread