Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: swapspace-1.17
@ 2022-07-10 22:48 tranzystorek-io
  2022-07-11  9:07 ` pc00per
                   ` (29 more replies)
  0 siblings, 30 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-10 22:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages swapspace
https://github.com/void-linux/void-packages/pull/37992

New package: swapspace-1.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swapspace-37992.patch --]
[-- Type: text/x-diff, Size: 1682 bytes --]

From 7ba8312ace41c0d42ab3ebdddc1a83a22e5b514d Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 11 Jul 2022 00:11:22 +0200
Subject: [PATCH] New package: swapspace-1.17

---
 srcpkgs/swapspace/files/swapspace/run |  6 ++++++
 srcpkgs/swapspace/template            | 24 ++++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 srcpkgs/swapspace/files/swapspace/run
 create mode 100644 srcpkgs/swapspace/template

diff --git a/srcpkgs/swapspace/files/swapspace/run b/srcpkgs/swapspace/files/swapspace/run
new file mode 100644
index 000000000000..ffa427936a33
--- /dev/null
+++ b/srcpkgs/swapspace/files/swapspace/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+set -e
+
+[ -d /var/lib/swapspace ] || install -d -m0700 /var/lib/swapspace
+exec swapspace
diff --git a/srcpkgs/swapspace/template b/srcpkgs/swapspace/template
new file mode 100644
index 000000000000..d7c0356f9391
--- /dev/null
+++ b/srcpkgs/swapspace/template
@@ -0,0 +1,24 @@
+# Template file for 'swapspace'
+pkgname=swapspace
+version=1.17
+revision=1
+wrksrc=Swapspace-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+short_desc="Dynamic swap manager for Linux"
+maintainer="Marcin Puc <tranzystorek.io@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/Tookmund/swapspace"
+changelog="https://raw.githubusercontent.com/Tookmund/Swapspace/master/NEWS"
+distfiles="https://github.com/Tookmund/Swapspace/archive/v${version}/${version}.tar.gz"
+checksum=5a2d82ae7922588bf0c3e3728248672b94666bab76b4be569d3a8793edfabb4f
+
+pre_configure() {
+	autoreconf -vfi
+}
+
+post_install() {
+	vman doc/swapspace.8
+
+	vsv swapspace
+}

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
@ 2022-07-11  9:07 ` pc00per
  2022-07-11  9:14 ` tranzystorek-io
                   ` (28 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: pc00per @ 2022-07-11  9:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by pc00per on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180151310

Comment:
Btw, there's also v1.18 that had [BTRFS support via inode attributes & inode misconfiguration fixes](https://github.com/Tookmund/Swapspace/compare/v1.18-beta2...v1.18-beta)

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
  2022-07-11  9:07 ` pc00per
@ 2022-07-11  9:14 ` tranzystorek-io
  2022-07-11  9:20 ` pc00per
                   ` (27 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11  9:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180157243

Comment:
> Btw, there's also v1.18 that had [BTRFS support via inode attributes & inode misconfiguration fixes](https://github.com/Tookmund/Swapspace/compare/v1.18-beta2...v1.18-beta)

I'm afraid we usually don't package/patch beta branches and the like, it would have to be officially released

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
  2022-07-11  9:07 ` pc00per
  2022-07-11  9:14 ` tranzystorek-io
@ 2022-07-11  9:20 ` pc00per
  2022-07-11  9:23 ` tranzystorek-io
                   ` (26 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: pc00per @ 2022-07-11  9:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

New comment by pc00per on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180163052

Comment:
> > Btw, there's also v1.18 that had [BTRFS support via inode attributes & inode misconfiguration fixes](https://github.com/Tookmund/Swapspace/compare/v1.18-beta2...v1.18-beta)
> 
> I'm afraid we usually don't package/patch beta branches and the like, it would have to be officially released

Void's a rolling distro, so I thought you guys might ship alpha/beta/pre-releases too. I didn't knew this until now. xD

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (2 preceding siblings ...)
  2022-07-11  9:20 ` pc00per
@ 2022-07-11  9:23 ` tranzystorek-io
  2022-07-11  9:23 ` tranzystorek-io
                   ` (25 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11  9:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180165875

Comment:
It's a strange misconception, I don't know rolling distros that do, e.g. neither does Arch

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (3 preceding siblings ...)
  2022-07-11  9:23 ` tranzystorek-io
@ 2022-07-11  9:23 ` tranzystorek-io
  2022-07-11  9:56 ` tranzystorek-io
                   ` (24 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11  9:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180165875

Comment:
It's a strange misconception, I don't know rolling distros that do, e.g. neither does Arch (except for less official packages like on AUR)

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (4 preceding siblings ...)
  2022-07-11  9:23 ` tranzystorek-io
@ 2022-07-11  9:56 ` tranzystorek-io
  2022-07-11 10:23 ` pc00per
                   ` (23 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11  9:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180196580

Comment:
Also, could you try building and testing this package @pc00per? I already did a small test on my vmware x86_64 gnu instance, but maybe you have some specific use cases etc.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (5 preceding siblings ...)
  2022-07-11  9:56 ` tranzystorek-io
@ 2022-07-11 10:23 ` pc00per
  2022-07-11 11:58 ` [PR REVIEW] " wael444
                   ` (22 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: pc00per @ 2022-07-11 10:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

New comment by pc00per on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1180222655

Comment:
> Also, could you try building and testing this package @pc00per? I already did a small test on my vmware x86_64 gnu instance, but maybe you have some specific use cases etc.

I'm an arch user btw. Thought of shifting to void, so I've been requesting missing packages that I use daily. I'll report to you as soon as I do. xD
Should probably work fine as it's just a c library for swap & not some big binary.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (6 preceding siblings ...)
  2022-07-11 10:23 ` pc00per
@ 2022-07-11 11:58 ` wael444
  2022-07-11 11:58 ` wael444
                   ` (21 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: wael444 @ 2022-07-11 11:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r917848055

Comment:
why not 
```suggestion
#!/bin/sh -e
```
?

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (7 preceding siblings ...)
  2022-07-11 11:58 ` [PR REVIEW] " wael444
@ 2022-07-11 11:58 ` wael444
  2022-07-11 12:09 ` tranzystorek-io
                   ` (20 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: wael444 @ 2022-07-11 11:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r917848295

Comment:
what is the newline here for?

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (8 preceding siblings ...)
  2022-07-11 11:58 ` wael444
@ 2022-07-11 12:09 ` tranzystorek-io
  2022-07-11 12:11 ` tranzystorek-io
                   ` (19 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11 12:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r917856637

Comment:
`set -e` is slightly more common in our runit scripts, and I personally prefer to keep the flags out of the shebang

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (9 preceding siblings ...)
  2022-07-11 12:09 ` tranzystorek-io
@ 2022-07-11 12:11 ` tranzystorek-io
  2022-07-11 12:13 ` wael444
                   ` (18 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-11 12:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r917858150

Comment:
My personal preference is to split the file installations and the service installations visually

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (10 preceding siblings ...)
  2022-07-11 12:11 ` tranzystorek-io
@ 2022-07-11 12:13 ` wael444
  2022-07-12  9:13 ` [PR PATCH] [Updated] " tranzystorek-io
                   ` (17 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: wael444 @ 2022-07-11 12:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r917859845

Comment:
interesting. i guess its just personal preferences in scripting.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR PATCH] [Updated] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (11 preceding siblings ...)
  2022-07-11 12:13 ` wael444
@ 2022-07-12  9:13 ` tranzystorek-io
  2022-07-15 15:02 ` [PR REVIEW] " classabbyamp
                   ` (16 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-12  9:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages swapspace
https://github.com/void-linux/void-packages/pull/37992

New package: swapspace-1.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swapspace-37992.patch --]
[-- Type: text/x-diff, Size: 1682 bytes --]

From 614748a1a082d05732b5f2fddc7c2b61a6ceda8f Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 11 Jul 2022 00:11:22 +0200
Subject: [PATCH] New package: swapspace-1.17

---
 srcpkgs/swapspace/files/swapspace/run |  6 ++++++
 srcpkgs/swapspace/template            | 24 ++++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 srcpkgs/swapspace/files/swapspace/run
 create mode 100644 srcpkgs/swapspace/template

diff --git a/srcpkgs/swapspace/files/swapspace/run b/srcpkgs/swapspace/files/swapspace/run
new file mode 100644
index 000000000000..ffa427936a33
--- /dev/null
+++ b/srcpkgs/swapspace/files/swapspace/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+set -e
+
+[ -d /var/lib/swapspace ] || install -d -m0700 /var/lib/swapspace
+exec swapspace
diff --git a/srcpkgs/swapspace/template b/srcpkgs/swapspace/template
new file mode 100644
index 000000000000..d7c0356f9391
--- /dev/null
+++ b/srcpkgs/swapspace/template
@@ -0,0 +1,24 @@
+# Template file for 'swapspace'
+pkgname=swapspace
+version=1.17
+revision=1
+wrksrc=Swapspace-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+short_desc="Dynamic swap manager for Linux"
+maintainer="Marcin Puc <tranzystorek.io@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/Tookmund/swapspace"
+changelog="https://raw.githubusercontent.com/Tookmund/Swapspace/master/NEWS"
+distfiles="https://github.com/Tookmund/Swapspace/archive/v${version}/${version}.tar.gz"
+checksum=5a2d82ae7922588bf0c3e3728248672b94666bab76b4be569d3a8793edfabb4f
+
+pre_configure() {
+	autoreconf -vfi
+}
+
+post_install() {
+	vman doc/swapspace.8
+
+	vsv swapspace
+}

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (12 preceding siblings ...)
  2022-07-12  9:13 ` [PR PATCH] [Updated] " tranzystorek-io
@ 2022-07-15 15:02 ` classabbyamp
  2022-07-15 21:23 ` Chocimier
                   ` (15 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: classabbyamp @ 2022-07-15 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922253247

Comment:
shebangs can technically only be one argument, but some programs interpret the rest of the line. I think it's better as `set`

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (13 preceding siblings ...)
  2022-07-15 15:02 ` [PR REVIEW] " classabbyamp
@ 2022-07-15 21:23 ` Chocimier
  2022-07-15 21:25 ` Chocimier
                   ` (14 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-15 21:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922525724

Comment:
`pkgname=Swapspace` as Void uses tarball/dirname/repo name. Then no need to define wrksrc

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (14 preceding siblings ...)
  2022-07-15 21:23 ` Chocimier
@ 2022-07-15 21:25 ` Chocimier
  2022-07-15 21:35 ` paper42
                   ` (13 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-15 21:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922526643

Comment:
Use `make_dirs` in template instead

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (15 preceding siblings ...)
  2022-07-15 21:25 ` Chocimier
@ 2022-07-15 21:35 ` paper42
  2022-07-16  8:48 ` tranzystorek-io
                   ` (12 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: paper42 @ 2022-07-15 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922531840

Comment:
Also when you run the script directly by passing the file to sh, the shebang line will be ignored.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (16 preceding siblings ...)
  2022-07-15 21:35 ` paper42
@ 2022-07-16  8:48 ` tranzystorek-io
  2022-07-16  8:56 ` tranzystorek-io
                   ` (11 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16  8:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922653193

Comment:
Don't we want a lowercase pkgname? I assumed `Swapspace` is just a quirk in repo naming.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (17 preceding siblings ...)
  2022-07-16  8:48 ` tranzystorek-io
@ 2022-07-16  8:56 ` tranzystorek-io
  2022-07-16 10:19 ` paper42
                   ` (10 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16  8:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922654576

Comment:
This dir is only needed during service runtime, keeping an empty dir at all times seems odd

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (18 preceding siblings ...)
  2022-07-16  8:56 ` tranzystorek-io
@ 2022-07-16 10:19 ` paper42
  2022-07-16 10:19 ` paper42
                   ` (9 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: paper42 @ 2022-07-16 10:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922662493

Comment:
There has been a discussion about switching to lowercase only package names, but it would require changes in xbps and some people were against it, so we are staying with the old policy - respect how upstream names it.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (19 preceding siblings ...)
  2022-07-16 10:19 ` paper42
@ 2022-07-16 10:19 ` paper42
  2022-07-16 10:19 ` paper42
                   ` (8 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: paper42 @ 2022-07-16 10:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922662493

Comment:
There has been a discussion about switching to lowercase only package names, but it would require changes in xbps and some people were against it, so we are staying with the old policy - respect how upstream names it.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (20 preceding siblings ...)
  2022-07-16 10:19 ` paper42
@ 2022-07-16 10:19 ` paper42
  2022-07-16 10:36 ` [PR PATCH] [Updated] " tranzystorek-io
                   ` (7 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: paper42 @ 2022-07-16 10:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922662512

Comment:
There has been a discussion about switching to lowercase only package names, but it would require changes in xbps and some people were against it, so we are staying with the old policy - respect how upstream names it.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR PATCH] [Updated] New package: swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (21 preceding siblings ...)
  2022-07-16 10:19 ` paper42
@ 2022-07-16 10:36 ` tranzystorek-io
  2022-07-16 10:37 ` [PR REVIEW] New package: Swapspace-1.17 tranzystorek-io
                   ` (6 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16 10:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages swapspace
https://github.com/void-linux/void-packages/pull/37992

New package: swapspace-1.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swapspace-37992.patch --]
[-- Type: text/x-diff, Size: 1652 bytes --]

From 4e8acfad2d78865b4ded37cec9e5f62e7dda4dc9 Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 11 Jul 2022 00:11:22 +0200
Subject: [PATCH] New package: Swapspace-1.17

---
 srcpkgs/Swapspace/files/swapspace/run |  6 ++++++
 srcpkgs/Swapspace/template            | 23 +++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/Swapspace/files/swapspace/run
 create mode 100644 srcpkgs/Swapspace/template

diff --git a/srcpkgs/Swapspace/files/swapspace/run b/srcpkgs/Swapspace/files/swapspace/run
new file mode 100644
index 000000000000..ffa427936a33
--- /dev/null
+++ b/srcpkgs/Swapspace/files/swapspace/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+set -e
+
+[ -d /var/lib/swapspace ] || install -d -m0700 /var/lib/swapspace
+exec swapspace
diff --git a/srcpkgs/Swapspace/template b/srcpkgs/Swapspace/template
new file mode 100644
index 000000000000..a4aa629d6175
--- /dev/null
+++ b/srcpkgs/Swapspace/template
@@ -0,0 +1,23 @@
+# Template file for 'Swapspace'
+pkgname=Swapspace
+version=1.17
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+short_desc="Dynamic swap manager for Linux"
+maintainer="Marcin Puc <tranzystorek.io@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/Tookmund/swapspace"
+changelog="https://raw.githubusercontent.com/Tookmund/Swapspace/master/NEWS"
+distfiles="https://github.com/Tookmund/Swapspace/archive/v${version}/${version}.tar.gz"
+checksum=5a2d82ae7922588bf0c3e3728248672b94666bab76b4be569d3a8793edfabb4f
+
+pre_configure() {
+	autoreconf -vfi
+}
+
+post_install() {
+	vman doc/swapspace.8
+
+	vsv swapspace
+}

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (22 preceding siblings ...)
  2022-07-16 10:36 ` [PR PATCH] [Updated] " tranzystorek-io
@ 2022-07-16 10:37 ` tranzystorek-io
  2022-07-16 19:58 ` Chocimier
                   ` (5 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16 10:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922664067

Comment:
Alright then, done

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (23 preceding siblings ...)
  2022-07-16 10:37 ` [PR REVIEW] New package: Swapspace-1.17 tranzystorek-io
@ 2022-07-16 19:58 ` Chocimier
  2022-07-16 20:14 ` tranzystorek-io
                   ` (4 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-16 19:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922715727

Comment:
Don't you run that service all the time?

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR REVIEW] New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (24 preceding siblings ...)
  2022-07-16 19:58 ` Chocimier
@ 2022-07-16 20:14 ` tranzystorek-io
  2022-07-16 20:15 ` [PR PATCH] [Updated] " tranzystorek-io
                   ` (3 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16 20:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#discussion_r922717027

Comment:
Good point, also I see that `/var/lib/*` dirs are not typically created in runit scripts

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR PATCH] [Updated] New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (25 preceding siblings ...)
  2022-07-16 20:14 ` tranzystorek-io
@ 2022-07-16 20:15 ` tranzystorek-io
  2022-07-16 21:09 ` Chocimier
                   ` (2 subsequent siblings)
  29 siblings, 0 replies; 31+ messages in thread
From: tranzystorek-io @ 2022-07-16 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is an updated pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages swapspace
https://github.com/void-linux/void-packages/pull/37992

New package: Swapspace-1.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swapspace-37992.patch --]
[-- Type: text/x-diff, Size: 1617 bytes --]

From 48c7bf921c65cb22be7b8303bfc07db9eb2bd685 Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 11 Jul 2022 00:11:22 +0200
Subject: [PATCH] New package: Swapspace-1.17

---
 srcpkgs/Swapspace/files/swapspace/run |  2 ++
 srcpkgs/Swapspace/template            | 24 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/Swapspace/files/swapspace/run
 create mode 100644 srcpkgs/Swapspace/template

diff --git a/srcpkgs/Swapspace/files/swapspace/run b/srcpkgs/Swapspace/files/swapspace/run
new file mode 100644
index 000000000000..d07bc78f2e7d
--- /dev/null
+++ b/srcpkgs/Swapspace/files/swapspace/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec swapspace
diff --git a/srcpkgs/Swapspace/template b/srcpkgs/Swapspace/template
new file mode 100644
index 000000000000..b6c8b279e076
--- /dev/null
+++ b/srcpkgs/Swapspace/template
@@ -0,0 +1,24 @@
+# Template file for 'Swapspace'
+pkgname=Swapspace
+version=1.17
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+short_desc="Dynamic swap manager for Linux"
+maintainer="Marcin Puc <tranzystorek.io@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/Tookmund/swapspace"
+changelog="https://raw.githubusercontent.com/Tookmund/Swapspace/master/NEWS"
+distfiles="https://github.com/Tookmund/Swapspace/archive/v${version}/${version}.tar.gz"
+checksum=5a2d82ae7922588bf0c3e3728248672b94666bab76b4be569d3a8793edfabb4f
+make_dirs="/var/lib/swapspace 0700 root root"
+
+pre_configure() {
+	autoreconf -vfi
+}
+
+post_install() {
+	vman doc/swapspace.8
+
+	vsv swapspace
+}

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR PATCH] [Updated] New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (26 preceding siblings ...)
  2022-07-16 20:15 ` [PR PATCH] [Updated] " tranzystorek-io
@ 2022-07-16 21:09 ` Chocimier
  2022-07-16 21:09 ` Chocimier
  2022-07-16 21:09 ` [PR PATCH] [Merged]: " Chocimier
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-16 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by Chocimier against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages swapspace
https://github.com/void-linux/void-packages/pull/37992

New package: Swapspace-1.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swapspace-37992.patch --]
[-- Type: text/x-diff, Size: 1652 bytes --]

From 7ec87d20e89109e968c41867134684a194462d9a Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Mon, 11 Jul 2022 00:11:22 +0200
Subject: [PATCH] New package: Swapspace-1.17

---
 srcpkgs/Swapspace/files/swapspace/run |  2 ++
 srcpkgs/Swapspace/template            | 25 +++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 srcpkgs/Swapspace/files/swapspace/run
 create mode 100644 srcpkgs/Swapspace/template

diff --git a/srcpkgs/Swapspace/files/swapspace/run b/srcpkgs/Swapspace/files/swapspace/run
new file mode 100644
index 000000000000..d07bc78f2e7d
--- /dev/null
+++ b/srcpkgs/Swapspace/files/swapspace/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec swapspace
diff --git a/srcpkgs/Swapspace/template b/srcpkgs/Swapspace/template
new file mode 100644
index 000000000000..ad7b6bde8426
--- /dev/null
+++ b/srcpkgs/Swapspace/template
@@ -0,0 +1,25 @@
+# Template file for 'Swapspace'
+pkgname=Swapspace
+version=1.17
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+short_desc="Dynamic swap manager for Linux"
+maintainer="Marcin Puc <tranzystorek.io@protonmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/Tookmund/swapspace"
+changelog="https://raw.githubusercontent.com/Tookmund/Swapspace/master/NEWS"
+distfiles="https://github.com/Tookmund/Swapspace/archive/v${version}/${version}.tar.gz"
+checksum=5a2d82ae7922588bf0c3e3728248672b94666bab76b4be569d3a8793edfabb4f
+conf_files="/etc/swapspace.conf"
+make_dirs="/var/lib/swapspace 0700 root root"
+
+pre_configure() {
+	autoreconf -vfi
+}
+
+post_install() {
+	vman doc/swapspace.8
+
+	vsv swapspace
+}

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (27 preceding siblings ...)
  2022-07-16 21:09 ` Chocimier
@ 2022-07-16 21:09 ` Chocimier
  2022-07-16 21:09 ` [PR PATCH] [Merged]: " Chocimier
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-16 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37992#issuecomment-1186293591

Comment:
Added `conf_files`.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [PR PATCH] [Merged]: New package: Swapspace-1.17
  2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
                   ` (28 preceding siblings ...)
  2022-07-16 21:09 ` Chocimier
@ 2022-07-16 21:09 ` Chocimier
  29 siblings, 0 replies; 31+ messages in thread
From: Chocimier @ 2022-07-16 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

There's a merged pull request on the void-packages repository

New package: Swapspace-1.17
https://github.com/void-linux/void-packages/pull/37992

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Closes #37973 

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 31+ messages in thread

end of thread, other threads:[~2022-07-16 21:09 UTC | newest]

Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-10 22:48 [PR PATCH] New package: swapspace-1.17 tranzystorek-io
2022-07-11  9:07 ` pc00per
2022-07-11  9:14 ` tranzystorek-io
2022-07-11  9:20 ` pc00per
2022-07-11  9:23 ` tranzystorek-io
2022-07-11  9:23 ` tranzystorek-io
2022-07-11  9:56 ` tranzystorek-io
2022-07-11 10:23 ` pc00per
2022-07-11 11:58 ` [PR REVIEW] " wael444
2022-07-11 11:58 ` wael444
2022-07-11 12:09 ` tranzystorek-io
2022-07-11 12:11 ` tranzystorek-io
2022-07-11 12:13 ` wael444
2022-07-12  9:13 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-15 15:02 ` [PR REVIEW] " classabbyamp
2022-07-15 21:23 ` Chocimier
2022-07-15 21:25 ` Chocimier
2022-07-15 21:35 ` paper42
2022-07-16  8:48 ` tranzystorek-io
2022-07-16  8:56 ` tranzystorek-io
2022-07-16 10:19 ` paper42
2022-07-16 10:19 ` paper42
2022-07-16 10:19 ` paper42
2022-07-16 10:36 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-16 10:37 ` [PR REVIEW] New package: Swapspace-1.17 tranzystorek-io
2022-07-16 19:58 ` Chocimier
2022-07-16 20:14 ` tranzystorek-io
2022-07-16 20:15 ` [PR PATCH] [Updated] " tranzystorek-io
2022-07-16 21:09 ` Chocimier
2022-07-16 21:09 ` Chocimier
2022-07-16 21:09 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).