[PR PATCH] poppler: add and enable nss build option

[PR PATCH] poppler: add and enable nss build option

[pr2502]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

There is a new pull request by pr2502 against master on the void-packages repository

https://github.com/pr2502/void-ports poppler-nss-opt
https://github.com/void-linux/void-packages/pull/38086

poppler: add and enable nss build option
Void poppler utils are missing the `pdfsig` utility, after adding nss-devel as a build dependency cmake detects it and builds the utility.

#### Testing the changes
- I tested the changes in this PR: **briefly** ?
I've been running this patch on poppler updated to 22.06 without issues for a few weeks, but void got updated to 22.07 before I made a PR, so here is this patch on its own, I haven't tested it much at all on 22.07.

A patch file from https://github.com/void-linux/void-packages/pull/38086.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poppler-nss-opt-38086.patch --]
[-- Type: text/x-diff, Size: 1593 bytes --]

From 41b00a19a55376acab40ae6110ce7760f83fdde6 Mon Sep 17 00:00:00 2001
From: max <36980911+pr2502@users.noreply.github.com>
Date: Fri, 15 Jul 2022 16:58:36 +0200
Subject: [PATCH] poppler: add and enable nss build option

---
 srcpkgs/poppler/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/poppler/template b/srcpkgs/poppler/template
index 74af1e5d2b63..b746e068d6e2 100644
--- a/srcpkgs/poppler/template
+++ b/srcpkgs/poppler/template
@@ -4,7 +4,7 @@
 #
 pkgname=poppler
 version=22.07.0
-revision=1
+revision=2
 _testVersion=920c89f8f43bdfe8966c8e397e7f67f5302e9435
 build_style=cmake
 build_helper="gir"
@@ -14,7 +14,7 @@ configure_args="-DENABLE_UNSTABLE_API_ABI_HEADERS=ON -DENABLE_CPP=ON
  -DTESTDATADIR='${XBPS_BUILDDIR}/test-${_testVersion}'"
 hostmakedepends="pkg-config glib-devel"
 makedepends="libpng-devel libglib-devel cairo-devel tiff-devel lcms2-devel
-libcurl-devel libopenjpeg2-devel $(vopt_if boost boost-devel)"
+libcurl-devel libopenjpeg2-devel $(vopt_if boost boost-devel) $(vopt_if nss nss-devel)"
 short_desc="PDF rendering library"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, GPL-3.0-or-later"
@@ -25,8 +25,8 @@ distfiles="${homepage}/${pkgname}-${version}.tar.xz
 checksum="420230c5c43782e2151259b3e523e632f4861342aad70e7e20b8773d9eaf3428
  ca35f168a18038a2d817ea30d6c7b4ab8294a40a5f5950f3c2a15183ba08c900"
 
-build_options="gir boost"
-build_options_default="gir boost"
+build_options="gir boost nss"
+build_options_default="gir boost nss"
 
 libpoppler_package() {
 	depends="poppler-data"

Re: poppler: add and enable nss build option

[sgn]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38086#issuecomment-1186186036

Comment:
Just enable nss unconditionally. Modern system always have nss because of either firefox or chrome

Re: [PR PATCH] [Closed]: poppler: add and enable nss build option

[sgn]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There's a closed pull request on the void-packages repository

poppler: add and enable nss build option
https://github.com/void-linux/void-packages/pull/38086

Description:
Void poppler utils are missing the `pdfsig` utility, after adding nss-devel as a build dependency cmake detects it and builds the utility.

#### Testing the changes
- I tested the changes in this PR: **briefly** ?
I've been running this patch on poppler updated to 22.06 without issues for a few weeks, but void got updated to 22.07 before I made a PR, so here is this patch on its own, I haven't tested it much at all on 22.07.