From: TinfoilSubmarine <TinfoilSubmarine@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] php8.1: update to 8.1.8, add changelog URL, fix man pages
Date: Tue, 19 Jul 2022 15:06:31 +0200 [thread overview]
Message-ID: <20220719130631.Y6caRryLGZp8vQ0nO52EcnMjePTEn2HeFlMXFBjJav8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37949@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
New review comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/37949#discussion_r924478188
Comment:
I would rather not have a regex running directly in the template because it is harder to understand what is happening (at least for me :/ )... Could we just include a patch with the result of this regex instead? You could include this shell-fu as a comment at the top so it's easy to update if there was ever a new manpage that needed to be fixed.
```
Fix .so links in man pages
This is needed because of the configure option -
--program-suffix=${_php_version}
_regexp='^[[:space:]]*\.so[[:space:]]'
_php_version=8.1
for file in $(grep -l -e "$_regexp" -R .); do
sed --debug -i "$file" -e "/$_regexp/"'s=^[[:space:]]*\.[^.]*=&'${_php_version}=
done
diff --git a/ext/phar/phar.phar.1.in b/ext/phar/phar.phar.1.in
index b5eecbfe..5852619e 100644
--- a/ext/phar/phar.phar.1.in
+++ b/ext/phar/phar.phar.1.in
@@ -1 +1 @@
-.so man1/phar.1
+.so man1/phar8.1.1
diff --git a/sapi/cgi/php-cgi.1.in b/sapi/cgi/php-cgi.1.in
index 340e6c5d..8b39d023 100644
--- a/sapi/cgi/php-cgi.1.in
+++ b/sapi/cgi/php-cgi.1.in
@@ -1 +1 @@
-.so man1/php.1
+.so man1/php8.1.1
```
next prev parent reply other threads:[~2022-07-19 13:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 18:47 [PR PATCH] php8.1: update to 8.1.8, add changelog URL, fix manpages subnut
2022-07-09 18:47 ` [PR PATCH] [Updated] " subnut
2022-07-09 18:50 ` subnut
2022-07-09 19:36 ` [PR PATCH] [Updated] php8.1: update to 8.1.8, add changelog URL subnut
2022-07-10 5:58 ` subnut
2022-07-10 6:27 ` [PR PATCH] [Updated] php8.1: update to 8.1.8, add changelog URL, fix man pages subnut
2022-07-10 7:15 ` meator
2022-07-10 9:09 ` [PR PATCH] [Updated] " subnut
2022-07-10 9:13 ` subnut
2022-07-19 10:44 ` subnut
2022-07-19 13:06 ` TinfoilSubmarine [this message]
2022-07-19 14:57 ` [PR REVIEW] " subnut
2022-07-19 15:01 ` subnut
2022-07-19 15:07 ` subnut
2022-07-19 15:29 ` classabbyamp
2022-07-19 15:30 ` classabbyamp
2022-07-20 11:56 ` [PR PATCH] [Updated] " subnut
2022-07-20 12:15 ` [PR REVIEW] " subnut
2022-07-20 12:16 ` subnut
2022-07-20 12:16 ` subnut
2022-07-21 3:44 ` classabbyamp
2022-07-21 10:09 ` subnut
2022-08-03 22:52 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719130631.Y6caRryLGZp8vQ0nO52EcnMjePTEn2HeFlMXFBjJav8@z \
--to=tinfoilsubmarine@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).