[PR PATCH] Komikku: update to 0.39.0.

[PR PATCH] Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

There is a new pull request by Nathan-MV against master on the void-packages repository

https://github.com/Nathan-MV/void-packages Komikku-0.39.0
https://github.com/void-linux/void-packages/pull/38235

Komikku: update to 0.39.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**
Sorry for the spam, btw.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38235.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Komikku-0.39.0-38235.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]

From bf3773c943ea4e056457f0e18f86a0f0a9ebe6b2 Mon Sep 17 00:00:00 2001
From: Nathan-MV <67521199+Nathan-MV@users.noreply.github.com>
Date: Sun, 24 Jul 2022 02:22:06 -0300
Subject: [PATCH] Update template

---
 srcpkgs/Komikku/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 89da2026f68e..32a897d7ab8e 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,6 +1,6 @@
 # Template file for 'Komikku'
 pkgname=Komikku
-version=0.37.0
+version=0.39.0
 revision=1
 wrksrc=Komikku-v${version}
 build_style=meson
@@ -9,11 +9,12 @@ makedepends="gtk+3-devel libhandy1-devel glade3-devel"
 depends="gtk+3 libhandy1 libnotify libsecret python3-BeautifulSoup4
  python3-Pillow python3-Unidecode python3-cloudscraper python3-dateparser
  python3-gobject python3-keyring python3-lxml python3-magic
- python3-natsort python3-pure-protobuf"
+ python3-natsort python3-pure-protobuf python3-wheel
+ python-pytz webkit2gtk"
 checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/valos/Komikku"
 distfiles="https://gitlab.com/valos/Komikku/-/archive/v${version}/Komikku-v${version}.tar.gz"
-checksum=f126d91a21663d60c502a45ad9171bad933255839bc17a20b2f6c83500dfc4bf
+checksum=73a5a4d82895dd114ebd558273d7f4f2bdd7f39694320299dd406a2e083f2433

Re: Komikku: update to 0.39.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193254690

Comment:
please don't close/reopen PRs. you may want to make your changes locally instead of using using github web (this also makes it possible to test your changes)

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193256331

Comment:
> please don't close/reopen PRs. you may want to make your changes locally instead of using using github web (this also makes it possible to test your changes)

I tested the changes in a cloned fork, but i have not configured my github-cli to push my changes, so i edited it thought github web, the thing that i don`t know now is why xlint is failing here?

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193256331

Comment:
> please don't close/reopen PRs. you may want to make your changes locally instead of using using github web (this also makes it possible to test your changes)

I tested the changes in a cloned fork, but i haven`t configured my github-cli to push my changes, so i edited it thought github web, the thing that i don`t know now is why xlint is failing here?

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193256331

Comment:
> please don't close/reopen PRs. you may want to make your changes locally instead of using using github web (this also makes it possible to test your changes)

I tested the changes in a cloned fork, but i haven't configured my github-cli to push my changes, so i edited it thought github web, the thing that i don't know now is why xlint is failing here?

Re: Komikku: update to 0.39.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193257001

Comment:
take a look at [the log](https://github.com/void-linux/void-packages/runs/7485935637?check_suite_focus=true#step:7:9)

Re: [PR PATCH] [Updated] Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

There is an updated pull request by Nathan-MV against master on the void-packages repository

https://github.com/Nathan-MV/void-packages Komikku-0.39.0
https://github.com/void-linux/void-packages/pull/38235

Komikku: update to 0.39.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

Sorry for the spam, btw.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38235.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Komikku-0.39.0-38235.patch --]
[-- Type: text/x-diff, Size: 2548 bytes --]

From bf3773c943ea4e056457f0e18f86a0f0a9ebe6b2 Mon Sep 17 00:00:00 2001
From: Nathan-MV <67521199+Nathan-MV@users.noreply.github.com>
Date: Sun, 24 Jul 2022 02:22:06 -0300
Subject: [PATCH 1/2] Update template

---
 srcpkgs/Komikku/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 89da2026f68e..32a897d7ab8e 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,6 +1,6 @@
 # Template file for 'Komikku'
 pkgname=Komikku
-version=0.37.0
+version=0.39.0
 revision=1
 wrksrc=Komikku-v${version}
 build_style=meson
@@ -9,11 +9,12 @@ makedepends="gtk+3-devel libhandy1-devel glade3-devel"
 depends="gtk+3 libhandy1 libnotify libsecret python3-BeautifulSoup4
  python3-Pillow python3-Unidecode python3-cloudscraper python3-dateparser
  python3-gobject python3-keyring python3-lxml python3-magic
- python3-natsort python3-pure-protobuf"
+ python3-natsort python3-pure-protobuf python3-wheel
+ python-pytz webkit2gtk"
 checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/valos/Komikku"
 distfiles="https://gitlab.com/valos/Komikku/-/archive/v${version}/Komikku-v${version}.tar.gz"
-checksum=f126d91a21663d60c502a45ad9171bad933255839bc17a20b2f6c83500dfc4bf
+checksum=73a5a4d82895dd114ebd558273d7f4f2bdd7f39694320299dd406a2e083f2433

From 6eb2a2affbe788fbf190d53b46fba848da493f8f Mon Sep 17 00:00:00 2001
From: Nathan-MV <67521199+Nathan-MV@users.noreply.github.com>
Date: Sun, 24 Jul 2022 03:36:09 -0300
Subject: [PATCH 2/2] Update template

---
 srcpkgs/Komikku/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 32a897d7ab8e..f04bcff1b469 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -9,8 +9,8 @@ makedepends="gtk+3-devel libhandy1-devel glade3-devel"
 depends="gtk+3 libhandy1 libnotify libsecret python3-BeautifulSoup4
  python3-Pillow python3-Unidecode python3-cloudscraper python3-dateparser
  python3-gobject python3-keyring python3-lxml python3-magic
- python3-natsort python3-pure-protobuf python3-wheel
- python-pytz webkit2gtk"
+ python3-natsort python3-pure-protobuf python3-wheel python-pytz
+ webkit2gtk"
 checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"

Re: Komikku: update to 0.39.0.

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/38235#issuecomment-1193320237

Comment:
change your commit message according to the guidelines. make one commit.

Re: [PR PATCH] [Closed]: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

There's a closed pull request on the void-packages repository

Komikku: update to 0.39.0.
https://github.com/void-linux/void-packages/pull/38235

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

Sorry for the spam, btw.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38248#issuecomment-1193424501

Comment:
It doesn't seem to start unless you have `gnome-keyring`?

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38248#issuecomment-1193424501

Comment:
It doesn't seem to start unless you have gnome-keyring?

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38248#issuecomment-1193424501

Comment:
It appears to don't launch unless you have gnome-keyring?

Re: Komikku: update to 0.39.0.

[Nathan-MV]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

New comment by Nathan-MV on void-packages repository

https://github.com/void-linux/void-packages/pull/38248#issuecomment-1193354355

Comment:
> Once again, please learn how to force push to existing branches to update this PR without closing it and opening a new one. That just spams everyone with useless notifications and the whole review history is lost. If that happens, at least link all of the closed PRs so reviewers check the reviews there.

I have that power now, don't worry, example above.

Re: Komikku: update to 0.39.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38248#issuecomment-1193346345

Comment:
Once again, please learn how to force push to existing branches to update this PR without closing it and opening a new one. That just spams everyone with useless notifications and the whole review history is lost.
If that happens, at least link all of the closed PRs so reviewers check the reviews there.