Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] batsignal: update to 1.5.0.
@ 2022-07-24 20:13 motorto
  2022-07-24 21:29 ` [PR PATCH] [Updated] " motorto
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: motorto @ 2022-07-24 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

There is a new pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}


A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 1055 bytes --]

From 3d31b24770600a8164db31bfa407c3bb4559f6a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..a6f112d6da1d 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,6 +1,6 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
@@ -11,7 +11,7 @@ maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
@ 2022-07-24 21:29 ` motorto
  2022-07-25  8:15 ` motorto
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-24 21:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}


A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 4475 bytes --]

From 1d9f51e0999bffc63112da12002a928c44bbfb7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/makefile.patch       | 40 ++++++++++++++++++++++
 srcpkgs/batsignal/patches/0001-b.patch | 47 ++++++++++++++++++++++++++
 srcpkgs/batsignal/template             |  6 ++--
 3 files changed, 90 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/batsignal/makefile.patch
 create mode 100644 srcpkgs/batsignal/patches/0001-b.patch

diff --git a/srcpkgs/batsignal/makefile.patch b/srcpkgs/batsignal/makefile.patch
new file mode 100644
index 000000000000..06ee4e6d5970
--- /dev/null
+++ b/srcpkgs/batsignal/makefile.patch
@@ -0,0 +1,40 @@
+From 08459907cb33822e85779dc311ed0d5ec770f2fc Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
+Date: Sun, 24 Jul 2022 21:35:52 +0100
+Subject: [PATCH 1/1] b
+
+---
+ Makefile | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index a50c609..8bfca4e 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,7 +1,7 @@
+ .POSIX:
+ 
+ NAME = batsignal
+-VERSION != grep VERSION version.h | cut -d \" -f2
++VERSION = $(shell grep VERSION version.h | cut -d \" -f2)
+ 
+ CC = cc
+ RM = rm -f
+@@ -17,12 +17,12 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) $(CFLAGS) -std=c99 $(shell pkg-config --cflags libnotify)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS) $(shell pkg-config --libs libnotify)
+ 
+ all: $(NAME) $(NAME).1
+ 
+-- 
+2.37.1
+
diff --git a/srcpkgs/batsignal/patches/0001-b.patch b/srcpkgs/batsignal/patches/0001-b.patch
new file mode 100644
index 000000000000..c79840f38cd5
--- /dev/null
+++ b/srcpkgs/batsignal/patches/0001-b.patch
@@ -0,0 +1,47 @@
+From ff192a7540e9e2101c483e80c362dbee2e81addd Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
+Date: Sun, 24 Jul 2022 21:49:44 +0100
+Subject: [PATCH 1/1] Fix Makefile
+
+---
+ Makefile | 16 +++++++++-------
+ 1 file changed, 9 insertions(+), 7 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index a50c609..8b3f8c5 100644
+--- a/Makefile
++++ b/Makefile
+@@ -15,21 +15,23 @@ MANPREFIX./usr/local=/usr/local/man
+ MANPREFIX.=/usr/share/man
+ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+-INCLUDES != pkg-config --cflags libnotify
++# INCLUDES !=  $(shell pkg-config --libs libnotify)
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++# CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA)  -std=c99 $(shell pkg-config --cflags libnotify) $(CFLAGS)
+ 
+-LIBS != pkg-config --libs libnotify
+-LIBS := $(LIBS) -lm
+-LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++# LIBS !=  $(shell pkg-config --libs libnotify)
++# LIBS := $(LIBS) -lm
++# LDFLAGS_EXTRA = -s
++# LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := -lm $(shell pkg-config --libs libnotify) $(LDFLAGS)
+ 
+ all: $(NAME) $(NAME).1
+ 
+ $(NAME).o: version.h
+ 
+ $(NAME): $(NAME).o
+-	$(CC) -o $(NAME) $(NAME).o $(LDFLAGS)
++	$(CC) $(CFLAGS) -o $(NAME) $(NAME).o $(LDFLAGS)
+ 
+ $(NAME).1: $(NAME).1.in version.h
+ 	$(SED) "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
+-- 
+2.37.1
+
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..ee9f52deafca 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,17 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
  2022-07-24 21:29 ` [PR PATCH] [Updated] " motorto
@ 2022-07-25  8:15 ` motorto
  2022-07-25 11:23 ` [PR REVIEW] " sgn
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25  8:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 3932 bytes --]

From de6f7668c1d1192818f448f21625e3225aad913f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 75 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  7 +--
 2 files changed, 78 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..6c7aa60397b4
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,75 @@
+From cb1a6ad9a2d17ae908e94a87ff8e6fa24c2f0ceb Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
+Date: Mon, 25 Jul 2022 08:49:39 +0100
+Subject: [PATCH 1/1] b
+
+---
+ Makefile | 36 +++++++++++-------------------------
+ 1 file changed, 11 insertions(+), 25 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index a50c609..9d5b712 100644
+--- a/Makefile
++++ b/Makefile
+@@ -3,47 +3,33 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+-RM = rm -f
+-INSTALL = install
+-SED = sed
+-
+ PREFIX = /usr/local
+ 
+-MANPREFIX.$(PREFIX)=$(PREFIX)/share/man
+-MANPREFIX./usr/local=/usr/local/man
+-MANPREFIX.=/usr/share/man
+-MANPREFIX=$(MANPREFIX.$(PREFIX))
+-
+-INCLUDES != pkg-config --cflags libnotify
+-CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++MANPREFIX = $(PREFIX)/share/man
+ 
+-LIBS != pkg-config --libs libnotify
+-LIBS := $(LIBS) -lm
+-LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os -s
++CFLAGS := $(CFLAGS_EXTRA) $(CFLAGS) -std=c99 $(shell pkg-config --cflags libnotify)
++LDFLAGS := $(LDFLAGS) -lm $(shell pkg-config --libs libnotify)
+ 
+ all: $(NAME) $(NAME).1
+ 
+ $(NAME).o: version.h
+ 
+ $(NAME): $(NAME).o
+-	$(CC) -o $(NAME) $(NAME).o $(LDFLAGS)
+ 
+ $(NAME).1: $(NAME).1.in version.h
+-	$(SED) "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
++	sed "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
+ 
+ install: all
+ 	@echo Installing in $(DESTDIR)$(PREFIX)
+-	$(INSTALL) -d $(DESTDIR)$(PREFIX)/bin
+-	$(INSTALL) -d $(DESTDIR)$(MANPREFIX)/man1
+-	$(INSTALL) -m 0755 $(NAME) $(DESTDIR)$(PREFIX)/bin/
+-	$(INSTALL) -m 0644 $(NAME).1 $(DESTDIR)$(MANPREFIX)/man1/
++	install -d $(DESTDIR)$(PREFIX)/bin
++	install -d $(DESTDIR)$(MANPREFIX)/man1
++	install -m 0755 $(NAME) $(DESTDIR)$(PREFIX)/bin/
++	install -m 0644 $(NAME).1 $(DESTDIR)$(MANPREFIX)/man1/
+ 
+ install-service: install
+-	$(INSTALL) -d $(DESTDIR)$(PREFIX)/lib/systemd/user
+-	$(INSTALL) -m 0644 $(NAME).service $(DESTDIR)$(PREFIX)/lib/systemd/user/
++	install -d $(DESTDIR)$(PREFIX)/lib/systemd/user
++	install -m 0644 $(NAME).service $(DESTDIR)$(PREFIX)/lib/systemd/user/
+ 
+ uninstall:
+ 	@echo Removing files from $(DESTDIR)$(PREFIX)
+-- 
+2.37.1
+
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..e5936ed16dfc 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,16 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
-make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
  2022-07-24 21:29 ` [PR PATCH] [Updated] " motorto
  2022-07-25  8:15 ` motorto
@ 2022-07-25 11:23 ` sgn
  2022-07-25 11:23 ` sgn
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 11:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#discussion_r928771289

Comment:
Don't patch those variables out. They're noise.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (2 preceding siblings ...)
  2022-07-25 11:23 ` [PR REVIEW] " sgn
@ 2022-07-25 11:23 ` sgn
  2022-07-25 11:24 ` sgn
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 11:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#discussion_r928771670

Comment:
And those lines, too

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (3 preceding siblings ...)
  2022-07-25 11:23 ` sgn
@ 2022-07-25 11:24 ` sgn
  2022-07-25 11:33 ` [PR PATCH] [Updated] " motorto
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 11:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#discussion_r928771852

Comment:
And those lines.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (4 preceding siblings ...)
  2022-07-25 11:24 ` sgn
@ 2022-07-25 11:33 ` motorto
  2022-07-25 11:35 ` motorto
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25 11:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2444 bytes --]

From d27c53a466c1005500839b6224613c29932af027 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 31 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  7 +++---
 2 files changed, 34 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..90a880ccf8ac
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,31 @@
+From 983f0ea40bdaa679afdf60cc0966300732813de6 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
+Date: Mon, 25 Jul 2022 12:31:23 +0100
+Subject: [PATCH 1/1] b
+
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index a50c609..62bb975 100644
+--- a/Makefile
++++ b/Makefile
+@@ -17,12 +17,12 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) $(CFLAGS) -std=c11 $(INCLUDES)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA) $(LDFLAGS)
+ 
+ all: $(NAME) $(NAME).1
+ 
+-- 
+2.37.1
+
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..e5936ed16dfc 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,16 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
-make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (5 preceding siblings ...)
  2022-07-25 11:33 ` [PR PATCH] [Updated] " motorto
@ 2022-07-25 11:35 ` motorto
  2022-07-25 12:04 ` [PR PATCH] [Updated] " sgn
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25 11:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#issuecomment-1193934988

Comment:
@sgn Is that what you meant ? (Pushed changes to makefile) I didn't understand what you meant. (It still doesn't compile this way) gives me:

```text
=> batsignal-1.5.0_1: running do_build ...
cc -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/batsignal-1.5.0=.      -c -o batsignal.o batsignal.c
sed "s/VERSION/1.5.0/g" < batsignal.1.in > batsignal.1
In file included from batsignal.c:22:
/usr/include/libnotify/notify.h:25:10: fatal error: glib.h: No such file or directory
   25 | #include <glib.h>
      |          ^~~~~~~~
compilation terminated.
make: *** [<builtin>: batsignal.o] Error 1
=> ERROR: batsignal-1.5.0_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:9
```

Which makes me think that I am overriding still the flags 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (6 preceding siblings ...)
  2022-07-25 11:35 ` motorto
@ 2022-07-25 12:04 ` sgn
  2022-07-25 12:05 ` sgn
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 12:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2252 bytes --]

From 01890f8ded724a0c0f15c1e833355b771373747c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

Close: #38252
---
 srcpkgs/batsignal/patches/makefile.patch | 25 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  6 +++---
 2 files changed, 28 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..b4a7d3e8ece1
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,25 @@
+--- a/Makefile
++++ b/Makefile
+@@ -3,7 +3,6 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+ RM = rm -f
+ INSTALL = install
+ SED = sed
+@@ -17,12 +16,12 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) $(CFLAGS) -std=c11 $(INCLUDES)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS_EXTRA) $(CFLAGS) $(LDFLAGS) $(LIBS)
+ 
+ all: $(NAME) $(NAME).1
+ 
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..ee9f52deafca 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,17 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (7 preceding siblings ...)
  2022-07-25 12:04 ` [PR PATCH] [Updated] " sgn
@ 2022-07-25 12:05 ` sgn
  2022-07-25 12:08 ` sgn
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 12:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2238 bytes --]

From 22fdd9a1751a7846dd671effbc9912c55cb94e48 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 25 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  6 +++---
 2 files changed, 28 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..b4a7d3e8ece1
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,25 @@
+--- a/Makefile
++++ b/Makefile
+@@ -3,7 +3,6 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+ RM = rm -f
+ INSTALL = install
+ SED = sed
+@@ -17,12 +16,12 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) $(CFLAGS) -std=c11 $(INCLUDES)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS_EXTRA) $(CFLAGS) $(LDFLAGS) $(LIBS)
+ 
+ all: $(NAME) $(NAME).1
+ 
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..ee9f52deafca 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,17 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (8 preceding siblings ...)
  2022-07-25 12:05 ` sgn
@ 2022-07-25 12:08 ` sgn
  2022-07-25 12:13 ` [PR PATCH] [Updated] " sgn
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#issuecomment-1193966361

Comment:
@motorto  I fixed the patch for you.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (9 preceding siblings ...)
  2022-07-25 12:08 ` sgn
@ 2022-07-25 12:13 ` sgn
  2022-07-25 12:36 ` motorto
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 12:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2476 bytes --]

From d801f9ab640e8d73d8b6d5b574791fbe181f0b4c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 34 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  6 ++---
 2 files changed, 37 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..537335eb3db5
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,34 @@
+Patched by sgn
+--- a/Makefile
++++ b/Makefile
+@@ -3,7 +3,6 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+ RM = rm -f
+ INSTALL = install
+ SED = sed
+@@ -17,19 +16,19 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES) $(CFLAGS)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS_EXTRA) $(CFLAGS) $(LDFLAGS)
+ 
+ all: $(NAME) $(NAME).1
+ 
+ $(NAME).o: version.h
+ 
+ $(NAME): $(NAME).o
+-	$(CC) -o $(NAME) $(NAME).o $(LDFLAGS)
++	$(CC) -o $(NAME) $(LDFLAGS) $(NAME).o $(LIBS)
+ 
+ $(NAME).1: $(NAME).1.in version.h
+ 	$(SED) "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..ee9f52deafca 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,17 +1,17 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pkg-config"
-makedepends="libnotify-devel"
+makedepends="libnotify-devel libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (10 preceding siblings ...)
  2022-07-25 12:13 ` [PR PATCH] [Updated] " sgn
@ 2022-07-25 12:36 ` motorto
  2022-07-25 12:38 ` motorto
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25 12:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2449 bytes --]

From 038dfd2c39154eb72c93c2f0eb95e03f0a3c7caa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 36 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  5 ++--
 2 files changed, 38 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..659298e6d20a
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,36 @@
+Patched by sgn
+
+--- a/Makefile
++++ b/Makefile
+@@ -3,7 +3,6 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+ RM = rm -f
+ INSTALL = install
+ SED = sed
+@@ -17,19 +16,19 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES) $(CFLAGS)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS_EXTRA) $(CFLAGS) $(LDFLAGS)
+ 
+ all: $(NAME) $(NAME).1
+ 
+ $(NAME).o: version.h
+ 
+ $(NAME): $(NAME).o
+-	$(CC) -o $(NAME) $(NAME).o $(LDFLAGS)
++	$(CC) -o $(NAME) $(LDFLAGS) $(NAME).o $(LIBS)
+ 
+ $(NAME).1: $(NAME).1.in version.h
+ 	$(SED) "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
+
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..7550155ce5a0 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,9 +1,8 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
-make_use_env=yes
 hostmakedepends="pkg-config"
 makedepends="libnotify-devel"
 short_desc="Simple battery monitor"
@@ -11,7 +10,7 @@ maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (11 preceding siblings ...)
  2022-07-25 12:36 ` motorto
@ 2022-07-25 12:38 ` motorto
  2022-07-25 12:43 ` motorto
  2022-07-25 14:26 ` [PR PATCH] [Merged]: " sgn
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25 12:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal-1.5.0
https://github.com/void-linux/void-packages/pull/38252

batsignal: update to 1.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

A patch file from https://github.com/void-linux/void-packages/pull/38252.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-1.5.0-38252.patch --]
[-- Type: text/x-diff, Size: 2350 bytes --]

From 2ed43905bafecc11e4aeaeef965500be5d703c8b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 24 Jul 2022 21:03:08 +0100
Subject: [PATCH] batsignal: update to 1.5.0.

---
 srcpkgs/batsignal/patches/makefile.patch | 36 ++++++++++++++++++++++++
 srcpkgs/batsignal/template               |  4 +--
 2 files changed, 38 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/batsignal/patches/makefile.patch

diff --git a/srcpkgs/batsignal/patches/makefile.patch b/srcpkgs/batsignal/patches/makefile.patch
new file mode 100644
index 000000000000..659298e6d20a
--- /dev/null
+++ b/srcpkgs/batsignal/patches/makefile.patch
@@ -0,0 +1,36 @@
+Patched by sgn
+
+--- a/Makefile
++++ b/Makefile
+@@ -3,7 +3,6 @@
+ NAME = batsignal
+ VERSION != grep VERSION version.h | cut -d \" -f2
+ 
+-CC = cc
+ RM = rm -f
+ INSTALL = install
+ SED = sed
+@@ -17,19 +16,19 @@ MANPREFIX=$(MANPREFIX.$(PREFIX))
+ 
+ INCLUDES != pkg-config --cflags libnotify
+ CFLAGS_EXTRA = -pedantic -Wall -Wextra -Werror -Wno-unused-parameter -Os
+-CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES)
++CFLAGS := $(CFLAGS_EXTRA) -std=c11 $(INCLUDES) $(CFLAGS)
+ 
+ LIBS != pkg-config --libs libnotify
+ LIBS := $(LIBS) -lm
+ LDFLAGS_EXTRA = -s
+-LDFLAGS := $(LIBS) $(LDFLAGS_EXTRA)
++LDFLAGS := $(LDFLAGS_EXTRA) $(CFLAGS) $(LDFLAGS)
+ 
+ all: $(NAME) $(NAME).1
+ 
+ $(NAME).o: version.h
+ 
+ $(NAME): $(NAME).o
+-	$(CC) -o $(NAME) $(NAME).o $(LDFLAGS)
++	$(CC) -o $(NAME) $(LDFLAGS) $(NAME).o $(LIBS)
+ 
+ $(NAME).1: $(NAME).1.in version.h
+ 	$(SED) "s/VERSION/$(VERSION)/g" < $(NAME).1.in > $@
+
diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index a8d55e6ad30f..a6f112d6da1d 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -1,6 +1,6 @@
 # Template file for 'batsignal'
 pkgname=batsignal
-version=1.3.2
+version=1.5.0
 revision=1
 build_style=gnu-makefile
 make_use_env=yes
@@ -11,7 +11,7 @@ maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
 homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
-checksum=d8ecb26435b4a49f804ebc2bc1f18215a4c7cfd2a5de7e2a1ccef5263e1c04e7
+checksum=be3196bac5f369348123d78cacc3d20d29005a8bc93bcbc4541231843a5a7f5f
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (12 preceding siblings ...)
  2022-07-25 12:38 ` motorto
@ 2022-07-25 12:43 ` motorto
  2022-07-25 14:26 ` [PR PATCH] [Merged]: " sgn
  14 siblings, 0 replies; 16+ messages in thread
From: motorto @ 2022-07-25 12:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/38252#issuecomment-1194000322

Comment:
Thanks @sgn was failing to pass the $libs it seems, thanks for the huge help !  

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: batsignal: update to 1.5.0.
  2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
                   ` (13 preceding siblings ...)
  2022-07-25 12:43 ` motorto
@ 2022-07-25 14:26 ` sgn
  14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2022-07-25 14:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There's a merged pull request on the void-packages repository

batsignal: update to 1.5.0.
https://github.com/void-linux/void-packages/pull/38252

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64{glibc,musl}

https://github.com/electrickite/batsignal/issues/21

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-07-25 14:26 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-24 20:13 [PR PATCH] batsignal: update to 1.5.0 motorto
2022-07-24 21:29 ` [PR PATCH] [Updated] " motorto
2022-07-25  8:15 ` motorto
2022-07-25 11:23 ` [PR REVIEW] " sgn
2022-07-25 11:23 ` sgn
2022-07-25 11:24 ` sgn
2022-07-25 11:33 ` [PR PATCH] [Updated] " motorto
2022-07-25 11:35 ` motorto
2022-07-25 12:04 ` [PR PATCH] [Updated] " sgn
2022-07-25 12:05 ` sgn
2022-07-25 12:08 ` sgn
2022-07-25 12:13 ` [PR PATCH] [Updated] " sgn
2022-07-25 12:36 ` motorto
2022-07-25 12:38 ` motorto
2022-07-25 12:43 ` motorto
2022-07-25 14:26 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).