[PR PATCH] Enable logger for thermald

[PR PATCH] Enable logger for thermald

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

There is a new pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

Enable logger for thermald
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

From e8a736214d2fdf854b94deef3c03827c3ccda8bb Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] Enable logger for thermald

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1

Re: [PR PATCH] [Updated] Enable logger for thermald

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

Enable logger for thermald
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1442 bytes --]

From 416fa61469ac7dc3fa87454696a173f87f91fa6f Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] Enable logger for thermald

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..277ca8fc853b 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,7 +1,7 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
+revision=2
 _pkgname=thermal_daemon
 archs="i686* x86_64*"
 wrksrc="${_pkgname}-${version}"

Re: Enable logger for thermald

[abenson]

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196784247

Comment:
You'll need to bump `revision` in the template.  Also, follow the convention for commit messages:  `thermald: enable logger`

Re: [PR PATCH] [Updated] Enable logger for thermald

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

Enable logger for thermald
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1439 bytes --]

From 8fd6c692c20a06558b4a7c4d2b8c9271e08a7449 Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] thermald: enable logger

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..277ca8fc853b 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,7 +1,7 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
+revision=2
 _pkgname=thermal_daemon
 archs="i686* x86_64*"
 wrksrc="${_pkgname}-${version}"

Re: Enable logger for thermald

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196785025

Comment:
@abenson done

Re: thermald: enable logger

[abenson]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196817338

Comment:
Rebase on master, it looks like you're working off an old commit.

Re: [PR PATCH] [Updated] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

thermald: enable logger
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1439 bytes --]

From 19cd58adcef5a6af2ea0cb0cbdc2e2a5425bfaaf Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] thermald: enable logger

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..277ca8fc853b 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,7 +1,7 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
+revision=2
 _pkgname=thermal_daemon
 archs="i686* x86_64*"
 wrksrc="${_pkgname}-${version}"

Re: thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196989622

Comment:
@abenson I did rebase but it looks like the problem might not be related to that PR?
Here is what I could find in the logs:
```
ERROR: Build-time cyclic dependency perl(host), perl-AnyEvent(host), perl(host) detected.
```

Re: thermald: enable logger

[paper42]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196994976

Comment:
> @abenson I did rebase but it looks like the problem might not be related to that PR? Here is what I could find in the logs:
> 
> ```
> ERROR: Build-time cyclic dependency perl(host), perl-AnyEvent(host), perl(host) detected.
> ```

That's only a check cycle, I think the cycle check script should ignore it.

Re: thermald: enable logger

[abenson]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1196996245

Comment:
I think this might be a CI issue, it builds fine locally for me.

Re: [PR PATCH] [Updated] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

thermald: enable logger
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1439 bytes --]

From f01df24a56f9e69e20bfc9009ff0df44cc1d38f6 Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] thermald: enable logger

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..277ca8fc853b 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,7 +1,7 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
+revision=2
 _pkgname=thermal_daemon
 archs="i686* x86_64*"
 wrksrc="${_pkgname}-${version}"

Re: [PR PATCH] [Updated] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

thermald: enable logger
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 1930 bytes --]

From 8383471e1e2ff57f5e4fdecbee33e87835923294 Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] thermald: enable logger

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..dbbde8b6800b 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,7 +1,7 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
+revision=2
 _pkgname=thermal_daemon
 archs="i686* x86_64*"
 wrksrc="${_pkgname}-${version}"
@@ -11,7 +11,7 @@ makedepends="dbus-glib-devel libxml2-devel libglib-devel libgomp-devel upower-de
 short_desc="Linux Thermal Daemon program from 01.org"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
 license="GPL-2.0-or-later"
-homepage="https://github.com/intel/${_pkgname}"
+homepage="https://github.com/intel/thermal_daemon"
 distfiles="${homepage}/archive/v${version}.tar.gz"
 checksum=fb793a2bfaae2e544ef62801075419587b0c045041c69eeafbf61959cce07fdb
 conf_files='/etc/thermald/*'

Re: thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1200124544

Comment:
@abenson @paper42 I rebased over master and everything looks good now. It was indeed a CI issue.

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934046101

Comment:
expand $homepage here

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934046427

Comment:
```suggestion
#!/bin/sh
exec vlogger -t thermald
```

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934046242

Comment:
```suggestion
archs="i686* x86_64*"
wrksrc="thermal_daemon-${version}"
```
variable is only used in one place now so it doesn't do much

Re: [PR REVIEW] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934051854

Comment:
I copied this from the docker package actually: https://github.com/void-linux/void-packages/blob/master/srcpkgs/moby/files/docker/log/run
So what is actually the best way? Is the docker package wrong?

Re: [PR REVIEW] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934051897

Comment:
Should the linter checks for this then?

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934052287

Comment:
1. shebang ensures it's run correctly
2. exec makes it replace the "run the log service" process instead of running it in a subprocess, which is the proper way

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934052335

Comment:
perhaps it should

Re: [PR REVIEW] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934052558

Comment:
Should I open a PR to fix docker?

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934053356

Comment:
it's actually a symlink, which github renders as a file containing one line :)

```
$ ls -l srcpkgs/moby/files/docker/log
lrwxrwxrwx 1 abby abby 16 Jun 20  2021 run -> /usr/bin/vlogger
```
so that's probably the proper solution

Re: [PR REVIEW] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934055252

Comment:
Yes, I know and that's what this PR contrains too: a symlink to vlogger. Should I keep it then?

Re: [PR REVIEW] thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#discussion_r934055812

Comment:
oh, in that case, yes, keep it.

Re: [PR PATCH] [Updated] thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages thermald-logger
https://github.com/void-linux/void-packages/pull/38308

thermald: enable logger
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38308.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thermald-logger-38308.patch --]
[-- Type: text/x-diff, Size: 2159 bytes --]

From 1d2f6a71dd7279bf757a61d12b7243f9d419b30f Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Wed, 27 Jul 2022 13:41:51 +0000
Subject: [PATCH] thermald: enable logger

---
 srcpkgs/thermald/files/thermald/log/run | 1 +
 srcpkgs/thermald/files/thermald/run     | 2 +-
 srcpkgs/thermald/template               | 9 ++++-----
 3 files changed, 6 insertions(+), 6 deletions(-)
 create mode 120000 srcpkgs/thermald/files/thermald/log/run

diff --git a/srcpkgs/thermald/files/thermald/log/run b/srcpkgs/thermald/files/thermald/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/thermald/files/thermald/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/thermald/files/thermald/run b/srcpkgs/thermald/files/thermald/run
index 4df7dd4eeb23..de5b6d5c3e1e 100644
--- a/srcpkgs/thermald/files/thermald/run
+++ b/srcpkgs/thermald/files/thermald/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 sv check dbus >/dev/null || exit 1
-exec thermald --no-daemon --dbus-enable 1>&2
+exec thermald --no-daemon --dbus-enable 2>&1
diff --git a/srcpkgs/thermald/template b/srcpkgs/thermald/template
index 633a5a498121..98a3f1f1705e 100644
--- a/srcpkgs/thermald/template
+++ b/srcpkgs/thermald/template
@@ -1,18 +1,17 @@
 # Template file for 'thermald'
 pkgname=thermald
 version=2.4.9
-revision=1
-_pkgname=thermal_daemon
+revision=2
 archs="i686* x86_64*"
-wrksrc="${_pkgname}-${version}"
+wrksrc="thermal_daemon-${version}"
 build_style=gnu-configure
 hostmakedepends="automake pkg-config glib-devel gtk-doc autoconf-archive"
 makedepends="dbus-glib-devel libxml2-devel libglib-devel libgomp-devel upower-devel libevdev-devel"
 short_desc="Linux Thermal Daemon program from 01.org"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
 license="GPL-2.0-or-later"
-homepage="https://github.com/intel/${_pkgname}"
-distfiles="${homepage}/archive/v${version}.tar.gz"
+homepage="https://github.com/intel/thermal_daemon"
+distfiles="https://github.com/intel/thermal_daemon/archive/v${version}.tar.gz"
 checksum=fb793a2bfaae2e544ef62801075419587b0c045041c69eeafbf61959cce07fdb
 conf_files='/etc/thermald/*'
 

Re: thermald: enable logger

[marmeladema]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/38308#issuecomment-1200961315

Comment:
@classabbyamp fixed all the things :+1: 

Re: [PR PATCH] [Merged]: thermald: enable logger

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

There's a merged pull request on the void-packages repository

thermald: enable logger
https://github.com/void-linux/void-packages/pull/38308

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->