[PR PATCH] Update python3-mpv & fix tests

[PR PATCH] Update python3-mpv & fix tests

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

There is a new pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages update_python3-mpv
https://github.com/void-linux/void-packages/pull/38364

Update python3-mpv & fix tests
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

python3-xvfbwrapper doesn't cross because [common/environment/build-style/python3-module.sh](https://github.com/void-linux/void-packages/blob/master/common/environment/build-style/python3-module.sh#L2) installs python3 as a makedepend instead of a hostmakedepend and I'm not sure if I should patch the build-style or add python3 to hostmakedepends and ignore that it's also in makedepends
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38364.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_python3-mpv-38364.patch --]
[-- Type: text/x-diff, Size: 2767 bytes --]

From ac1182a451c2078f126a19a8acd8b9d1e50fa7ad Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Thu, 28 Jul 2022 03:04:33 -0400
Subject: [PATCH 1/2] New package: python3-xvfbwrapper-0.2.9

---
 srcpkgs/python3-xvfbwrapper/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-xvfbwrapper/template

diff --git a/srcpkgs/python3-xvfbwrapper/template b/srcpkgs/python3-xvfbwrapper/template
new file mode 100644
index 000000000000..8e25733c3412
--- /dev/null
+++ b/srcpkgs/python3-xvfbwrapper/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-xvfbwrapper'
+pkgname=python3-xvfbwrapper
+version=0.2.9
+revision=1
+wrksrc="${pkgname#python3-}-${version}"
+build_style=python3-module
+# this builds using distutils and will break if upstream doesn't
+#	change the build system before python3-3.12.0
+depends="xorg-server-xvfb"
+short_desc="Python wrapper for controlling Xvfb"
+maintainer="RunningDroid <runningdroid@zoho.com>"
+license="MIT"
+homepage="https://pypi.org/project/xvfbwrapper/"
+distfiles="${PYPI_SITE}/x/xvfbwrapper/xvfbwrapper-${version}.tar.gz"
+checksum=bcf4ae571941b40254faf7a73432dfc119ad21ce688f1fdec533067037ecfc24
+
+pre_install() {
+	vlicense LICENSE
+}

From 3911abdb4aff65dccecd797ddee1be70d5a76ae9 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Thu, 28 Jul 2022 03:04:47 -0400
Subject: [PATCH 2/2] python3-mpv: update to 1.0.1

---
 srcpkgs/python3-mpv/template | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/python3-mpv/template b/srcpkgs/python3-mpv/template
index 3cccc3ee6c11..47efa967f970 100644
--- a/srcpkgs/python3-mpv/template
+++ b/srcpkgs/python3-mpv/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-mpv'
 pkgname=python3-mpv
-version=0.5.2
-revision=2
+version=1.0.1
+revision=1
 wrksrc="python-mpv-${version}"
 build_style=python3-module
+# this test takes too long and has a low chance of failure
+# https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
+make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
 hostmakedepends="python3-setuptools"
 depends="python3 mpv"
+checkdepends="python3-pytest python3-xvfbwrapper mpv-devel"
 short_desc="Python3 interface to the MPV media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="AGPL-3.0-or-later"
+license="GPL-2.0-or-later"
 homepage="https://github.com/jaseg/python-mpv"
 distfiles="https://github.com/jaseg/python-mpv/archive/v${version}.tar.gz"
-checksum=3eacaecef995de7c9bbb80fe30223ab4ca427128384610fa2d87214961085fdb
-
-post_install() {
-	vlicense LICENSE
-}
+checksum=b5dc6dbf2e2b90ec21ffa7e30729eb7d9556296e0617742f24af179377e6bfd9

Re: [PR REVIEW] Update python3-mpv & fix tests

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38364#discussion_r933726859

Comment:
```suggestion
homepage="https://github.com/cgoldberg/xvfbwrapper"
```

Re: [PR REVIEW] Update python3-mpv & fix tests

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38364#discussion_r933726892

Comment:
```suggestion
hostmakedepends="python3-setuptools"
```
https://github.com/cgoldberg/xvfbwrapper/blob/0.2.9/setup.py#L10

Re: [PR REVIEW] Update python3-mpv & fix tests

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38364#discussion_r933727390

Comment:
```suggestion
depends="xorg-server-xvfb"
checkdepends="${depends} python3-pytest"
```
the test suite is unittest-based, but pytest can run it

Re: [PR PATCH] [Updated] Update python3-mpv & fix tests

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages update_python3-mpv
https://github.com/void-linux/void-packages/pull/38364

Update python3-mpv & fix tests
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

python3-xvfbwrapper doesn't cross because [common/environment/build-style/python3-module.sh](https://github.com/void-linux/void-packages/blob/master/common/environment/build-style/python3-module.sh#L2) installs python3 as a makedepend instead of a hostmakedepend and I'm not sure if I should patch the build-style or add python3 to hostmakedepends and ignore that it's also in makedepends
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38364.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_python3-mpv-38364.patch --]
[-- Type: text/x-diff, Size: 2735 bytes --]

From ff01906e1eebd9cffc75e06ffef55b30d5fc1ac7 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Thu, 28 Jul 2022 03:04:33 -0400
Subject: [PATCH 1/2] New package: python3-xvfbwrapper-0.2.9

---
 srcpkgs/python3-xvfbwrapper/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-xvfbwrapper/template

diff --git a/srcpkgs/python3-xvfbwrapper/template b/srcpkgs/python3-xvfbwrapper/template
new file mode 100644
index 000000000000..f5c17669195a
--- /dev/null
+++ b/srcpkgs/python3-xvfbwrapper/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-xvfbwrapper'
+pkgname=python3-xvfbwrapper
+version=0.2.9
+revision=1
+wrksrc="${pkgname#python3-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="xorg-server-xvfb"
+checkdepends="${depends} python3-pytest"
+short_desc="Python wrapper for controlling Xvfb"
+maintainer="RunningDroid <runningdroid@zoho.com>"
+license="MIT"
+homepage="https://github.com/cgoldberg/xvfbwrapper"
+distfiles="${PYPI_SITE}/x/xvfbwrapper/xvfbwrapper-${version}.tar.gz"
+checksum=bcf4ae571941b40254faf7a73432dfc119ad21ce688f1fdec533067037ecfc24
+
+pre_install() {
+	vlicense LICENSE
+}

From 1833307dd9b989e338f1ea2d410f2f9a3acd7163 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Thu, 28 Jul 2022 03:04:47 -0400
Subject: [PATCH 2/2] python3-mpv: update to 1.0.1

---
 srcpkgs/python3-mpv/template | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/python3-mpv/template b/srcpkgs/python3-mpv/template
index 3cccc3ee6c11..47efa967f970 100644
--- a/srcpkgs/python3-mpv/template
+++ b/srcpkgs/python3-mpv/template
@@ -1,18 +1,18 @@
 # Template file for 'python3-mpv'
 pkgname=python3-mpv
-version=0.5.2
-revision=2
+version=1.0.1
+revision=1
 wrksrc="python-mpv-${version}"
 build_style=python3-module
+# this test takes too long and has a low chance of failure
+# https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
+make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
 hostmakedepends="python3-setuptools"
 depends="python3 mpv"
+checkdepends="python3-pytest python3-xvfbwrapper mpv-devel"
 short_desc="Python3 interface to the MPV media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="AGPL-3.0-or-later"
+license="GPL-2.0-or-later"
 homepage="https://github.com/jaseg/python-mpv"
 distfiles="https://github.com/jaseg/python-mpv/archive/v${version}.tar.gz"
-checksum=3eacaecef995de7c9bbb80fe30223ab4ca427128384610fa2d87214961085fdb
-
-post_install() {
-	vlicense LICENSE
-}
+checksum=b5dc6dbf2e2b90ec21ffa7e30729eb7d9556296e0617742f24af179377e6bfd9

Re: Update python3-mpv & fix tests

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/38364#issuecomment-1200344839

Comment:
Thanks for the review @classabbyamp, everything's fixed now

Re: [PR PATCH] [Merged]: Update python3-mpv & fix tests

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

There's a merged pull request on the void-packages repository

Update python3-mpv & fix tests
https://github.com/void-linux/void-packages/pull/38364

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

python3-xvfbwrapper doesn't cross because [common/environment/build-style/python3-module.sh](https://github.com/void-linux/void-packages/blob/master/common/environment/build-style/python3-module.sh#L2) installs python3 as a makedepend instead of a hostmakedepend and I'm not sure if I should patch the build-style or add python3 to hostmakedepends and ignore that it's also in makedepends
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->