[PR PATCH] nilfs-utils: update to 2.2.9.

[PR PATCH] nilfs-utils: update to 2.2.9.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

There is a new pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages nilfs-utils
https://github.com/void-linux/void-packages/pull/38517

nilfs-utils: update to 2.2.9.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38517.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nilfs-utils-38517.patch --]
[-- Type: text/x-diff, Size: 2136 bytes --]

From 6638b10d06c96d4fcdd34ccb6a7e6996240be847 Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Sun, 7 Aug 2022 21:46:48 +1000
Subject: [PATCH] nilfs-utils: update to 2.2.9.

---
 srcpkgs/nilfs-utils/template | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/nilfs-utils/template b/srcpkgs/nilfs-utils/template
index c58b411bcdab..19f0f6aca870 100644
--- a/srcpkgs/nilfs-utils/template
+++ b/srcpkgs/nilfs-utils/template
@@ -1,36 +1,38 @@
 # Template file for 'nilfs-utils'
 pkgname=nilfs-utils
-version=2.2.8
+version=2.2.9
 revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-libmount"
+configure_args="--without-selinux"
 make_install_args="sbindir=/usr/bin"
 hostmakedepends="automake libtool"
-makedepends="libuuid-devel libmount-devel"
+makedepends="libblkid-devel libmount-devel libuuid-devel"
 conf_files="/etc/nilfs_cleanerd.conf"
 short_desc="Log-structured file system for Linux - userspace utils"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-only, LGPL-2.1-only"
-homepage="http://nilfs.sourceforge.net/"
-distfiles="http://nilfs.sourceforge.net/download/$pkgname-$version.tar.bz2"
-checksum=5a29f8f59db03edf8dd1e68dfd80ff4713e0aa184cfa83a6326ac8af93d9bda6
+license="GPL-2.0-or-later, LGPL-2.1-or-later"
+homepage="https://nilfs.sourceforge.io/"
+distfiles="https://nilfs.sourceforge.io/download/${pkgname}-${version}.tar.bz2"
+checksum=5df63998c2084182c8c608a29b47b1771b825b4b5fa7916c12cca2fcb7577a97
 
 pre_configure() {
 	autoreconf -fi
 }
+
 post_install() {
 	mv ${DESTDIR}/sbin/* ${DESTDIR}/usr/bin/
 }
 
 libnilfs_package() {
-	short_desc="NILFS userspace runtime libraries"
+	short_desc="Log-structured file system for Linux - userspace runtime libraries"
 	pkg_install() {
 		vmove "usr/lib/*.so.*"
 	}
 }
+
 nilfs-utils-devel_package() {
 	depends="${makedepends} libnilfs>=${version}_${revision}"
-	short_desc="NILFS userspace development files"
+	short_desc="Log-structured file system for Linux - userspace development files"
 	pkg_install() {
 		vmove usr/include
 		vmove "usr/lib/*.a"

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939681692

Comment:
Remove this block

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939681129

Comment:
Not important but could be: short_desc=${short_desc/utils/development files}

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939681073

Comment:
Not important but could be: `short_desc=${short_desc/utils/libraries}`

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939681659

Comment:
Remove this line

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939680979

Comment:
License is GPL-2.0-only not later.

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

New review comment by atweiden on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939741587

Comment:
Ah, OK. Grepping `COPYING` from source:

```
GNU GENERAL PUBLIC LICENSE

[…]

  9. The Free Software Foundation may publish revised and/or new versions
of the General Public License from time to time.  Such new versions will
be similar in spirit to the present version, but may differ in detail to
address new problems or concerns.

Each version is given a distinguishing version number.  If the Program
specifies a version number of this License which applies to it and "any
later version", you have the option of following the terms and conditions
either of that version or of any later version published by the Free
Software Foundation.  If the Program does not specify a version number of
this License, you may choose any version ever published by the Free Software
Foundation.
```

But this may not be the author’s intention, e.g. the source code states `Licensed under GPLv2`, `Licensed under LGPLv2` in many places.

I’ll change the license.

Re: [PR PATCH] [Updated] nilfs-utils: update to 2.2.9.

[atweiden]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is an updated pull request by atweiden against master on the void-packages repository

https://github.com/atweiden/void-packages nilfs-utils
https://github.com/void-linux/void-packages/pull/38517

nilfs-utils: update to 2.2.9.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38517.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nilfs-utils-38517.patch --]
[-- Type: text/x-diff, Size: 2022 bytes --]

From 81e5aee3df211149abb0b8fd975b0e5183e3a5be Mon Sep 17 00:00:00 2001
From: Andy Weidenbaum <atweiden@ioiojo.com>
Date: Sun, 7 Aug 2022 21:46:48 +1000
Subject: [PATCH] nilfs-utils: update to 2.2.9.

---
 srcpkgs/nilfs-utils/template | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/nilfs-utils/template b/srcpkgs/nilfs-utils/template
index c58b411bcdab..89175e29a449 100644
--- a/srcpkgs/nilfs-utils/template
+++ b/srcpkgs/nilfs-utils/template
@@ -1,36 +1,33 @@
 # Template file for 'nilfs-utils'
 pkgname=nilfs-utils
-version=2.2.8
+version=2.2.9
 revision=1
 build_style=gnu-configure
-configure_args="--sbindir=/usr/bin --enable-libmount"
+configure_args="--without-selinux"
 make_install_args="sbindir=/usr/bin"
-hostmakedepends="automake libtool"
-makedepends="libuuid-devel libmount-devel"
+makedepends="libblkid-devel libmount-devel libuuid-devel"
 conf_files="/etc/nilfs_cleanerd.conf"
 short_desc="Log-structured file system for Linux - userspace utils"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-only, LGPL-2.1-only"
-homepage="http://nilfs.sourceforge.net/"
-distfiles="http://nilfs.sourceforge.net/download/$pkgname-$version.tar.bz2"
-checksum=5a29f8f59db03edf8dd1e68dfd80ff4713e0aa184cfa83a6326ac8af93d9bda6
+homepage="https://nilfs.sourceforge.io/"
+distfiles="https://nilfs.sourceforge.io/download/${pkgname}-${version}.tar.bz2"
+checksum=5df63998c2084182c8c608a29b47b1771b825b4b5fa7916c12cca2fcb7577a97
 
-pre_configure() {
-	autoreconf -fi
-}
 post_install() {
 	mv ${DESTDIR}/sbin/* ${DESTDIR}/usr/bin/
 }
 
 libnilfs_package() {
-	short_desc="NILFS userspace runtime libraries"
+	short_desc="${short_desc/utils/libraries}"
 	pkg_install() {
 		vmove "usr/lib/*.so.*"
 	}
 }
+
 nilfs-utils-devel_package() {
 	depends="${makedepends} libnilfs>=${version}_${revision}"
-	short_desc="NILFS userspace development files"
+	short_desc="${short_desc/utils/development files}"
 	pkg_install() {
 		vmove usr/include
 		vmove "usr/lib/*.a"

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939744499

Comment:
The COPYING file must be copied verbatim from GNU, it's the requirement from GNU.
Part 2 of Clause 9 says 
```
If the Program
specifies a version number of this License which applies to it and "any
later version", you have the option of following the terms and conditions
either of that version or of any later version published by the Free
Software Foundation.
```
So, when source code doesn't mention "later version", it means that only version.

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939744499

Comment:
The COPYING file must be copied verbatim from GNU, it's the requirement from GNU.
```

		    GNU GENERAL PUBLIC LICENSE
		       Version 2, June 1991

 Copyright (C) 1989, 1991 Free Software Foundation, Inc.
     51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 Everyone is permitted to copy and distribute verbatim copies
 of this license document, but changing it is not allowed.
```

Part 2 of Clause 9 says 
```
If the Program
specifies a version number of this License which applies to it and "any
later version", you have the option of following the terms and conditions
either of that version or of any later version published by the Free
Software Foundation.
```
So, when source code doesn't mention "later version", it means that only version.

Re: [PR REVIEW] nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/38517#discussion_r939744974

Comment:
IOW, the author is doing correctly (not violate GNU license), and licenses their software correctly under `GPL-2.0-only`

Re: [PR PATCH] [Merged]: nilfs-utils: update to 2.2.9.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

There's a merged pull request on the void-packages repository

nilfs-utils: update to 2.2.9.
https://github.com/void-linux/void-packages/pull/38517

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64