Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: [RFC] various: remove -s/-w from go_ldflags
Date: Wed, 10 Aug 2022 21:01:40 +0200	[thread overview]
Message-ID: <20220810190140.sMssXHyxfagNmE5Iq-jUuN-gv9I3P0br9J0nbKtBEJw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38538@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

There's a merged pull request on the void-packages repository

[RFC] various: remove -s/-w from go_ldflags
https://github.com/void-linux/void-packages/pull/38538

Description:
- aws-vault: remove -w -s from go_ldflags
    - added in #21634
- circleci-cli: remove -w -s from go_ldflags
    - added in #25101
- coredns: remove -w -s from go_ldflags
    - added in #23578
- gotify-cli: remove -w -s from go_ldflags
    - added in #34653
- gotify-server: remove -w -s from go_ldflags
    - added in #34653
- v2ray: remove -w -s from go_ldflags
    - added in #31653
    - not revbumping because of build issues with `quic-go` (see below)
- common/build-style/go.sh: error if -s/-w in go_ldflags
    - this does not fit in an xlint because of multiline-string handling woes

These [go linker flags](https://pkg.go.dev/cmd/link) are:

        -s   Omit the symbol table and debug information.
        -w   Omit the DWARF symbol table.

both are not necessary because xbps-src should strip binaries itself

it's not necessary to check for `-sw` or `-ws` because go doesn't parse combined flags for this

#### Testing the changes
- I tested the changes in this PR: **briefly**
  - all still build except for `v2ray`

[ci skip]

      parent reply	other threads:[~2022-08-10 19:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:44 [PR PATCH] [RFC] various: remove -w -s " classabbyamp
2022-08-09  0:22 ` classabbyamp
2022-08-09  0:26 ` classabbyamp
2022-08-09  8:48 ` ketlrznt
2022-08-09  8:48 ` ketlrznt
2022-08-09  8:49 ` ketlrznt
2022-08-09 10:22 ` ketlrznt
2022-08-09 10:23 ` ketlrznt
2022-08-09 13:54 ` ketlrznt
2022-08-09 13:54 ` classabbyamp
2022-08-09 13:54 ` classabbyamp
2022-08-10  7:21 ` [PR PATCH] [Updated] " classabbyamp
2022-08-10  7:34 ` classabbyamp
2022-08-10 17:01 ` [RFC] various: remove -s/-w " the-maldridge
2022-08-10 17:24 ` classabbyamp
2022-08-10 17:25 ` the-maldridge
2022-08-10 19:01 ` classabbyamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220810190140.sMssXHyxfagNmE5Iq-jUuN-gv9I3P0br9J0nbKtBEJw@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).