From: JamiKettunen <JamiKettunen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
Date: Sat, 13 Aug 2022 14:17:50 +0200 [thread overview]
Message-ID: <20220813121750.I3KgezEg0ek9sVbKfwWq00y6PDQ6-KNcA9KWDC9RS2U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38648@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945133209
Comment:
Why? `virtual?java-runtime` will accept any package that provides `java-runtime` virtual dependency, this includes both `openjdk17-jre` and the [current default of `openjdk8-jre`](https://github.com/void-linux/void-packages/blob/4475c34/etc/defaults.virtual#L25).
If you install `openjdk17-jre` you should be able to remove `openjdk8-jre`, or why not keep both. You could also install `openjdk17-jre` before `PolyMC` and then `openjdk8-jre` won't be pulled in.
next prev parent reply other threads:[~2022-08-13 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 12:11 [PR PATCH] " TrueTechie
2022-08-13 12:17 ` JamiKettunen [this message]
2022-08-13 12:19 ` [PR REVIEW] " JamiKettunen
2022-08-13 12:27 ` JamiKettunen
2022-08-13 13:51 ` paper42
2022-08-13 14:31 ` [PR REVIEW] " JamiKettunen
2022-08-13 15:37 ` TrueTechie
2022-08-13 15:39 ` TrueTechie
2022-08-13 16:48 ` classabbyamp
2022-08-13 16:55 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813121750.I3KgezEg0ek9sVbKfwWq00y6PDQ6-KNcA9KWDC9RS2U@z \
--to=jamikettunen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).