From: TrueTechie <TrueTechie@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] PolyMC: Update Java runtime dependencies
Date: Sat, 13 Aug 2022 17:37:22 +0200 [thread overview]
Message-ID: <20220813153722.gJdJ8MObkhXyC9ELphvr6bVrS67yTeu_61v3uYUmDZE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38648@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
New review comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/38648#discussion_r945161017
Comment:
> Ah nvm attempting to install `PolyMC` pulls in `openjdk11-jre` by default for me on `x86_64-musl`, wonder what exactly makes that the case... Either way this is a bit of a nuanced issue, perhaps @classabbyamp can comment better.
>
> I previously suggested [mentioning the existance of PolyMC's README.voidlinux](https://github.com/void-linux/void-packages/pull/34979#issuecomment-1079054056) but it seems that was completely lost in the comments, but the file should already exist as [`/usr/share/doc/PolyMC/README.voidlinux`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/PolyMC/files/README.voidlinux) on your system.
Fair, but README or not, this still means that the package wouldn't have accurate dependencies which puts into question the point of deps in the first place. Not to mention the extra work for new users who'll have to switch one version out for another.
next prev parent reply other threads:[~2022-08-13 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 12:11 [PR PATCH] " TrueTechie
2022-08-13 12:17 ` [PR REVIEW] " JamiKettunen
2022-08-13 12:19 ` JamiKettunen
2022-08-13 12:27 ` JamiKettunen
2022-08-13 13:51 ` paper42
2022-08-13 14:31 ` [PR REVIEW] " JamiKettunen
2022-08-13 15:37 ` TrueTechie [this message]
2022-08-13 15:39 ` TrueTechie
2022-08-13 16:48 ` classabbyamp
2022-08-13 16:55 ` [PR PATCH] [Closed]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813153722.gJdJ8MObkhXyC9ELphvr6bVrS67yTeu_61v3uYUmDZE@z \
--to=truetechie@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).