* [PR PATCH] use loginctl instead of systemctl
@ 2022-08-18 2:16 luan-adao
2022-08-18 2:20 ` classabbyamp
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: luan-adao @ 2022-08-18 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
There is a new pull request by luan-adao against master on the void-packages repository
https://github.com/luan-adao/void-packages wlogout-loginctl-patch
https://github.com/void-linux/void-packages/pull/38750
use loginctl instead of systemctl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38750.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wlogout-loginctl-patch-38750.patch --]
[-- Type: text/x-diff, Size: 1297 bytes --]
From 47b460e5a5633064fb4ef31ca4e8b784c0be6d0b Mon Sep 17 00:00:00 2001
From: luan-adao <luanadao98@gmail.com>
Date: Wed, 17 Aug 2022 22:52:51 -0300
Subject: [PATCH] use loginctl instead of systemctl
---
srcpkgs/wlogout/patches/layout.patch | 34 ++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 srcpkgs/wlogout/patches/layout.patch
diff --git a/srcpkgs/wlogout/patches/layout.patch b/srcpkgs/wlogout/patches/layout.patch
new file mode 100644
index 000000000000..c18f58dc4774
--- /dev/null
+++ b/srcpkgs/wlogout/patches/layout.patch
@@ -0,0 +1,34 @@
+--- /layout
++++ /layout
+@@ -6,7 +6,7 @@
+ }
+ {
+ "label" : "hibernate",
+- "action" : "systemctl hibernate",
++ "action" : "loginctl hibernate",
+ "text" : "Hibernate",
+ "keybind" : "h"
+ }
+@@ -18,19 +18,19 @@
+ }
+ {
+ "label" : "shutdown",
+- "action" : "systemctl poweroff",
++ "action" : "loginctl poweroff",
+ "text" : "Shutdown",
+ "keybind" : "s"
+ }
+ {
+ "label" : "suspend",
+- "action" : "systemctl suspend",
++ "action" : "loginctl suspend",
+ "text" : "Suspend",
+ "keybind" : "u"
+ }
+ {
+ "label" : "reboot",
+- "action" : "systemctl reboot",
++ "action" : "loginctl reboot",
+ "text" : "Reboot",
+ "keybind" : "r"
+ }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: use loginctl instead of systemctl
2022-08-18 2:16 [PR PATCH] use loginctl instead of systemctl luan-adao
@ 2022-08-18 2:20 ` classabbyamp
2022-08-18 2:23 ` [PR REVIEW] " classabbyamp
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-08-18 2:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38750#issuecomment-1218916409
Comment:
please [fix the commit message](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes) and increment the revision
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] use loginctl instead of systemctl
2022-08-18 2:16 [PR PATCH] use loginctl instead of systemctl luan-adao
2022-08-18 2:20 ` classabbyamp
@ 2022-08-18 2:23 ` classabbyamp
2022-08-18 2:35 ` [PR PATCH] [Updated] " luan-adao
2022-08-18 2:43 ` [PR PATCH] [Merged]: " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-08-18 2:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38750#discussion_r948592157
Comment:
this patch will not apply properly as-is
```suggestion
--- a/layout
+++ b/layout
```
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] use loginctl instead of systemctl
2022-08-18 2:16 [PR PATCH] use loginctl instead of systemctl luan-adao
2022-08-18 2:20 ` classabbyamp
2022-08-18 2:23 ` [PR REVIEW] " classabbyamp
@ 2022-08-18 2:35 ` luan-adao
2022-08-18 2:43 ` [PR PATCH] [Merged]: " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: luan-adao @ 2022-08-18 2:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
There is an updated pull request by luan-adao against master on the void-packages repository
https://github.com/luan-adao/void-packages wlogout-loginctl-patch
https://github.com/void-linux/void-packages/pull/38750
use loginctl instead of systemctl
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38750.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wlogout-loginctl-patch-38750.patch --]
[-- Type: text/x-diff, Size: 1752 bytes --]
From dda33a4233af7e09d5a3f82875440f851e45bccc Mon Sep 17 00:00:00 2001
From: luan-adao <luanadao98@gmail.com>
Date: Wed, 17 Aug 2022 22:52:51 -0300
Subject: [PATCH] wlogout: use loginctl instead of systemctl
---
srcpkgs/wlogout/patches/layout.patch | 34 ++++++++++++++++++++++++++++
srcpkgs/wlogout/template | 2 +-
2 files changed, 35 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/wlogout/patches/layout.patch
diff --git a/srcpkgs/wlogout/patches/layout.patch b/srcpkgs/wlogout/patches/layout.patch
new file mode 100644
index 000000000000..aba702cbce8c
--- /dev/null
+++ b/srcpkgs/wlogout/patches/layout.patch
@@ -0,0 +1,34 @@
+--- a/layout
++++ b/layout
+@@ -6,7 +6,7 @@
+ }
+ {
+ "label" : "hibernate",
+- "action" : "systemctl hibernate",
++ "action" : "loginctl hibernate",
+ "text" : "Hibernate",
+ "keybind" : "h"
+ }
+@@ -18,19 +18,19 @@
+ }
+ {
+ "label" : "shutdown",
+- "action" : "systemctl poweroff",
++ "action" : "loginctl poweroff",
+ "text" : "Shutdown",
+ "keybind" : "s"
+ }
+ {
+ "label" : "suspend",
+- "action" : "systemctl suspend",
++ "action" : "loginctl suspend",
+ "text" : "Suspend",
+ "keybind" : "u"
+ }
+ {
+ "label" : "reboot",
+- "action" : "systemctl reboot",
++ "action" : "loginctl reboot",
+ "text" : "Reboot",
+ "keybind" : "r"
+ }
diff --git a/srcpkgs/wlogout/template b/srcpkgs/wlogout/template
index 60a6953642c4..33cbc05064a6 100644
--- a/srcpkgs/wlogout/template
+++ b/srcpkgs/wlogout/template
@@ -1,7 +1,7 @@
# Template file for 'wlogout'
pkgname=wlogout
version=1.1.1
-revision=1
+revision=2
build_style=meson
conf_files="/etc/wlogout/layout /etc/wlogout/style.css"
hostmakedepends="pkg-config scdoc"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: use loginctl instead of systemctl
2022-08-18 2:16 [PR PATCH] use loginctl instead of systemctl luan-adao
` (2 preceding siblings ...)
2022-08-18 2:35 ` [PR PATCH] [Updated] " luan-adao
@ 2022-08-18 2:43 ` classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-08-18 2:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
There's a merged pull request on the void-packages repository
use loginctl instead of systemctl
https://github.com/void-linux/void-packages/pull/38750
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-18 2:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18 2:16 [PR PATCH] use loginctl instead of systemctl luan-adao
2022-08-18 2:20 ` classabbyamp
2022-08-18 2:23 ` [PR REVIEW] " classabbyamp
2022-08-18 2:35 ` [PR PATCH] [Updated] " luan-adao
2022-08-18 2:43 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).