* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
@ 2022-08-19 0:40 ` classabbyamp
2022-08-19 0:40 ` classabbyamp
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-19 0:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949702967
Comment:
```suggestion
homepage="http://www.w1hkj.com/"
changelog="https://sourceforge.net/p/fldigi/flrig/ci/master/tree/ChangeLog?format=raw"
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
2022-08-19 0:40 ` [PR REVIEW] " classabbyamp
@ 2022-08-19 0:40 ` classabbyamp
2022-08-19 1:05 ` Goorzhel
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-19 0:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949703290
Comment:
license is unclear, there's a COPYING file that is GPL 2, but src/main.cxx says GPL 3+. Other distros use a [variety of values](https://repology.org/project/flrig/information). Could you investigate this?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
2022-08-19 0:40 ` [PR REVIEW] " classabbyamp
2022-08-19 0:40 ` classabbyamp
@ 2022-08-19 1:05 ` Goorzhel
2022-08-19 2:00 ` classabbyamp
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2022-08-19 1:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
New review comment by Goorzhel on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949713370
Comment:
The COPYING is v3:
```
/tmp/fldigi-4.1.23 ❯ head -2 COPYING
GNU GENERAL PUBLIC LICENSE
Version 3, 29 June 2007
```
But it ships mbedtls in `src/mbedtls` under GPL v2. Thoughts?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (2 preceding siblings ...)
2022-08-19 1:05 ` Goorzhel
@ 2022-08-19 2:00 ` classabbyamp
2022-08-19 2:17 ` Goorzhel
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-19 2:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949733783
Comment:
weird, that's not what [this shows](https://sourceforge.net/p/fldigi/flrig/ci/master/tree/COPYING)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (3 preceding siblings ...)
2022-08-19 2:00 ` classabbyamp
@ 2022-08-19 2:17 ` Goorzhel
2022-08-19 2:29 ` Goorzhel
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2022-08-19 2:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by Goorzhel on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949740913
Comment:
I've emailed the author.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (4 preceding siblings ...)
2022-08-19 2:17 ` Goorzhel
@ 2022-08-19 2:29 ` Goorzhel
2022-08-19 2:30 ` [PR PATCH] [Updated] " Goorzhel
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2022-08-19 2:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
New review comment by Goorzhel on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949745782
Comment:
He wrote:
> GPL-v3 or later is the intended license for all of the NBEMS suite applications including
> * fldigi / flarq
> * flrig
> * flcluster
> * flmsg
> * flamp
> * fllog
> * flwrap
> * flwkey
> * flnet
> * flaa
> * flxmlrpc
> * flnano
> * linsim
> * comptty
> * comptext
> * pistats
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (5 preceding siblings ...)
2022-08-19 2:29 ` Goorzhel
@ 2022-08-19 2:30 ` Goorzhel
2022-08-19 2:31 ` [PR REVIEW] " classabbyamp
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2022-08-19 2:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
There is an updated pull request by Goorzhel against master on the void-packages repository
https://github.com/Goorzhel/void-packages flrig
https://github.com/void-linux/void-packages/pull/38771
New package: flrig-1.4.7
- I tested the changes in this PR: **briefly**
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/38771.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flrig-38771.patch --]
[-- Type: text/x-diff, Size: 1223 bytes --]
From 13f53fd8952333df6e796abea8ddccc5215460f1 Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Thu, 18 Aug 2022 17:27:24 -0700
Subject: [PATCH] New package: flrig-1.4.7
---
srcpkgs/flrig/template | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 srcpkgs/flrig/template
diff --git a/srcpkgs/flrig/template b/srcpkgs/flrig/template
new file mode 100644
index 000000000000..6710990fe812
--- /dev/null
+++ b/srcpkgs/flrig/template
@@ -0,0 +1,22 @@
+# Template file for 'flrig'
+pkgname=flrig
+version=1.4.7
+revision=1
+build_style=gnu-configure
+makedepends="fltk-devel"
+depends="fltk"
+short_desc="Rig control program, compatible with fldigi"
+maintainer="Antonio Gurgel <antonio@goorzhel.com>"
+license="GPL-3.0-or-later"
+homepage="http://www.w1hkj.com/"
+changelog="https://sourceforge.net/p/fldigi/flrig/ci/master/tree/ChangeLog?format=raw"
+distfiles="http://www.w1hkj.com/files/flrig/${pkgname}-${version}.tar.gz"
+checksum=473c9e25fdd3d6f29397253f10c5c563e39b92a2aaef0272041f1978a30e3b53
+
+case "$XBPS_TARGET_MACHINE" in
+ *-musl) makedepends+=" musl-legacy-compat" ;;
+esac
+
+post_install() {
+ vinstall data/flrig.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (6 preceding siblings ...)
2022-08-19 2:30 ` [PR PATCH] [Updated] " Goorzhel
@ 2022-08-19 2:31 ` classabbyamp
2022-08-20 1:41 ` [PR PATCH] [Merged]: " classabbyamp
2022-08-20 1:41 ` classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-19 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#discussion_r949746559
Comment:
ok, sounds good
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (7 preceding siblings ...)
2022-08-19 2:31 ` [PR REVIEW] " classabbyamp
@ 2022-08-20 1:41 ` classabbyamp
2022-08-20 1:41 ` classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-20 1:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
There's a merged pull request on the void-packages repository
New package: flrig-1.4.7
https://github.com/void-linux/void-packages/pull/38771
Description:
- I tested the changes in this PR: **briefly**
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: New package: flrig-1.4.7
2022-08-19 0:29 [PR PATCH] New package: flrig-1.4.7 Goorzhel
` (8 preceding siblings ...)
2022-08-20 1:41 ` [PR PATCH] [Merged]: " classabbyamp
@ 2022-08-20 1:41 ` classabbyamp
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-08-20 1:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/38771#issuecomment-1221202322
Comment:
the other members of the fl suite might be nice to have too
^ permalink raw reply [flat|nested] 11+ messages in thread