Github messages for voidlinux
 help / color / mirror / Atom feed
From: lemmi <lemmi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: darktable>=3.0.x: build fails for aarch64* with openmp
Date: Sat, 27 Aug 2022 08:11:50 +0200	[thread overview]
Message-ID: <20220827061150.uzn8SImws-4b0fZvpB0DT8JGopNtLM0pyBCMpRJxZXU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21105@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/issues/21105#issuecomment-1229132479

Comment:
So this made me have another look, whether I couldn't find a solution upstream. Seems like the flag is also necessary on macos, but they also add [`-DBUILD_SSE2_CODEPATHS=OFF`](https://github.com/macports/macports-ports/blob/2f8fe26bae7c95d4c9bb1c0b1eae2f8c8e6161f7/graphics/darktable-devel/Portfile#L139).
That made me try to replace `-DUSE_OPENMP=OFF` with that:
```diff
diff --git a/srcpkgs/darktable/template b/srcpkgs/darktable/template
index 9d0ba9ba70..58fd4fd818 100644
--- a/srcpkgs/darktable/template
+++ b/srcpkgs/darktable/template
@@ -40,6 +40,6 @@ fi

 case $XBPS_TARGET_MACHINE in
        aarch64*)
-               configure_args+=" -DUSE_OPENMP=OFF"
+               configure_args+=" -DBUILD_SSE2_CODEPATHS=OFF"
                ;;
 esac
```
Maybe someone can try whether this produces a working binary?

Regardless, without `-DUSE_OPENMP=OFF` I still get
```
/builddir/darktable-4.0.0/src/common/iop_profile.h:286:20: warning: GCC does not currently support mixed size types for 'simd' functions
  286 | static inline void dt_ioppr_rgb_matrix_to_xyz(const dt_aligned_pixel_t rgb, dt_aligned_pixel_t xyz,
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
But these issues are now warnings (at least with `darktable-4.0`), not errors anymore and `darktable` compiles.

  parent reply	other threads:[~2022-08-27  6:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18  6:37 [ISSUE] darktable-3.0.x: " lemmi
2021-01-06 16:37 ` Sturmflut
2021-01-07  4:09 ` lemmi
2022-04-16  2:02 ` github-actions
2022-04-30  2:13 ` [ISSUE] [CLOSED] " github-actions
2022-08-26 22:59 ` Sturmflut
2022-08-27  5:43 ` lemmi
2022-08-27  5:43 ` lemmi
2022-08-27  6:11 ` lemmi [this message]
2022-08-27 11:57 ` darktable>=3.0.x: " Sturmflut
2022-08-27 13:24 ` lemmi
2022-08-27 14:03 ` Sturmflut
2022-08-31 21:29 ` lemmi
2022-11-30  2:03 ` github-actions
2022-12-15  2:01 ` [ISSUE] [CLOSED] " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220827061150.uzn8SImws-4b0fZvpB0DT8JGopNtLM0pyBCMpRJxZXU@z \
    --to=lemmi@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).