From: Sturmflut <Sturmflut@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: darktable>=3.0.x: build fails for aarch64* with openmp
Date: Sat, 27 Aug 2022 16:03:05 +0200 [thread overview]
Message-ID: <20220827140305.VASSm_lYnlqnBVYIomBET9OZxvSEaT0LuEgyHxZ56Qk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21105@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
New comment by Sturmflut on void-packages repository
https://github.com/void-linux/void-packages/issues/21105#issuecomment-1229198160
Comment:
I just did. You need the following patch to get Clang 11 working:
```
--- a/src/is_supported_platform.h
+++ b/src/is_supported_platform.h
@@ -30,7 +30,7 @@
#define DT_SUPPORTED_X86 0
#endif
-#if defined(__aarch64__) && (defined(__ARM_64BIT_STATE) && defined(__ARM_ARCH) && defined(__ARM_ARCH_8A) || defined(__APPLE__) || defined(__MINGW64__))
+#if defined(__aarch64__) && (defined(__ARM_64BIT_STATE) && defined(__ARM_ARCH) && (defined(__ARM_ARCH_8A) || __ARM_ARCH_PROFILE == 'A') || defined(__APPLE__) || defined(__MINGW64__))
#define DT_SUPPORTED_ARMv8A 1
#else
#define DT_SUPPORTED_ARMv8A 0
```
It compiles fine without any modifications to the OpenMP SIMD statements and the generated binary seems to work perfectly, utilizing all four cores on the Raspberry Pi 3 Model B.
I've sent a Pull Request with this patch to the darktable devs, see darktable-org/darktable#12388.
next prev parent reply other threads:[~2022-08-27 14:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 6:37 [ISSUE] darktable-3.0.x: " lemmi
2021-01-06 16:37 ` Sturmflut
2021-01-07 4:09 ` lemmi
2022-04-16 2:02 ` github-actions
2022-04-30 2:13 ` [ISSUE] [CLOSED] " github-actions
2022-08-26 22:59 ` Sturmflut
2022-08-27 5:43 ` lemmi
2022-08-27 5:43 ` lemmi
2022-08-27 6:11 ` darktable>=3.0.x: " lemmi
2022-08-27 11:57 ` Sturmflut
2022-08-27 13:24 ` lemmi
2022-08-27 14:03 ` Sturmflut [this message]
2022-08-31 21:29 ` lemmi
2022-11-30 2:03 ` github-actions
2022-12-15 2:01 ` [ISSUE] [CLOSED] " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827140305.VASSm_lYnlqnBVYIomBET9OZxvSEaT0LuEgyHxZ56Qk@z \
--to=sturmflut@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).