* Re: fish-shell: update to 3.5.0.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
@ 2022-06-24 19:41 ` paper42
2022-08-08 19:36 ` icp1994
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-06-24 19:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1165882790
Comment:
history_races test fails on x86_64-musl:
```
61/236 Test #64: history_races ............................***Failed 1.27 sec
Proceeding with target execution
Testing low-level functionality
Testing history race conditions
Error: Expected 1025 items, but instead got 1005 items
Error: Line '0 0' still left in the array
Error: Line '0 1' still left in the array
Error: Line '0 2' still left in the array
Error: Line '0 3' still left in the array
Error: Line '0 4' still left in the array
Error: Line '0 5' still left in the array
Error: Line '0 6' still left in the array
Error: Line '0 7' still left in the array
Error: Line '0 8' still left in the array
Error: Line '0 9' still left in the array
Error: Line '0 10' still left in the array
Error: Line '0 11' still left in the array
Error: Line '0 12' still left in the array
Error: Line '0 13' still left in the array
Error: Line '0 14' still left in the array
Error: Line '0 15' still left in the array
Error: Line '0 16' still left in the array
Error: Line '0 17' still left in the array
Error: Line '0 18' still left in the array
Error: Line '1 0' still left in the array
Encountered 21 errors in low-level tests
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: fish-shell: update to 3.5.0.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
2022-06-24 19:41 ` paper42
@ 2022-08-08 19:36 ` icp1994
2022-08-08 19:46 ` icp1994
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: icp1994 @ 2022-08-08 19:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1208529903
Comment:
Could try again with `v3.5.1`. I don't have a `-musl` system for the tests but they pass in my `x86_64`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: fish-shell: update to 3.5.0.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
2022-06-24 19:41 ` paper42
2022-08-08 19:36 ` icp1994
@ 2022-08-08 19:46 ` icp1994
2022-08-08 20:01 ` mhmdanas
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: icp1994 @ 2022-08-08 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1208529903
Comment:
Could try again with `v3.5.1`. I don't have a `-musl` system for the tests but they pass in my `x86_64`.
Edit: packaged in a separate masterdir for `x86_64-musl` and the tests passed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: fish-shell: update to 3.5.0.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
` (2 preceding siblings ...)
2022-08-08 19:46 ` icp1994
@ 2022-08-08 20:01 ` mhmdanas
2022-08-09 23:14 ` [PR PATCH] [Updated] " mhmdanas
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2022-08-08 20:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1208551917
Comment:
@icp1994 sure, I'll update this PR tomorrow.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] fish-shell: update to 3.5.0.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
` (3 preceding siblings ...)
2022-08-08 20:01 ` mhmdanas
@ 2022-08-09 23:14 ` mhmdanas
2022-08-09 23:20 ` fish-shell: update to 3.5.1 mhmdanas
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2022-08-09 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
There is an updated pull request by mhmdanas against master on the void-packages repository
https://github.com/mhmdanas/void-packages fish-3.5.0
https://github.com/void-linux/void-packages/pull/37656
fish-shell: update to 3.5.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/37656.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-3.5.0-37656.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]
From b70f3cb7fa36de6effb84111cfb4c071a2099477 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 23 Jun 2022 16:58:40 +0300
Subject: [PATCH] fish-shell: update to 3.5.1.
---
srcpkgs/fish-shell/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 0fc86db7e7b0..5362009ae71b 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,12 +1,11 @@
# Template file for 'fish-shell'
pkgname=fish-shell
-version=3.4.1
+version=3.5.1
revision=1
wrksrc="fish-${version}"
build_style=cmake
hostmakedepends="gettext"
makedepends="ncurses-devel pcre2-devel"
-depends="groff"
checkdepends="python3-pexpect procps-ng"
short_desc="User friendly shell intended mostly for interactive use"
maintainer="Nathan Owens <ndowens04@gmail.com>"
@@ -14,7 +13,7 @@ license="GPL-2.0-only"
homepage="https://fishshell.com/"
changelog="https://github.com/fish-shell/fish-shell/raw/master/CHANGELOG.rst"
distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
-checksum=b6f23b3843b04db6b0a90fea1f6f0d0e40cc027b4a732098200863f2864a94ea
+checksum=a6d45b3dc5a45dd31772e7f8dfdfecabc063986e8f67d60bd7ca60cc81db6928
register_shell="/bin/fish /usr/bin/fish"
# tests don't work as root
make_check=ci-skip
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: fish-shell: update to 3.5.1.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
` (4 preceding siblings ...)
2022-08-09 23:14 ` [PR PATCH] [Updated] " mhmdanas
@ 2022-08-09 23:20 ` mhmdanas
2022-08-09 23:23 ` mhmdanas
2022-09-02 16:23 ` [PR PATCH] [Merged]: " paper42
7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2022-08-09 23:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1209986935
Comment:
Updated to 3.5.1. With 3.5.1, the tests failed for me once (didn't take note of which test it was that failed, but I _think_ it was `history_races`), but then I ran them again and they succeeded. The tests were done on x86_64 glibc. I think this is most likely just a flaky test that we can safely ignore.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: fish-shell: update to 3.5.1.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
` (5 preceding siblings ...)
2022-08-09 23:20 ` fish-shell: update to 3.5.1 mhmdanas
@ 2022-08-09 23:23 ` mhmdanas
2022-09-02 16:23 ` [PR PATCH] [Merged]: " paper42
7 siblings, 0 replies; 9+ messages in thread
From: mhmdanas @ 2022-08-09 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/37656#issuecomment-1209986935
Comment:
Updated to 3.5.1. With 3.5.1, the tests failed for me once (didn't take note of which test it was that failed, but I _think_ it was `history_races`), but then I ran them again and they succeeded. The tests were done on x86_64 glibc. I think this is most likely just a flaky test that we can safely ignore.
Also, note that I removed the `groff` dependency, which I think is not needed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: fish-shell: update to 3.5.1.
2022-06-23 13:56 [PR PATCH] fish-shell: update to 3.5.0 mhmdanas
` (6 preceding siblings ...)
2022-08-09 23:23 ` mhmdanas
@ 2022-09-02 16:23 ` paper42
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-09-02 16:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
There's a merged pull request on the void-packages repository
fish-shell: update to 3.5.1.
https://github.com/void-linux/void-packages/pull/37656
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread