Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rusty-diceware: update to 0.3.3.
@ 2022-09-04 12:47 jcgruenhage
  2022-09-04 12:48 ` [PR REVIEW] " jcgruenhage
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: jcgruenhage @ 2022-09-04 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages rusty-diceware-0.3.3_1
https://github.com/void-linux/void-packages/pull/39098

rusty-diceware: update to 0.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39098.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rusty-diceware-0.3.3_1-39098.patch --]
[-- Type: text/x-diff, Size: 2919 bytes --]

From 447469b1e20003838ae0e142a99f312ac7ed666b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 4 Sep 2022 14:46:45 +0200
Subject: [PATCH] rusty-diceware: update to 0.3.3.

---
 .../0001-Fix-values-in-test-cases.patch       | 38 +++++++++++++++++++
 srcpkgs/rusty-diceware/template               |  4 +-
 2 files changed, 40 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch

diff --git a/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch b/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch
new file mode 100644
index 000000000000..e9ded5de45c3
--- /dev/null
+++ b/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch
@@ -0,0 +1,38 @@
+From 9f480fcbc9cb7bfb0d0bde8727dbfba9d878b596 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sun, 4 Sep 2022 14:38:10 +0200
+Subject: [PATCH] Fix values in test cases
+
+SeedableRng values are "stable", but minor version bumps (which have
+happened since these cases were written) are allowed to change those. A
+breaking change here was documentated for 0.7.
+---
+ tests/tests.rs | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/tests.rs b/tests/tests.rs
+index d569663..ed4eff4 100644
+--- a/tests/tests.rs
++++ b/tests/tests.rs
+@@ -33,7 +33,7 @@ fn make_reinhold_vector() -> Vec<ReinholdWord> {
+ 
+ #[test]
+ fn beale_rng_test() {
+-    let wanted: Vec<BealeWord> = vec!["dr", "raced", "pvc", "moon"]
++    let wanted: Vec<BealeWord> = vec!["io", "gavel", "beam", "time"]
+         .into_iter()
+         .map(BealeWord::new)
+         .collect();
+@@ -45,7 +45,7 @@ fn beale_rng_test() {
+ 
+ #[test]
+ fn reinhold_rng_test() {
+-    let wanted: Vec<ReinholdWord> = vec!["douse", "qo", "prune", "moan"]
++    let wanted: Vec<ReinholdWord> = vec!["india", "gamma", "bcd", "theme"]
+         .into_iter()
+         .map(ReinholdWord::new)
+         .collect();
+-- 
+2.37.3
+
diff --git a/srcpkgs/rusty-diceware/template b/srcpkgs/rusty-diceware/template
index bf5254ecefbd..a1d7a6524ede 100644
--- a/srcpkgs/rusty-diceware/template
+++ b/srcpkgs/rusty-diceware/template
@@ -1,6 +1,6 @@
 # Template file for 'rusty-diceware'
 pkgname=rusty-diceware
-version=0.3.0
+version=0.3.3
 revision=1
 wrksrc="${pkgname}-v${version}"
 build_style=cargo
@@ -9,7 +9,7 @@ maintainer="jcgruenhage <jan.christian@gruenhage.xyz>"
 license="AGPL-3.0"
 homepage="https://gitlab.com/yuvallanger/rusty-diceware"
 distfiles="https://gitlab.com/yuvallanger/rusty-diceware/-/archive/v${version}/rusty-diceware-v${version}.tar.gz"
-checksum=79c02206ad825604507be96623d6de9185c837900bce9b1d392095e789c06f61
+checksum=906a082a2b85fe8d1f5db88705704f44a7b5cafcd419a2eccb29e9ccbdff9e0e
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] rusty-diceware: update to 0.3.3.
  2022-09-04 12:47 [PR PATCH] rusty-diceware: update to 0.3.3 jcgruenhage
@ 2022-09-04 12:48 ` jcgruenhage
  2022-09-04 12:50 ` [PR PATCH] [Updated] " jcgruenhage
  2022-09-05 15:52 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: jcgruenhage @ 2022-09-04 12:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/39098#discussion_r962308568

Comment:
Submitted upstream in https://gitlab.com/yuvallanger/rusty-diceware/-/merge_requests/2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] rusty-diceware: update to 0.3.3.
  2022-09-04 12:47 [PR PATCH] rusty-diceware: update to 0.3.3 jcgruenhage
  2022-09-04 12:48 ` [PR REVIEW] " jcgruenhage
@ 2022-09-04 12:50 ` jcgruenhage
  2022-09-05 15:52 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: jcgruenhage @ 2022-09-04 12:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages rusty-diceware-0.3.3_1
https://github.com/void-linux/void-packages/pull/39098

rusty-diceware: update to 0.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39098.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rusty-diceware-0.3.3_1-39098.patch --]
[-- Type: text/x-diff, Size: 2999 bytes --]

From 5cea3f291a251b3327c59af87f08451b8928854c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 4 Sep 2022 14:46:45 +0200
Subject: [PATCH] rusty-diceware: update to 0.3.3.

---
 .../0001-Fix-values-in-test-cases.patch       | 38 +++++++++++++++++++
 srcpkgs/rusty-diceware/template               |  6 +--
 2 files changed, 41 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch

diff --git a/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch b/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch
new file mode 100644
index 000000000000..e9ded5de45c3
--- /dev/null
+++ b/srcpkgs/rusty-diceware/patches/0001-Fix-values-in-test-cases.patch
@@ -0,0 +1,38 @@
+From 9f480fcbc9cb7bfb0d0bde8727dbfba9d878b596 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sun, 4 Sep 2022 14:38:10 +0200
+Subject: [PATCH] Fix values in test cases
+
+SeedableRng values are "stable", but minor version bumps (which have
+happened since these cases were written) are allowed to change those. A
+breaking change here was documentated for 0.7.
+---
+ tests/tests.rs | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tests/tests.rs b/tests/tests.rs
+index d569663..ed4eff4 100644
+--- a/tests/tests.rs
++++ b/tests/tests.rs
+@@ -33,7 +33,7 @@ fn make_reinhold_vector() -> Vec<ReinholdWord> {
+ 
+ #[test]
+ fn beale_rng_test() {
+-    let wanted: Vec<BealeWord> = vec!["dr", "raced", "pvc", "moon"]
++    let wanted: Vec<BealeWord> = vec!["io", "gavel", "beam", "time"]
+         .into_iter()
+         .map(BealeWord::new)
+         .collect();
+@@ -45,7 +45,7 @@ fn beale_rng_test() {
+ 
+ #[test]
+ fn reinhold_rng_test() {
+-    let wanted: Vec<ReinholdWord> = vec!["douse", "qo", "prune", "moan"]
++    let wanted: Vec<ReinholdWord> = vec!["india", "gamma", "bcd", "theme"]
+         .into_iter()
+         .map(ReinholdWord::new)
+         .collect();
+-- 
+2.37.3
+
diff --git a/srcpkgs/rusty-diceware/template b/srcpkgs/rusty-diceware/template
index bf5254ecefbd..f179e7db3eab 100644
--- a/srcpkgs/rusty-diceware/template
+++ b/srcpkgs/rusty-diceware/template
@@ -1,15 +1,15 @@
 # Template file for 'rusty-diceware'
 pkgname=rusty-diceware
-version=0.3.0
+version=0.3.3
 revision=1
 wrksrc="${pkgname}-v${version}"
 build_style=cargo
 short_desc="Commandline diceware, sans dice, written in rustlang"
 maintainer="jcgruenhage <jan.christian@gruenhage.xyz>"
-license="AGPL-3.0"
+license="AGPL-3.0-only"
 homepage="https://gitlab.com/yuvallanger/rusty-diceware"
 distfiles="https://gitlab.com/yuvallanger/rusty-diceware/-/archive/v${version}/rusty-diceware-v${version}.tar.gz"
-checksum=79c02206ad825604507be96623d6de9185c837900bce9b1d392095e789c06f61
+checksum=906a082a2b85fe8d1f5db88705704f44a7b5cafcd419a2eccb29e9ccbdff9e0e
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: rusty-diceware: update to 0.3.3.
  2022-09-04 12:47 [PR PATCH] rusty-diceware: update to 0.3.3 jcgruenhage
  2022-09-04 12:48 ` [PR REVIEW] " jcgruenhage
  2022-09-04 12:50 ` [PR PATCH] [Updated] " jcgruenhage
@ 2022-09-05 15:52 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2022-09-05 15:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

There's a merged pull request on the void-packages repository

rusty-diceware: update to 0.3.3.
https://github.com/void-linux/void-packages/pull/39098

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-05 15:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-04 12:47 [PR PATCH] rusty-diceware: update to 0.3.3 jcgruenhage
2022-09-04 12:48 ` [PR REVIEW] " jcgruenhage
2022-09-04 12:50 ` [PR PATCH] [Updated] " jcgruenhage
2022-09-05 15:52 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).