Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] snapcast: update to 0.26.0
@ 2022-09-04  9:30 amak79
  2022-09-05 15:56 ` [PR REVIEW] " classabbyamp
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: amak79 @ 2022-09-04  9:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

There is a new pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/39095

snapcast: update to 0.26.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39095.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-39095.patch --]
[-- Type: text/x-diff, Size: 2794 bytes --]

From a3e0a572510cd8a0607f49ef54c3ff3fa6541780 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 4 Sep 2022 19:28:29 +1000
Subject: [PATCH] snapcast: update to 0.26.0

---
 .../patches/meta_mpd.py-permission-fix.patch  | 19 +++++++++++++++++++
 srcpkgs/snapcast/template                     |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch

diff --git a/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch b/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch
new file mode 100644
index 000000000000..ebff8013f574
--- /dev/null
+++ b/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch
@@ -0,0 +1,19 @@
+This patch fixes an issue where meta_mpd.py is installed with executable
+permissions only. This results in a 'Permission denied' message for
+03-rewrite-python-shebang, and a fatal error for xbps-create when processing
+the file hash. Fixed upstream in 7ab3daa.
+
+https://github.com/badaix/snapcast/issues/1021
+
+diff --git a/server/CMakeLists.txt b/server/CMakeLists.txt
+index e1271b80..25432cd5 100644
+--- a/server/CMakeLists.txt
++++ b/server/CMakeLists.txt
+@@ -117,6 +117,6 @@ else()
+     install(FILES etc/snapserver.conf COMPONENT server DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
+     install(FILES etc/index.html COMPONENT server DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver)
+     install(DIRECTORY etc/snapweb/ DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/snapweb)
+-    install(FILES etc/plug-ins/meta_mpd.py PERMISSIONS OWNER_EXECUTE GROUP_EXECUTE WORLD_EXECUTE DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/plug-ins/)
++    install(FILES etc/plug-ins/meta_mpd.py PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/plug-ins/)
+     #install(FILES ../debian/snapserver.service DESTINATION ${SYSTEMD_SERVICES_INSTALL_DIR})
+ endif()
diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index 918f02061082..92c97515624f 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,6 +1,6 @@
 # Template file for 'snapcast'
 pkgname=snapcast
-version=0.25.0
+version=0.26.0
 revision=1
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
@@ -15,7 +15,7 @@ maintainer="amak <amak.git@outlook.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/badaix/snapcast"
 distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=c4e449cb693e091261727421f4965492be049632537e034fa9c59c92d091a846
+checksum=166353267a5c461a3a0e7cbd05d78c4bfdaebeda078801df3b76820b54f27683
 
 build_options="avahi pulseaudio"
 build_options_default="avahi pulseaudio"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] snapcast: update to 0.26.0
  2022-09-04  9:30 [PR PATCH] snapcast: update to 0.26.0 amak79
@ 2022-09-05 15:56 ` classabbyamp
  2022-09-05 23:52 ` [PR PATCH] [Updated] " amak79
  2022-09-06  0:02 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2022-09-05 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39095#discussion_r963026455

Comment:
```suggestion
homepage="https://github.com/badaix/snapcast"
changelog="https://raw.githubusercontent.com/badaix/snapcast/master/changelog.md"
```

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] snapcast: update to 0.26.0
  2022-09-04  9:30 [PR PATCH] snapcast: update to 0.26.0 amak79
  2022-09-05 15:56 ` [PR REVIEW] " classabbyamp
@ 2022-09-05 23:52 ` amak79
  2022-09-06  0:02 ` [PR PATCH] [Merged]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: amak79 @ 2022-09-05 23:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

There is an updated pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/39095

snapcast: update to 0.26.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39095.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-39095.patch --]
[-- Type: text/x-diff, Size: 2928 bytes --]

From 1438ad7063c9237f04841e13dd1661d5bb6b92b2 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 4 Sep 2022 19:28:29 +1000
Subject: [PATCH] snapcast: update to 0.26.0

---
 .../patches/meta_mpd.py-permission-fix.patch  | 19 +++++++++++++++++++
 srcpkgs/snapcast/template                     |  5 +++--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch

diff --git a/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch b/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch
new file mode 100644
index 000000000000..ebff8013f574
--- /dev/null
+++ b/srcpkgs/snapcast/patches/meta_mpd.py-permission-fix.patch
@@ -0,0 +1,19 @@
+This patch fixes an issue where meta_mpd.py is installed with executable
+permissions only. This results in a 'Permission denied' message for
+03-rewrite-python-shebang, and a fatal error for xbps-create when processing
+the file hash. Fixed upstream in 7ab3daa.
+
+https://github.com/badaix/snapcast/issues/1021
+
+diff --git a/server/CMakeLists.txt b/server/CMakeLists.txt
+index e1271b80..25432cd5 100644
+--- a/server/CMakeLists.txt
++++ b/server/CMakeLists.txt
+@@ -117,6 +117,6 @@ else()
+     install(FILES etc/snapserver.conf COMPONENT server DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
+     install(FILES etc/index.html COMPONENT server DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver)
+     install(DIRECTORY etc/snapweb/ DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/snapweb)
+-    install(FILES etc/plug-ins/meta_mpd.py PERMISSIONS OWNER_EXECUTE GROUP_EXECUTE WORLD_EXECUTE DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/plug-ins/)
++    install(FILES etc/plug-ins/meta_mpd.py PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE DESTINATION ${CMAKE_INSTALL_DATADIR}/snapserver/plug-ins/)
+     #install(FILES ../debian/snapserver.service DESTINATION ${SYSTEMD_SERVICES_INSTALL_DIR})
+ endif()
diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index 918f02061082..e330653723ed 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,6 +1,6 @@
 # Template file for 'snapcast'
 pkgname=snapcast
-version=0.25.0
+version=0.26.0
 revision=1
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
@@ -14,8 +14,9 @@ short_desc="Synchronous multi-room audio player"
 maintainer="amak <amak.git@outlook.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/badaix/snapcast"
+changelog="https://raw.githubusercontent.com/badaix/snapcast/master/changelog.md"
 distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=c4e449cb693e091261727421f4965492be049632537e034fa9c59c92d091a846
+checksum=166353267a5c461a3a0e7cbd05d78c4bfdaebeda078801df3b76820b54f27683
 
 build_options="avahi pulseaudio"
 build_options_default="avahi pulseaudio"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: snapcast: update to 0.26.0
  2022-09-04  9:30 [PR PATCH] snapcast: update to 0.26.0 amak79
  2022-09-05 15:56 ` [PR REVIEW] " classabbyamp
  2022-09-05 23:52 ` [PR PATCH] [Updated] " amak79
@ 2022-09-06  0:02 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2022-09-06  0:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

There's a merged pull request on the void-packages repository

snapcast: update to 0.26.0
https://github.com/void-linux/void-packages/pull/39095

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-06  0:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-04  9:30 [PR PATCH] snapcast: update to 0.26.0 amak79
2022-09-05 15:56 ` [PR REVIEW] " classabbyamp
2022-09-05 23:52 ` [PR PATCH] [Updated] " amak79
2022-09-06  0:02 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).