[PR PATCH] Signal-Desktop: add support for x86_64

[PR PATCH] Signal-Desktop: add support for x86_64

[akierig]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

There is a new pull request by akierig against master on the void-packages repository

https://github.com/akierig/void-packages signal-desktop-musl
https://github.com/void-linux/void-packages/pull/39038

Signal-Desktop: add support for x86_64
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)


A patch file from https://github.com/void-linux/void-packages/pull/39038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signal-desktop-musl-39038.patch --]
[-- Type: text/x-diff, Size: 942 bytes --]

From 579f3811934a4eb9cd38736347cc6586a48e4b87 Mon Sep 17 00:00:00 2001
From: akierig <anelki@fastmail.de>
Date: Thu, 1 Sep 2022 11:40:35 -0500
Subject: [PATCH] Signal-Desktop now builds on x86_musl

---
 srcpkgs/Signal-Desktop/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index a69f86dd28f9..7e58cc2d3773 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -5,7 +5,7 @@ revision=1
 # Signal officially only supports x86_64 (also due to Electron)
 # x86_64-musl fails because of its dependency on 'node-gyp' which depends on a glibc specific extension
 # armv7hf/arm64: https://github.com/signalapp/Signal-Desktop/issues/3410
-archs="x86_64"
+archs="x86_64 x86_64-musl"
 hostmakedepends="git git-lfs nodejs python3 tar yarn"
 depends="cairo gtk+3 libvips pango"
 short_desc="Signal Private Messenger for Linux"

Re: [PR PATCH] [Updated] Signal-Desktop: add support for x86_64-musl

[akierig]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by akierig against master on the void-packages repository

https://github.com/akierig/void-packages signal-desktop-musl
https://github.com/void-linux/void-packages/pull/39038

Signal-Desktop: add support for x86_64-musl
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)


A patch file from https://github.com/void-linux/void-packages/pull/39038.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signal-desktop-musl-39038.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

From 08090c7b981710b4958ca0b6ed449fea72c6c91c Mon Sep 17 00:00:00 2001
From: akierig <anelki@fastmail.de>
Date: Thu, 1 Sep 2022 11:40:35 -0500
Subject: [PATCH] Signal-Desktop: add support for x86_64-musl

---
 srcpkgs/Signal-Desktop/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index a69f86dd28f9..7e58cc2d3773 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -5,7 +5,7 @@ revision=1
 # Signal officially only supports x86_64 (also due to Electron)
 # x86_64-musl fails because of its dependency on 'node-gyp' which depends on a glibc specific extension
 # armv7hf/arm64: https://github.com/signalapp/Signal-Desktop/issues/3410
-archs="x86_64"
+archs="x86_64 x86_64-musl"
 hostmakedepends="git git-lfs nodejs python3 tar yarn"
 depends="cairo gtk+3 libvips pango"
 short_desc="Signal Private Messenger for Linux"

Re: [PR PATCH] [Closed]: Signal-Desktop: add support for x86_64-musl

[akierig]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

There's a closed pull request on the void-packages repository

Signal-Desktop: add support for x86_64-musl
https://github.com/void-linux/void-packages/pull/39038

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl (crossbuild)

Re: Signal-Desktop: add support for x86_64-musl

[akierig]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by akierig on void-packages repository

https://github.com/void-linux/void-packages/pull/39038#issuecomment-1234545501

Comment:
wait, I built it improperly locally. Apologies.

Re: Signal-Desktop: add support for x86_64-musl

[selfisekai]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by selfisekai on void-packages repository

https://github.com/void-linux/void-packages/pull/39038#issuecomment-1237183158

Comment:
hey, FYI I've done this on Alpine repositories, the musl problems are:
- building ringrtc manually, which in turn requires building a Signal's fork of webrtc,
- building libsignal from separately downloaded source, with a sed on binding.gyp to compile for musl.

https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/testing/signal-desktop/APKBUILD

Re: Signal-Desktop: add support for x86_64-musl

[akierig]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by akierig on void-packages repository

https://github.com/void-linux/void-packages/pull/39038#issuecomment-1237267823

Comment:
cool, thank you! I've not got the capacity right now to pick this back up but a patch from you or anyone on Musl (or a PR re: #38609) would be most welcome.