* Re: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
@ 2022-09-07 22:32 ` classabbyamp
2022-09-07 22:33 ` [PR PATCH] [Updated] " emilio1625
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-09-07 22:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#issuecomment-1239974228
Comment:
these PRs should be combined if they depend on each other
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
2022-09-07 22:32 ` classabbyamp
@ 2022-09-07 22:33 ` emilio1625
2022-09-07 22:39 ` emilio1625
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: emilio1625 @ 2022-09-07 22:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
There is an updated pull request by emilio1625 against master on the void-packages repository
https://github.com/emilio1625/void-packages pulseaudio-gstreamer-support
https://github.com/void-linux/void-packages/pull/39158
Gstreamer codecs support for pulse audio
Along with #39157 allows the use of aptx or ldac codec for Bluetooth headsets
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/39158.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseaudio-gstreamer-support-39158.patch --]
[-- Type: text/x-diff, Size: 3125 bytes --]
From 07f199a7edecb6bfcb122fd9480040d2aaca16cd Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:51:45 -0500
Subject: [PATCH 1/2] pulseaudio: add gstreamer codec support
---
srcpkgs/pulseaudio/files/README.voidlinux | 1 +
srcpkgs/pulseaudio/template | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseaudio/files/README.voidlinux b/srcpkgs/pulseaudio/files/README.voidlinux
index 68bcd10179c3..1a4374ffee23 100644
--- a/srcpkgs/pulseaudio/files/README.voidlinux
+++ b/srcpkgs/pulseaudio/files/README.voidlinux
@@ -5,3 +5,4 @@ and security reasons.
Optional dependencies:
* `python3-PyQt5-dbus` for running `qpaeq`
+* `gst-plugins-bad1` and `libopenaptx` for aptX support
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index 685154e8c0e1..3750dde96c4f 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,22 +1,25 @@
# Template file for 'pulseaudio'
pkgname=pulseaudio
version=15.0
-revision=3
+revision=4
build_style=meson
configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
-Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
-Dgsettings=enabled -Dbluez5=enabled
-Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
+ -Dgstreamer=$(vopt_if gstreamer enabled disabled)
+ -Dbluez5-gstreamer=$(vopt_if gstreamer enabled disabled)
-Delogind=enabled -Dudevrulesdir=/usr/lib/udev/rules.d
-Dbashcompletiondir=/usr/share/bash-completion/completions"
hostmakedepends="cmake m4 gettext libtool orc-devel perl-XML-Parser pkg-config
doxygen"
makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel jack-devel
libSM-devel libXtst-devel libasyncns-devel libbluetooth-devel
+ $(vopt_if gstreamer gstreamer1-devel) $(vopt_if gstreamer gst-plugins-base1-devel)
libcap-devel libcap-progs libglib-devel libltdl-devel openssl-devel
libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
webrtc-audio-processing-devel xcb-util-devel check-devel elogind-devel"
-depends="pulseaudio-utils>=${version}_${revision} rtkit"
+depends="pulseaudio-utils>=${version}_${revision} rtkit $(vopt_if gstreamer gstreamer1)"
conf_files="/etc/pulse/*"
short_desc="Featureful, general-purpose sound server"
maintainer="Orphaned <orphan@voidlinux.org>"
From 2ffeffef72cbb1d574e0a0e965997fe6c26bde58 Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:58:47 -0500
Subject: [PATCH 2/2] pulseaudio: workaround for failing test
---
srcpkgs/pulseaudio/template | 2 ++
1 file changed, 2 insertions(+)
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index 3750dde96c4f..7b164d4289ee 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -52,6 +52,8 @@ pre_configure() {
# Disable neon optimizations for the arm* architectures
arm*) vsed -e '/ neon/d' -i src/pulsecore/meson.build ;;
esac
+ # workaround remove test that fails
+ vsed -e '/core-util-test/{N;d;}' -i src/tests/meson.build
}
post_install() {
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
2022-09-07 22:32 ` classabbyamp
2022-09-07 22:33 ` [PR PATCH] [Updated] " emilio1625
@ 2022-09-07 22:39 ` emilio1625
2022-09-07 22:43 ` classabbyamp
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: emilio1625 @ 2022-09-07 22:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
New comment by emilio1625 on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#issuecomment-1239979055
Comment:
> these PRs should be combined if they depend on each other
they don't depend on each other, you can build gst-plugins-bad1 with aptX/ldac support but no support for gstreamer in pulseaudio, or pulseaudio with or without gstreamer codec support, they just make more sense together
that said, I can combine them if that's preferred
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (2 preceding siblings ...)
2022-09-07 22:39 ` emilio1625
@ 2022-09-07 22:43 ` classabbyamp
2022-09-07 22:47 ` [PR PATCH] [Updated] " emilio1625
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-09-07 22:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#issuecomment-1239981377
Comment:
you're making the two changes for one result (bluetooth audio with pulse), right? it would make more sense to put them together
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (3 preceding siblings ...)
2022-09-07 22:43 ` classabbyamp
@ 2022-09-07 22:47 ` emilio1625
2022-09-07 23:00 ` emilio1625
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: emilio1625 @ 2022-09-07 22:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
There is an updated pull request by emilio1625 against master on the void-packages repository
https://github.com/emilio1625/void-packages pulseaudio-gstreamer-support
https://github.com/void-linux/void-packages/pull/39158
Gstreamer codecs support for pulse audio
Along with #39157 allows the use of aptx or ldac codec for Bluetooth headsets
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/39158.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulseaudio-gstreamer-support-39158.patch --]
[-- Type: text/x-diff, Size: 5479 bytes --]
From c63fca06f7ba5c37ee9347147a026c3891348b92 Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:14:08 -0500
Subject: [PATCH 1/3] gst-plugins-bad1: add aptX support
---
srcpkgs/gst-plugins-bad1/template | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/gst-plugins-bad1/template b/srcpkgs/gst-plugins-bad1/template
index 9b44958ec1ea..f3f9e77b98e3 100644
--- a/srcpkgs/gst-plugins-bad1/template
+++ b/srcpkgs/gst-plugins-bad1/template
@@ -1,7 +1,7 @@
# Template file for 'gst-plugins-bad1'
pkgname=gst-plugins-bad1
version=1.20.3
-revision=2
+revision=3
wrksrc="${pkgname/1/}-${version}"
build_helper="gir"
build_style=meson
@@ -13,6 +13,7 @@ configure_args="-Dpackage-origin=https://voidlinux.org -Ddoc=disabled
-Dopenh264=disabled -Dopenmpt=disabled -Dopenni2=disabled -Dsctp=disabled
-Dsrt=disabled -Dteletext=disabled -Dvoaacenc=disabled -Dvoamrwbenc=disabled
-Dwildmidi=disabled -Dwpe=disabled -Ddirectfb=disabled
+ -Dldac=$(vopt_if ldac enabled disabled) -Dopenaptx=$(vopt_if aptx enabled disabled)
-Dgme=$(vopt_if gme enabled disabled)
-Dintrospection=$(vopt_if gir enabled disabled) -Dneon=disabled"
hostmakedepends="automake gettext libtool pkg-config python3 glib-devel
@@ -29,7 +30,7 @@ makedepends="alsa-lib-devel celt-devel openssl-devel exempi-devel
fdk-aac-devel flite-devel fluidsynth-devel liblrdf-devel ladspa-sdk
lilv-devel lv2 libopenjpeg2-devel sbc-devel spandsp-devel vulkan-loader
Vulkan-Headers webrtc-audio-processing-devel libzbar-devel ffmpeg-devel
- srt-devel
+ $(vopt_if ldac ldacBT-devel) $(vopt_if aptx libopenaptx-devel) srt-devel
$(vopt_if gme libgme-devel)"
depends="gst-plugins-base1>=${version}"
short_desc="GStreamer plugins from the bad set (v1.x)"
@@ -39,9 +40,11 @@ homepage="https://gstreamer.freedesktop.org"
distfiles="${homepage}/src/${pkgname/1/}/${pkgname/1/}-${version}.tar.xz"
checksum=7a11c13b55dd1d2386dd902219e41cbfcdda8e1e0aa3e738186c95074b35da4f
-build_options="gir gme wayland"
-build_options_default="gir wayland"
+build_options="gir gme wayland aptx ldac"
+build_options_default="gir wayland aptx ldac"
desc_option_gme="Build with Game Music Emulator support"
+desc_option_apx="Build with AptX codec support"
+desc_option_ldac="Build with ldac codec support"
CFLAGS="-fcommon"
From 2896c8825893e6a7509ff6b27d13e959216bb451 Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:51:45 -0500
Subject: [PATCH 2/3] pulseaudio: add gstreamer codec support
---
srcpkgs/pulseaudio/files/README.voidlinux | 1 +
srcpkgs/pulseaudio/template | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pulseaudio/files/README.voidlinux b/srcpkgs/pulseaudio/files/README.voidlinux
index 68bcd10179c3..1a4374ffee23 100644
--- a/srcpkgs/pulseaudio/files/README.voidlinux
+++ b/srcpkgs/pulseaudio/files/README.voidlinux
@@ -5,3 +5,4 @@ and security reasons.
Optional dependencies:
* `python3-PyQt5-dbus` for running `qpaeq`
+* `gst-plugins-bad1` and `libopenaptx` for aptX support
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index 685154e8c0e1..3750dde96c4f 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,22 +1,25 @@
# Template file for 'pulseaudio'
pkgname=pulseaudio
version=15.0
-revision=3
+revision=4
build_style=meson
configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
-Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
-Dgsettings=enabled -Dbluez5=enabled
-Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
+ -Dgstreamer=$(vopt_if gstreamer enabled disabled)
+ -Dbluez5-gstreamer=$(vopt_if gstreamer enabled disabled)
-Delogind=enabled -Dudevrulesdir=/usr/lib/udev/rules.d
-Dbashcompletiondir=/usr/share/bash-completion/completions"
hostmakedepends="cmake m4 gettext libtool orc-devel perl-XML-Parser pkg-config
doxygen"
makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel jack-devel
libSM-devel libXtst-devel libasyncns-devel libbluetooth-devel
+ $(vopt_if gstreamer gstreamer1-devel) $(vopt_if gstreamer gst-plugins-base1-devel)
libcap-devel libcap-progs libglib-devel libltdl-devel openssl-devel
libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
webrtc-audio-processing-devel xcb-util-devel check-devel elogind-devel"
-depends="pulseaudio-utils>=${version}_${revision} rtkit"
+depends="pulseaudio-utils>=${version}_${revision} rtkit $(vopt_if gstreamer gstreamer1)"
conf_files="/etc/pulse/*"
short_desc="Featureful, general-purpose sound server"
maintainer="Orphaned <orphan@voidlinux.org>"
From 8e6746b00d00b0412c8ec3e3ceaf45d4c07c78d4 Mon Sep 17 00:00:00 2001
From: Emilio Cabrera <emilio1625@gmail.com>
Date: Wed, 7 Sep 2022 16:58:47 -0500
Subject: [PATCH 3/3] pulseaudio: workaround for failing test
---
srcpkgs/pulseaudio/template | 2 ++
1 file changed, 2 insertions(+)
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index 3750dde96c4f..7b164d4289ee 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -52,6 +52,8 @@ pre_configure() {
# Disable neon optimizations for the arm* architectures
arm*) vsed -e '/ neon/d' -i src/pulsecore/meson.build ;;
esac
+ # workaround remove test that fails
+ vsed -e '/core-util-test/{N;d;}' -i src/tests/meson.build
}
post_install() {
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (4 preceding siblings ...)
2022-09-07 22:47 ` [PR PATCH] [Updated] " emilio1625
@ 2022-09-07 23:00 ` emilio1625
2022-09-08 9:53 ` [PR REVIEW] " Duncaen
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: emilio1625 @ 2022-09-07 23:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New comment by emilio1625 on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#issuecomment-1239990983
Comment:
> you're making the two changes for one result (bluetooth audio with pulse), right? it would make more sense to put them together
done
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (5 preceding siblings ...)
2022-09-07 23:00 ` emilio1625
@ 2022-09-08 9:53 ` Duncaen
2022-12-08 2:32 ` github-actions
2022-12-23 1:57 ` [PR PATCH] [Closed]: " github-actions
8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2022-09-08 9:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#discussion_r965748475
Comment:
Those are not actually optional dependencies since the package won't be build with them by default right?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (6 preceding siblings ...)
2022-09-08 9:53 ` [PR REVIEW] " Duncaen
@ 2022-12-08 2:32 ` github-actions
2022-12-23 1:57 ` [PR PATCH] [Closed]: " github-actions
8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-12-08 2:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/39158#issuecomment-1341895657
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Closed]: Gstreamer codecs support for pulse audio
2022-09-07 22:30 [PR PATCH] Gstreamer codecs support for pulse audio emilio1625
` (7 preceding siblings ...)
2022-12-08 2:32 ` github-actions
@ 2022-12-23 1:57 ` github-actions
8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-12-23 1:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There's a closed pull request on the void-packages repository
Gstreamer codecs support for pulse audio
https://github.com/void-linux/void-packages/pull/39158
Description:
Along with #39157 allows the use of aptx or ldac codec for Bluetooth headsets
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86-glibc)
^ permalink raw reply [flat|nested] 10+ messages in thread