From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: atftp-0.8.0
Date: Wed, 14 Sep 2022 11:56:34 +0200 [thread overview]
Message-ID: <20220914095634.ChwY9qrZ_qB3wAZj2kpmacO_OMiC-Ojlu6xolB_-wSs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39250@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
New comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/39250#issuecomment-1246523385
Comment:
Okay, so I looked a bit into the test failures, and it's basically this bit not working:
```sh
start_server() {
# start a server
echo -n "Starting 'atftpd "${SERVER_ARGS/ \*/ /}"', "
$ATFTPD $SERVER_ARGS > $SERVER_LOG &
if [ $? != 0 ]; then
echo "Error starting server."
exit 1
fi
sleep 1
ATFTPD_PID=$!
# test if server process exists
if ! ps -p $ATFTPD_PID >/dev/null 2>&1 ; then
echo "Server process died!"
exit 1
fi
echo "PID: $ATFTPD_PID"
trap stop_and_clean EXIT SIGINT SIGTERM
}
```
It prints out that the server process has died, but that wasn't actually accurate. The server was still running, and the test script was hanging until I explicitly stopped it.
Unless anyone has a more concrete idea on why that is, I'd just mark this as make_check=no for now.
next prev parent reply other threads:[~2022-09-14 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 19:32 [PR PATCH] " jcgruenhage
2022-09-14 9:56 ` [PR PATCH] [Updated] " jcgruenhage
2022-09-14 9:56 ` jcgruenhage [this message]
2022-12-14 2:01 ` github-actions
2022-12-14 8:10 ` [PR PATCH] [Updated] " jcgruenhage
2022-12-14 8:10 ` jcgruenhage
2023-03-05 22:35 ` Piraty
2023-03-06 20:11 ` [PR PATCH] [Updated] " jcgruenhage
2023-06-05 2:04 ` github-actions
2023-06-20 1:56 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914095634.ChwY9qrZ_qB3wAZj2kpmacO_OMiC-Ojlu6xolB_-wSs@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).