[PR PATCH] New package: atftp-0.8.0

[PR PATCH] New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages atftp-0.8.0_1
https://github.com/void-linux/void-packages/pull/39250

New package: atftp-0.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39250.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-atftp-0.8.0_1-39250.patch --]
[-- Type: text/x-diff, Size: 1254 bytes --]

From 0cfed1563df11c03cc2a423f2a296377a40e66d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 12 Sep 2022 21:32:05 +0200
Subject: [PATCH] New package: atftp-0.8.0

---
 srcpkgs/atftp/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/atftp/template

diff --git a/srcpkgs/atftp/template b/srcpkgs/atftp/template
new file mode 100644
index 000000000000..92251c5be73d
--- /dev/null
+++ b/srcpkgs/atftp/template
@@ -0,0 +1,20 @@
+# Template file for 'atftp'
+pkgname=atftp
+version=0.8.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+makedepends="readline-devel pcre2-devel"
+short_desc="Client/server implementation of the TFTP protocol"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="GPL-2.0-only"
+homepage="https://sourceforge.net/projects/atftp/"
+changelog="https://sourceforge.net/p/atftp/code/ci/master/tree/Changelog?format=raw"
+distfiles="https://downloads.sf.net/sourceforge/atftp/atftp-${version}.tar.gz"
+checksum=df2aa089c7670f9eab40e5598e5d2cb6a582dc5182926ea50b4d690e4e37f316
+# Doesn't work, haven't looked
+make_check=no
+
+pre_configure() {
+	autoreconf -fi
+}

Re: [PR PATCH] [Updated] New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages atftp-0.8.0_1
https://github.com/void-linux/void-packages/pull/39250

New package: atftp-0.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39250.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-atftp-0.8.0_1-39250.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]

From 3109622c4f223c71a125c2477d782a445d7cb0a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 12 Sep 2022 21:32:05 +0200
Subject: [PATCH] New package: atftp-0.8.0

---
 srcpkgs/atftp/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/atftp/template

diff --git a/srcpkgs/atftp/template b/srcpkgs/atftp/template
new file mode 100644
index 000000000000..3cfe5d304c8d
--- /dev/null
+++ b/srcpkgs/atftp/template
@@ -0,0 +1,22 @@
+# Template file for 'atftp'
+pkgname=atftp
+version=0.8.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+makedepends="readline-devel pcre2-devel"
+short_desc="Client/server implementation of the TFTP protocol"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="GPL-2.0-only"
+homepage="https://sourceforge.net/projects/atftp/"
+changelog="https://sourceforge.net/p/atftp/code/ci/master/tree/Changelog?format=raw"
+distfiles="https://downloads.sf.net/sourceforge/atftp/atftp-${version}.tar.gz"
+checksum=df2aa089c7670f9eab40e5598e5d2cb6a582dc5182926ea50b4d690e4e37f316
+# Their test bash script thinks the server has died, but it hasn't, which
+# results in the check stage hanging forever.
+make_check=no
+conflicts="tftp-hpa"
+
+pre_configure() {
+	autoreconf -fi
+}

Re: New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/39250#issuecomment-1246523385

Comment:
Okay, so I looked a bit into the test failures, and it's basically this bit not working:

```sh
start_server() {
    # start a server
    echo -n "Starting 'atftpd "${SERVER_ARGS/ \*/ /}"', "
    $ATFTPD $SERVER_ARGS > $SERVER_LOG &
    if [ $? != 0 ]; then
	echo "Error starting server."
	exit 1
    fi
    sleep 1
    ATFTPD_PID=$!
    # test if server process exists
    if ! ps -p $ATFTPD_PID >/dev/null 2>&1 ; then
	echo "Server process died!"
	exit 1
    fi
    echo "PID: $ATFTPD_PID"
    trap stop_and_clean EXIT SIGINT SIGTERM
}
```

It prints out that the server process has died, but that wasn't actually accurate. The server was still running, and the test script was hanging until I explicitly stopped it.

Unless anyone has a more concrete idea on why that is, I'd just mark this as make_check=no for now. 

Re: New package: atftp-0.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39250#issuecomment-1350243755

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages atftp-0.8.0_1
https://github.com/void-linux/void-packages/pull/39250

New package: atftp-0.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39250.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-atftp-0.8.0_1-39250.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]

From 3109622c4f223c71a125c2477d782a445d7cb0a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 12 Sep 2022 21:32:05 +0200
Subject: [PATCH] New package: atftp-0.8.0

---
 srcpkgs/atftp/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/atftp/template

diff --git a/srcpkgs/atftp/template b/srcpkgs/atftp/template
new file mode 100644
index 000000000000..3cfe5d304c8d
--- /dev/null
+++ b/srcpkgs/atftp/template
@@ -0,0 +1,22 @@
+# Template file for 'atftp'
+pkgname=atftp
+version=0.8.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+makedepends="readline-devel pcre2-devel"
+short_desc="Client/server implementation of the TFTP protocol"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="GPL-2.0-only"
+homepage="https://sourceforge.net/projects/atftp/"
+changelog="https://sourceforge.net/p/atftp/code/ci/master/tree/Changelog?format=raw"
+distfiles="https://downloads.sf.net/sourceforge/atftp/atftp-${version}.tar.gz"
+checksum=df2aa089c7670f9eab40e5598e5d2cb6a582dc5182926ea50b4d690e4e37f316
+# Their test bash script thinks the server has died, but it hasn't, which
+# results in the check stage hanging forever.
+make_check=no
+conflicts="tftp-hpa"
+
+pre_configure() {
+	autoreconf -fi
+}

Re: New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/39250#issuecomment-1350598004

Comment:
Not stale.

Re: New package: atftp-0.8.0

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39250#issuecomment-1455228952

Comment:
i had a hunch that `ps` is missing. i was right.
tests succeed with `checkdepends="procps-ng"`

Re: [PR PATCH] [Updated] New package: atftp-0.8.0

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages atftp-0.8.0_1
https://github.com/void-linux/void-packages/pull/39250

New package: atftp-0.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39250.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-atftp-0.8.0_1-39250.patch --]
[-- Type: text/x-diff, Size: 1255 bytes --]

From afbf0e145388cc32081ac31a7a5204b8e2467152 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 12 Sep 2022 21:32:05 +0200
Subject: [PATCH] New package: atftp-0.8.0

---
 srcpkgs/atftp/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/atftp/template

diff --git a/srcpkgs/atftp/template b/srcpkgs/atftp/template
new file mode 100644
index 000000000000..2ccc70589d7c
--- /dev/null
+++ b/srcpkgs/atftp/template
@@ -0,0 +1,20 @@
+# Template file for 'atftp'
+pkgname=atftp
+version=0.8.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
+makedepends="readline-devel pcre2-devel"
+checkdepends="procps-ng"
+short_desc="Client/server implementation of the TFTP protocol"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="GPL-2.0-only"
+homepage="https://sourceforge.net/projects/atftp/"
+changelog="https://sourceforge.net/p/atftp/code/ci/master/tree/Changelog?format=raw"
+distfiles="https://downloads.sf.net/sourceforge/atftp/atftp-${version}.tar.gz"
+checksum=df2aa089c7670f9eab40e5598e5d2cb6a582dc5182926ea50b4d690e4e37f316
+conflicts="tftp-hpa"
+
+pre_configure() {
+	autoreconf -fi
+}

Re: New package: atftp-0.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39250#issuecomment-1575930340

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: atftp-0.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

There's a closed pull request on the void-packages repository

New package: atftp-0.8.0
https://github.com/void-linux/void-packages/pull/39250

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->