From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gammastep: update to 2.0.9
Date: Tue, 20 Sep 2022 14:15:09 +0200 [thread overview]
Message-ID: <20220920121509.Wj-Ln0bI627jHjARXWGw95qT40tNKhCHOp4OjPURDT4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39306@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/39306#discussion_r975283581
Comment:
>for commit, you can't use it with distfiles anyway
Not sure what you mean, as I am quite sure I have been able to change a single line for any ref (branch, commit, or tag) versus having to edit three different occurrences to `v$version` without the _ref variable (as shown below). Are you saying that the distfiles will be wrong for the version defined? If so, I do acknowledge that, but I have had no trouble running clean, then re-genning the checksum in those cases.
```diff
@@ -2,7 +2,7 @@
pkgname=gammastep
version=2.0.9
revision=1
-wrksrc="${pkgname}-v${version}"
+wrksrc="${pkgname}-eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1"
build_style=gnu-configure
configure_args="--enable-gui --enable-drm --enable-vidmode --enable-randr
--enable-wayland --enable-apparmor --with-systemduserunitdir=no
@@ -16,8 +16,8 @@ maintainer="Cameron Nemo <cam@nohom.org>"
license="GPL-3.0-or-later"
homepage="https://gitlab.com/chinstrap/gammastep"
changelog="https://gitlab.com/chinstrap/gammastep/raw/master/NEWS.md"
-distfiles="https://gitlab.com/chinstrap/gammastep/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
-checksum=bbb9d90e1cf30920c1017db4ce5c4652e4c7843fd4c4e34164d99ecbc3bbb4c0
+distfiles="https://gitlab.com/chinstrap/gammastep/-/archive/eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1/${pkgname}-eab8be4fc33e4c4b953252e2a4f24e4f5322b0b1.tar.gz"
+checksum=b3a2fb29c076d1af9ffbb6ccc2a32667954ea22cdc23a90747b78355225e43c8
build_options="geoclue2"
build_options_default="geoclue2"
```
Regardless, I have reverted the change for now so as not to introduce inconsistencies or bad samples into the ports tree.
next prev parent reply other threads:[~2022-09-20 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 19:53 [PR PATCH] " CameronNemo
2022-09-18 13:46 ` [PR REVIEW] " sgn
2022-09-18 21:41 ` CameronNemo
2022-09-18 21:41 ` CameronNemo
2022-09-19 1:01 ` sgn
2022-09-20 12:12 ` [PR PATCH] [Updated] " CameronNemo
2022-09-20 12:15 ` CameronNemo [this message]
2022-09-22 6:28 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920121509.Wj-Ln0bI627jHjARXWGw95qT40tNKhCHOp4OjPURDT4@z \
--to=cameronnemo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).