[PR PATCH] New package: python3-loguru-0.6.0

[PR PATCH] New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

There is a new pull request by oliver-cfc against master on the void-packages repository

https://github.com/oliver-cfc/void-packages python3-loguru
https://github.com/void-linux/void-packages/pull/37434

New package: python3-loguru-0.6.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES
-->

<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
-->


A patch file from https://github.com/void-linux/void-packages/pull/37434.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-loguru-37434.patch --]
[-- Type: text/x-diff, Size: 1083 bytes --]

From 378fc6f65ab1e87ef0438afb39a6cca53f30f959 Mon Sep 17 00:00:00 2001
From: oliver <oliver.hemming@lumen.com>
Date: Tue, 7 Jun 2022 09:44:31 -0400
Subject: [PATCH] New package: python3-loguru-0.6.0

---
 srcpkgs/python3-loguru/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-loguru/template

diff --git a/srcpkgs/python3-loguru/template b/srcpkgs/python3-loguru/template
new file mode 100644
index 000000000000..2b8362d21796
--- /dev/null
+++ b/srcpkgs/python3-loguru/template
@@ -0,0 +1,20 @@
+# Template file for 'python3-loguru'
+pkgname=python3-loguru
+version=0.6.0
+revision=1
+wrksrc="loguru-${version}"
+build_style=python3-module
+short_desc="Library which aims to bring enjoyable logging in Python"
+maintainer="oliver <oliver@tuta.io>"
+license="MIT"
+homepage="https://github.com/Delgan/loguru"
+distfiles="${PYPI_SITE}/l/loguru/loguru-$version.tar.gz"
+checksum=066bd06758d0a513e9836fd9c6b5a75bfb3fd36841f4b996bc60b547a309d41c
+
+post_install() {
+	vlicense LICENSE
+}
+
+do_check() {
+	python3 setup.py test
+}

Re: [PR REVIEW] New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#discussion_r891285860

Comment:
this is already the default behaviour:

https://github.com/void-linux/void-packages/blob/2859518608b4f682abd4afb6b9f8c2dce01a0523/common/build-style/python3-module.sh#L40-L41

Re: New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1148805208

Comment:
the CI fail is probably caused by needing `python3-setuptools` in `hostmakedepends`

there's also a `changelog` that can be added: https://raw.githubusercontent.com/Delgan/loguru/master/CHANGELOG.rst

Re: [PR REVIEW] New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#discussion_r891664402

Comment:
but in this case you'd want to add `checkdepends="python3-pytest"` because the tests in this package are run with pytest

Re: [PR REVIEW] New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#discussion_r891664402

Comment:
but in this case you'd want to remove the do_check function add `checkdepends="python3-pytest"` because the tests in this package are run with pytest

Re: [PR REVIEW] New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New review comment by oliver-cfc on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#discussion_r892497626

Comment:
Thanks - I really appreciate your comments and insight. 
Is there an appropriate way to test this before amending the PR?  The original template compiled perfectly in a freshly created xbps-src environment but then failed the build checks.

Does it even need a do_check{} section? 

Re: [PR REVIEW] New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#discussion_r892523424

Comment:
running xbps-src pkg and xbps-src check would be how I'd test building the template

Re: New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

New comment by oliver-cfc on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1150522525

Comment:
I think this is the good one.  I added python3-colorama to checkdepends (along with python3-pytest) because xbps-src check fails without it but it's not needed for python3-loguru to run. Also added hostmakedepends and checkdepends.  

```
# Template file for 'python3-loguru'
pkgname=python3-loguru
version=0.6.0
revision=1
wrksrc="loguru-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
checkdepends="python3-pytest python3-colorama"
short_desc="Library which aims to bring enjoyable logging in Python"
maintainer="oliver <oliver@tuta.io>"
license="MIT"
homepage="https://github.com/Delgan/loguru"
changelog="https://raw.githubusercontent.com/Delgan/loguru/master/CHANGELOG.rst"
distfiles="${PYPI_SITE}/l/loguru/loguru-$version.tar.gz"
checksum=066bd06758d0a513e9836fd9c6b5a75bfb3fd36841f4b996bc60b547a309d41c

post_install() {
        vlicense LICENSE
}
```

Are these the correct next steps (while in my branch)?
1) git add ./srcpkgs/python3-loguru/template
2) git commit --amend
3) git rebase -i HEAD~2
4) git push origin <my branch>

Re: New package: python3-loguru-0.6.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1150529445

Comment:
> Are these the correct next steps (while in my branch)?

```
git add srcpkgs/python3-loguru/template
git commit --amend
git push --force
```
should be enough

Re: [PR PATCH] [Updated] New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

There is an updated pull request by oliver-cfc against master on the void-packages repository

https://github.com/oliver-cfc/void-packages python3-loguru
https://github.com/void-linux/void-packages/pull/37434

New package: python3-loguru-0.6.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES
-->

<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
-->


A patch file from https://github.com/void-linux/void-packages/pull/37434.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-loguru-37434.patch --]
[-- Type: text/x-diff, Size: 1207 bytes --]

From c6c6940ab7ed98175289003eade6a495d25f7203 Mon Sep 17 00:00:00 2001
From: oliver <oliver.hemming@lumen.com>
Date: Tue, 7 Jun 2022 09:44:31 -0400
Subject: [PATCH] New package: python3-loguru-0.6.0

---
 srcpkgs/python3-loguru/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-loguru/template

diff --git a/srcpkgs/python3-loguru/template b/srcpkgs/python3-loguru/template
new file mode 100644
index 000000000000..4ee2f6befc9a
--- /dev/null
+++ b/srcpkgs/python3-loguru/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-loguru'
+pkgname=python3-loguru
+version=0.6.0
+revision=1
+wrksrc="loguru-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+checkdepends="python3-pytest python3-colorama"
+short_desc="Library which aims to bring enjoyable logging in Python"
+maintainer="oliver <oliver@tuta.io>"
+license="MIT"
+homepage="https://github.com/Delgan/loguru"
+changelog="https://raw.githubusercontent.com/Delgan/loguru/master/CHANGELOG.rst"
+distfiles="${PYPI_SITE}/l/loguru/loguru-$version.tar.gz"
+checksum=066bd06758d0a513e9836fd9c6b5a75bfb3fd36841f4b996bc60b547a309d41c
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by oliver-cfc on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1152469779

Comment:
I assume I'm hitting this: https://github.com/Delgan/loguru/issues/658
Do you want this PR closed until a new release of loguru?

Re: [PR PATCH] [Updated] New package: python3-loguru-0.6.0

[oliver-cfc]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

There is an updated pull request by oliver-cfc against master on the void-packages repository

https://github.com/oliver-cfc/void-packages python3-loguru
https://github.com/void-linux/void-packages/pull/37434

New package: python3-loguru-0.6.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES
-->

<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
-->


A patch file from https://github.com/void-linux/void-packages/pull/37434.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-loguru-37434.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From a06eb86302d0697a6c86c9ebcea73da3a029e0d7 Mon Sep 17 00:00:00 2001
From: oliver <oliver.hemming@lumen.com>
Date: Tue, 7 Jun 2022 09:44:31 -0400
Subject: [PATCH] New package: python3-loguru-0.6.0

---
 srcpkgs/python3-loguru/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/python3-loguru/template

diff --git a/srcpkgs/python3-loguru/template b/srcpkgs/python3-loguru/template
new file mode 100644
index 000000000000..9d1fddbe9c8c
--- /dev/null
+++ b/srcpkgs/python3-loguru/template
@@ -0,0 +1,24 @@
+# Template file for 'python3-loguru'
+pkgname=python3-loguru
+version=0.6.0
+revision=1
+wrksrc="loguru-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+checkdepends="python3-pytest python3-colorama"
+short_desc="Library which aims to bring enjoyable logging in Python"
+maintainer="oliver <oliver@tuta.io>"
+license="MIT"
+homepage="https://github.com/Delgan/loguru"
+changelog="https://raw.githubusercontent.com/Delgan/loguru/master/CHANGELOG.rst"
+distfiles="${PYPI_SITE}/l/loguru/loguru-$version.tar.gz"
+checksum=066bd06758d0a513e9836fd9c6b5a75bfb3fd36841f4b996bc60b547a309d41c
+
+case $XBPS_TARGET_MACHINE in
+	# https://github.com/Delgan/loguru/issues/658
+	x86_64-musl) make_check_args="--ignore=tests/test_filesink_rotation.py";;
+esac
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: python3-loguru-0.6.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37434#issuecomment-1242595724

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: python3-loguru-0.6.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There's a closed pull request on the void-packages repository

New package: python3-loguru-0.6.0
https://github.com/void-linux/void-packages/pull/37434

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES
-->

<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
-->