[PR PATCH] acr: update to 2.0.0

[PR PATCH] acr: update to 2.0.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

There is a new pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-25
https://github.com/void-linux/void-packages/pull/39727

acr: update to 2.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39727.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-25-39727.patch --]
[-- Type: text/x-diff, Size: 1545 bytes --]

From dfad8e43763ad9eccee1f9ec8a566830d2bf9567 Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Tue, 4 Oct 2022 21:34:03 -0300
Subject: [PATCH] Delete srcpkgs/acr/patches directory

acr: update to 2.0.0
---
 srcpkgs/acr/patches/fix-test.patch | 9 ---------
 srcpkgs/acr/template               | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)
 delete mode 100644 srcpkgs/acr/patches/fix-test.patch

diff --git a/srcpkgs/acr/patches/fix-test.patch b/srcpkgs/acr/patches/fix-test.patch
deleted file mode 100644
index 05816ddfdb63..000000000000
--- a/srcpkgs/acr/patches/fix-test.patch
+++ /dev/null
@@ -1,9 +0,0 @@
-diff --git a/examples/pkgcfg.acr b/examples/pkgcfg.acr
-index ce7fa02..10da766 100644
---- a/examples/pkgcfg.acr
-+++ b/examples/pkgcfg.acr
-@@ -1,3 +1,4 @@
-+USE_PKGCONFIG
- PKGCFG GTK_FLAGS GTK_LIBS gtk+-2.0
- 
- CHKVER libuv 1.0.0
diff --git a/srcpkgs/acr/template b/srcpkgs/acr/template
index 0574ea512016..3450f8118490 100644
--- a/srcpkgs/acr/template
+++ b/srcpkgs/acr/template
@@ -1,6 +1,6 @@
 # Template file for 'acr'
 pkgname=acr
-version=1.9.8
+version=2.0.0
 revision=1
 build_style=gnu-configure
 checkdepends="pkg-config"
@@ -10,4 +10,4 @@ maintainer="Felipe Nogueira <contato.fnog@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/radare/acr"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=88bb2e4cb35b18370675710806c4ef03ef81a6ed521b939e272267754e8484c1
+checksum=86ecbb47b62c5469dcb9c5b8c13efd68e18eb572bc037979316e9a75d6d26e21

Re: acr: update to 2.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39727#issuecomment-1267779661

Comment:
Please fix the lint error and your commit message, which should just be "acr: update to 2.0.0."

Re: acr: update to 2.0.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/39727#issuecomment-1267780198

Comment:
Please follow the conventions for commit messages.  It should be: `acr: update to 2.0.0`

Re: acr: update to 2.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39727#issuecomment-1268093993

Comment:
There is a big difference between commit message and commit body.

Re: acr: update to 2.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39727#issuecomment-1268093993

Comment:
There is a big difference between commit message and commit body. The commit message should be `acr: update to 2.0.0` and you can leave `Delete srcpkgs/acr/patches directory` in the commit body, but right now it's exactly opposite.

Re: [PR PATCH] [Updated] acr: update to 2.0.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

There is an updated pull request by bugcrazy against master on the void-packages repository

https://github.com/bugcrazy/void-packages patch-25
https://github.com/void-linux/void-packages/pull/39727

acr: update to 2.0.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39727.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-25-39727.patch --]
[-- Type: text/x-diff, Size: 1563 bytes --]

From 0be22c0b4154ba9ec4c3143e22052ab9e5993649 Mon Sep 17 00:00:00 2001
From: bugcrazy <marcoaureliopc@gmail.com>
Date: Wed, 5 Oct 2022 14:53:50 -0300
Subject: [PATCH] acr: update to 2.0.0

---
 srcpkgs/acr/patches/fix-test.patch | 9 ---------
 srcpkgs/acr/template               | 6 +++---
 2 files changed, 3 insertions(+), 12 deletions(-)
 delete mode 100644 srcpkgs/acr/patches/fix-test.patch

diff --git a/srcpkgs/acr/patches/fix-test.patch b/srcpkgs/acr/patches/fix-test.patch
deleted file mode 100644
index 05816ddfdb63..000000000000
--- a/srcpkgs/acr/patches/fix-test.patch
+++ /dev/null
@@ -1,9 +0,0 @@
-diff --git a/examples/pkgcfg.acr b/examples/pkgcfg.acr
-index ce7fa02..10da766 100644
---- a/examples/pkgcfg.acr
-+++ b/examples/pkgcfg.acr
-@@ -1,3 +1,4 @@
-+USE_PKGCONFIG
- PKGCFG GTK_FLAGS GTK_LIBS gtk+-2.0
- 
- CHKVER libuv 1.0.0
diff --git a/srcpkgs/acr/template b/srcpkgs/acr/template
index 0574ea512016..dadc5f29488e 100644
--- a/srcpkgs/acr/template
+++ b/srcpkgs/acr/template
@@ -1,13 +1,13 @@
 # Template file for 'acr'
 pkgname=acr
-version=1.9.8
+version=2.0.0
 revision=1
 build_style=gnu-configure
-checkdepends="pkg-config"
 make_check_target=test
+checkdepends="pkg-config"
 short_desc="AutoConf Replacement"
 maintainer="Felipe Nogueira <contato.fnog@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/radare/acr"
 distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=88bb2e4cb35b18370675710806c4ef03ef81a6ed521b939e272267754e8484c1
+checksum=86ecbb47b62c5469dcb9c5b8c13efd68e18eb572bc037979316e9a75d6d26e21

Re: acr: update to 2.0.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/39727#issuecomment-1268695954

Comment:
Fixed all the reported problems.

Re: [PR PATCH] [Closed]: acr: update to 2.0.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

There's a closed pull request on the void-packages repository

acr: update to 2.0.0
https://github.com/void-linux/void-packages/pull/39727

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->