[PR PATCH] Revert "python3-poetry-core: update to 1.3.1."

[PR PATCH] Revert "python3-poetry-core: update to 1.3.1."

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-poetry-core
https://github.com/void-linux/void-packages/pull/39777

Revert "python3-poetry-core: update to 1.3.1."
I messed the last commit since I forgot use `XBPS_CHECK_PKGS=yes` while packaging two revdeps today. so even though it builds, it fails test(s) and errs in runtime.

A patch file from https://github.com/void-linux/void-packages/pull/39777.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-poetry-core-39777.patch --]
[-- Type: text/x-diff, Size: 1476 bytes --]

From f8ea6e900a9406a60d35ae9b1c0d734debbf9788 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Thu, 6 Oct 2022 21:50:29 +0530
Subject: [PATCH] Revert "python3-poetry-core: update to 1.3.1."

This reverts commit 25dfe0bbd89769d8291c8c3ea3dd1e10ef937fc0.

Synapse is having runtime issues.

https://github.com/matrix-org/synapse/issues/14079.
---
 srcpkgs/python3-poetry-core/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
index 760493d3d33c..e1d9b0a45f12 100644
--- a/srcpkgs/python3-poetry-core/template
+++ b/srcpkgs/python3-poetry-core/template
@@ -1,7 +1,8 @@
 # Template file for 'python3-poetry-core'
 pkgname=python3-poetry-core
-version=1.3.1
-revision=1
+reverts="1.3.1_1"
+version=1.1.0
+revision=2
 wrksrc="poetry-core-${version}"
 build_style="python3-pep517"
 make_check_args="--deselect tests/masonry/builders/test_sdist.py::test_default_with_excluded_data
@@ -14,7 +15,7 @@ license="MIT"
 homepage="https://github.com/python-poetry/poetry-core"
 changelog="https://raw.githubusercontent.com/python-poetry/poetry-core/main/CHANGELOG.md"
 distfiles="https://github.com/python-poetry/poetry-core/archive/refs/tags/${version}.tar.gz"
-checksum=8da8ce8f2e861527f660d7205a77095279d462b44d1d11bcf9e8ce74d96219ee
+checksum=44535d5c20e20189041714a45758774f713e4a53c3db071dca11a59d32aeba44
 make_check_pre="env PYTHONPATH=src"
 
 pre_check() {

Re: Revert "python3-poetry-core: update to 1.3.1."

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1270458729

Comment:
Synapse really doesn't seem to have its act together wrt dependency handling and, if that's the only problem, I'm reluctant to revert a perfectly reasonable update because of their pointless dependency checks.

What happens if you patch the dependency check at https://github.com/matrix-org/synapse/blob/7b67e93d499cb45f7217e9dfea046ed8b5c455fd/synapse/config/repository.py#L206-L208 to look for `url-preview` instead of `url_preview`?

Re: Revert "python3-poetry-core: update to 1.3.1."

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1270469189

Comment:
There are some "official" pulls: https://github.com/matrix-org/synapse/pull/14080 & https://github.com/matrix-org/synapse/pull/14085

Re: Revert "python3-poetry-core: update to 1.3.1."

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1270482389

Comment:
https://github.com/matrix-org/synapse/pull/14085 looks like the way to go.

Re: Revert "python3-poetry-core: update to 1.3.1."

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1270491511

Comment:
Should I wait for it to merge? As the previous one got reverted in the second one and there's some unresolved comments.

Re: Revert "python3-poetry-core: update to 1.3.1."

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1270561987

Comment:
Yeah, see what they eventually merge before pulling the patch.

Re: Revert "python3-poetry-core: update to 1.3.1."

[reivilibre]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

New comment by reivilibre on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1271480156

Comment:
> pointless dependency checks

The dependency checks are not pointless; they prevent you from running Synapse with out of date deps, which isn't hard to do due to the absolute minefields in installing Python packages. They were added after getting enough bug reports from people doing that, which ultimately takes a lot of time and effort to respond to.

> Synapse really doesn't seem to have its act together wrt dependency handling

Problem is that everything is a damned if you do, damned if you don't situation. There are many ways to install Synapse and distro packages are but some of them :).
We do make a lot of effort to keep things workable for distro packages but having old versions break under our feet because of dependency changes is also a massive pain to deal with. If you're aware of better ways of doing this then let us know.

Re: Revert "python3-poetry-core: update to 1.3.1."

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1271510872

Comment:
I apologize; my comment was a bit harsh.

The underlying problem is the fragmented and constantly changing official view of Python packaging building and distribution. PyPA seems to take the view that only pip matters, but they haven't addressed the first half of the packaging problem adequately and pip is a terrible package manager. The `search` sub-command has been broken by design for years because they don't seem to know how to rate-limit spammy queries; at this point why does it still exist? Even worse, why does the package manager happily let you install entirely new dependency chains and only **after** the fact warn you about conflicting version restrictions?

It's only natural that each project tries to work around a sea of inconsistent and half-formed tooling with unique hacks, but that just causes problems elsewhere. Damned whether you do or don't, indeed.

Re: Revert "python3-poetry-core: update to 1.3.1."

[reivilibre]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by reivilibre on void-packages repository

https://github.com/void-linux/void-packages/pull/39777#issuecomment-1271585257

Comment:
> The underlying problem is the fragmented and constantly changing official view of Python packaging building and distribution

Indeed and agreed with your entire post; we all feel this pain whenever anything like this happens. (Which has been way too frequently in recent weeks for my liking.)

Re: [PR PATCH] [Closed]: Revert "python3-poetry-core: update to 1.3.1."

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

There's a closed pull request on the void-packages repository

Revert "python3-poetry-core: update to 1.3.1."
https://github.com/void-linux/void-packages/pull/39777

Description:
I messed the last commit since I forgot use `XBPS_CHECK_PKGS=yes` while packaging two revdeps today. so even though it builds, it fails test(s) and errs in runtime.