* [PR PATCH] igt-gpu-tools: update to 1.26.
@ 2022-10-06 18:24 oreo639
2022-10-06 18:27 ` [PR PATCH] [Updated] " oreo639
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: oreo639 @ 2022-10-06 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
There is a new pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages igt
https://github.com/void-linux/void-packages/pull/39780
igt-gpu-tools: update to 1.26.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39780.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-igt-39780.patch --]
[-- Type: text/x-diff, Size: 1135 bytes --]
From 593d87678101ddd0bbed0528a9b2368342bb489a Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Thu, 6 Oct 2022 11:23:10 -0700
Subject: [PATCH] igt-gpu-tools: update to 1.26.
---
srcpkgs/igt-gpu-tools/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/igt-gpu-tools/template b/srcpkgs/igt-gpu-tools/template
index e5865e11a57f..159bfd0bdc21 100644
--- a/srcpkgs/igt-gpu-tools/template
+++ b/srcpkgs/igt-gpu-tools/template
@@ -1,7 +1,7 @@
# Template file for 'igt-gpu-tools'
pkgname=igt-gpu-tools
-version=1.25
-revision=5
+version=1.26
+revision=1
build_style=meson
configure_args="-Db_ndebug=false -Db_lto=false"
# b_lto=true makes the build hang at a random point
@@ -14,7 +14,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
homepage="https://gitlab.freedesktop.org/drm/igt-gpu-tools"
distfiles="${XORG_SITE}/app/${pkgname}-${version}.tar.xz"
-checksum=40454d8f0484ea2477862007398a08eef78a6c252c4defce1c934548593fdd11
+checksum=36d4193b9f22fbb4834ec97be3bb6322ec901e20f7be018f0a50d3eb03ec9bb7
# tests don't behave in containers
make_check=ci-skip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] igt-gpu-tools: update to 1.26.
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
@ 2022-10-06 18:27 ` oreo639
2022-10-06 18:44 ` oreo639
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: oreo639 @ 2022-10-06 18:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages igt
https://github.com/void-linux/void-packages/pull/39780
igt-gpu-tools: update to 1.26.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39780.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-igt-39780.patch --]
[-- Type: text/x-diff, Size: 1135 bytes --]
From 69063b462fb58149df70e407f9c748cbedc48596 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Thu, 6 Oct 2022 11:23:10 -0700
Subject: [PATCH] igt-gpu-tools: update to 1.26.
---
srcpkgs/igt-gpu-tools/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/igt-gpu-tools/template b/srcpkgs/igt-gpu-tools/template
index e5865e11a57f..159bfd0bdc21 100644
--- a/srcpkgs/igt-gpu-tools/template
+++ b/srcpkgs/igt-gpu-tools/template
@@ -1,7 +1,7 @@
# Template file for 'igt-gpu-tools'
pkgname=igt-gpu-tools
-version=1.25
-revision=5
+version=1.26
+revision=1
build_style=meson
configure_args="-Db_ndebug=false -Db_lto=false"
# b_lto=true makes the build hang at a random point
@@ -14,7 +14,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
homepage="https://gitlab.freedesktop.org/drm/igt-gpu-tools"
distfiles="${XORG_SITE}/app/${pkgname}-${version}.tar.xz"
-checksum=40454d8f0484ea2477862007398a08eef78a6c252c4defce1c934548593fdd11
+checksum=36d4193b9f22fbb4834ec97be3bb6322ec901e20f7be018f0a50d3eb03ec9bb7
# tests don't behave in containers
make_check=ci-skip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] igt-gpu-tools: update to 1.26.
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
2022-10-06 18:27 ` [PR PATCH] [Updated] " oreo639
@ 2022-10-06 18:44 ` oreo639
2022-10-06 19:00 ` igt-gpu-tools: fix buffer overflow paper42
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: oreo639 @ 2022-10-06 18:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages igt
https://github.com/void-linux/void-packages/pull/39780
igt-gpu-tools: update to 1.26.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39780.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-igt-39780.patch --]
[-- Type: text/x-diff, Size: 2355 bytes --]
From 75e65a928c49ff8ce0d868aef1a3fae653df430f Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Thu, 6 Oct 2022 11:44:47 -0700
Subject: [PATCH] igt-gpu-tools: fix buffer overflow
---
...t_edid-Allocate-raw-8-bytes-for-VSDB.patch | 42 +++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
diff --git a/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch b/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
new file mode 100644
index 000000000000..7cc9e289305c
--- /dev/null
+++ b/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
@@ -0,0 +1,42 @@
+From 2107b0a53692fb329175bc16169c3699712187aa Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sat, 27 Feb 2021 14:10:41 -0800
+Subject: [PATCH] lib/igt_edid: Allocate raw 8-bytes for VSDB
+
+hdmi_vsdb is an element of cea_vsdb which makes the size of cea_vsdb to
+be 8 ( 3bytes ieee_oui ) + ( 5bytes hdmi_vsdb struct), its true that we
+only use 7 bytes technically we can only allocate 7byte array but since
+we are writing to elements of hdmi_vsdb struct which is sitting at offet
+4-8 in cea_vsdb, compiler thinks we have an element which is out of
+array bounds since out allocated size is 7bytes
+
+This errors out
+../git/lib/igt_edid.c:365:13: error: array subscript 'struct hdmi_vsdb[0]' is partly outside array bounds of 'char[7]' [-Werror=array-bounds]
+ 365 | hdmi->src_phy_addr[0] = 0x10;
+ | ^~
+
+allocating one extra byte matches with size of cea_vsdb and compiler is
+happy
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Reviewed-by: Martin Peres <martin.peres@mupuf.org>
+---
+ lib/igt_edid.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/igt_edid.c b/lib/igt_edid.c
+index 1c85486d..ce09cc47 100644
+--- a/lib/igt_edid.c
++++ b/lib/igt_edid.c
+@@ -351,7 +351,7 @@ void cea_sad_init_pcm(struct cea_sad *sad, int channels,
+ const struct cea_vsdb *cea_vsdb_get_hdmi_default(size_t *size)
+ {
+ /* We'll generate a VSDB with 2 extension fields. */
+- static char raw[CEA_VSDB_HDMI_MIN_SIZE + 2] = {0};
++ static char raw[CEA_VSDB_HDMI_MIN_SIZE + 3] = {0};
+ struct cea_vsdb *vsdb;
+ struct hdmi_vsdb *hdmi;
+
+--
+GitLab
+
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: igt-gpu-tools: fix buffer overflow
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
2022-10-06 18:27 ` [PR PATCH] [Updated] " oreo639
2022-10-06 18:44 ` oreo639
@ 2022-10-06 19:00 ` paper42
2022-10-06 19:01 ` [PR PATCH] [Updated] " oreo639
2022-10-06 19:13 ` [PR PATCH] [Merged]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-10-06 19:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39780#issuecomment-1270550954
Comment:
This looks like a functional change, so it should include a revbump.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] igt-gpu-tools: fix buffer overflow
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
` (2 preceding siblings ...)
2022-10-06 19:00 ` igt-gpu-tools: fix buffer overflow paper42
@ 2022-10-06 19:01 ` oreo639
2022-10-06 19:13 ` [PR PATCH] [Merged]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: oreo639 @ 2022-10-06 19:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages igt
https://github.com/void-linux/void-packages/pull/39780
igt-gpu-tools: fix buffer overflow
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39780.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-igt-39780.patch --]
[-- Type: text/x-diff, Size: 2852 bytes --]
From be423509617d7c54b9d15ac738b5375d3c0650a9 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Thu, 6 Oct 2022 11:44:47 -0700
Subject: [PATCH] igt-gpu-tools: fix buffer overflow
---
...t_edid-Allocate-raw-8-bytes-for-VSDB.patch | 42 +++++++++++++++++++
srcpkgs/igt-gpu-tools/template | 2 +-
2 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
diff --git a/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch b/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
new file mode 100644
index 000000000000..7cc9e289305c
--- /dev/null
+++ b/srcpkgs/igt-gpu-tools/patches/igt_edid-Allocate-raw-8-bytes-for-VSDB.patch
@@ -0,0 +1,42 @@
+From 2107b0a53692fb329175bc16169c3699712187aa Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sat, 27 Feb 2021 14:10:41 -0800
+Subject: [PATCH] lib/igt_edid: Allocate raw 8-bytes for VSDB
+
+hdmi_vsdb is an element of cea_vsdb which makes the size of cea_vsdb to
+be 8 ( 3bytes ieee_oui ) + ( 5bytes hdmi_vsdb struct), its true that we
+only use 7 bytes technically we can only allocate 7byte array but since
+we are writing to elements of hdmi_vsdb struct which is sitting at offet
+4-8 in cea_vsdb, compiler thinks we have an element which is out of
+array bounds since out allocated size is 7bytes
+
+This errors out
+../git/lib/igt_edid.c:365:13: error: array subscript 'struct hdmi_vsdb[0]' is partly outside array bounds of 'char[7]' [-Werror=array-bounds]
+ 365 | hdmi->src_phy_addr[0] = 0x10;
+ | ^~
+
+allocating one extra byte matches with size of cea_vsdb and compiler is
+happy
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Reviewed-by: Martin Peres <martin.peres@mupuf.org>
+---
+ lib/igt_edid.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/igt_edid.c b/lib/igt_edid.c
+index 1c85486d..ce09cc47 100644
+--- a/lib/igt_edid.c
++++ b/lib/igt_edid.c
+@@ -351,7 +351,7 @@ void cea_sad_init_pcm(struct cea_sad *sad, int channels,
+ const struct cea_vsdb *cea_vsdb_get_hdmi_default(size_t *size)
+ {
+ /* We'll generate a VSDB with 2 extension fields. */
+- static char raw[CEA_VSDB_HDMI_MIN_SIZE + 2] = {0};
++ static char raw[CEA_VSDB_HDMI_MIN_SIZE + 3] = {0};
+ struct cea_vsdb *vsdb;
+ struct hdmi_vsdb *hdmi;
+
+--
+GitLab
+
diff --git a/srcpkgs/igt-gpu-tools/template b/srcpkgs/igt-gpu-tools/template
index e5865e11a57f..02f6cc4bba66 100644
--- a/srcpkgs/igt-gpu-tools/template
+++ b/srcpkgs/igt-gpu-tools/template
@@ -1,7 +1,7 @@
# Template file for 'igt-gpu-tools'
pkgname=igt-gpu-tools
version=1.25
-revision=5
+revision=6
build_style=meson
configure_args="-Db_ndebug=false -Db_lto=false"
# b_lto=true makes the build hang at a random point
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: igt-gpu-tools: fix buffer overflow
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
` (3 preceding siblings ...)
2022-10-06 19:01 ` [PR PATCH] [Updated] " oreo639
@ 2022-10-06 19:13 ` paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-10-06 19:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
There's a merged pull request on the void-packages repository
igt-gpu-tools: fix buffer overflow
https://github.com/void-linux/void-packages/pull/39780
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-06 19:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 18:24 [PR PATCH] igt-gpu-tools: update to 1.26 oreo639
2022-10-06 18:27 ` [PR PATCH] [Updated] " oreo639
2022-10-06 18:44 ` oreo639
2022-10-06 19:00 ` igt-gpu-tools: fix buffer overflow paper42
2022-10-06 19:01 ` [PR PATCH] [Updated] " oreo639
2022-10-06 19:13 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).