* [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak
@ 2022-10-09 19:50 orowith2os
2022-10-09 19:59 ` Duncaen
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: orowith2os @ 2022-10-09 19:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
There is a new pull request by orowith2os against master on the void-packages repository
https://github.com/orowith2os/void-packages flatpak-dep-update
https://github.com/void-linux/void-packages/pull/39844
Adds xdg-desktop-portal as a dependency for flatpak
Flatpak relies on xdg-desktop-portal heavily, why it isn't a dependency is unknown to me.
Additionally, it would make sense to add xdg-desktop-portal-gtk as a dep, since that's needed for GTK theming and a native filepicker in the event there isn't another xdg-desktop-portal implementation that has one.
A patch file from https://github.com/void-linux/void-packages/pull/39844.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flatpak-dep-update-39844.patch --]
[-- Type: text/x-diff, Size: 1079 bytes --]
From 91244c9b7970dc7c73e6967b5839d7bab95df21f Mon Sep 17 00:00:00 2001
From: Oro <93224879+orowith2os@users.noreply.github.com>
Date: Sun, 9 Oct 2022 14:48:40 -0500
Subject: [PATCH] Adds xdg-desktop-portal as a dependency for flatpak
---
srcpkgs/flatpak/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/flatpak/template b/srcpkgs/flatpak/template
index e9fefbf33925..7c9718feefb4 100644
--- a/srcpkgs/flatpak/template
+++ b/srcpkgs/flatpak/template
@@ -16,7 +16,7 @@ hostmakedepends="bubblewrap gettext glib-devel libxslt pkg-config bison
makedepends="AppStream-devel libarchive-devel gpgme-devel json-glib-devel
libcap-devel libostree-devel libseccomp-devel polkit-devel dconf-devel
fuse3-devel libsoup-devel libcurl-devel gdk-pixbuf-devel"
-depends="bubblewrap gnupg2 xdg-dbus-proxy"
+depends="bubblewrap gnupg2 xdg-dbus-proxy xdg-desktop-portal"
checkdepends="attr-progs bubblewrap dbus gnupg2 socat which xdg-dbus-proxy"
short_desc="Application sandboxing and distribution framework"
maintainer="Duncaen <duncaen@voidlinux.org>"
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
@ 2022-10-09 19:59 ` Duncaen
2022-10-09 19:59 ` [PR PATCH] [Closed]: " Duncaen
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Duncaen @ 2022-10-09 19:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272616966
Comment:
This introduces a build cycle, `xdg-desktop-portal` needs `flatpak-devel` to build.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Closed]: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
2022-10-09 19:59 ` Duncaen
@ 2022-10-09 19:59 ` Duncaen
2022-10-09 20:02 ` orowith2os
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Duncaen @ 2022-10-09 19:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
There's a closed pull request on the void-packages repository
Adds xdg-desktop-portal as a dependency for flatpak
https://github.com/void-linux/void-packages/pull/39844
Description:
Flatpak relies on xdg-desktop-portal heavily, why it isn't a dependency is unknown to me.
Additionally, it would make sense to add xdg-desktop-portal-gtk as a dep, since that's needed for GTK theming and a native filepicker in the event there isn't another xdg-desktop-portal implementation that has one.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
2022-10-09 19:59 ` Duncaen
2022-10-09 19:59 ` [PR PATCH] [Closed]: " Duncaen
@ 2022-10-09 20:02 ` orowith2os
2022-10-09 20:08 ` oreo639
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: orowith2os @ 2022-10-09 20:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New comment by orowith2os on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272617527
Comment:
Would I need to resubmit this, but skip the CI build? I'm not quite sure on how void-packages works.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
` (2 preceding siblings ...)
2022-10-09 20:02 ` orowith2os
@ 2022-10-09 20:08 ` oreo639
2022-10-09 20:08 ` Duncaen
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: oreo639 @ 2022-10-09 20:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272618507
Comment:
> Would I need to resubmit this, but skip the CI build? I'm not quite sure on how void-packages works.
No. It means that if someone trys to fully build flatpak/xdg-desktop-portal from source without and existing version of those packages, the build will loop since one will require the other.
(`flatpak-devel` depends on `flatpak` which depends on `xdg-desktop-portal` which depends on `flatpak-devel` etc)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
` (3 preceding siblings ...)
2022-10-09 20:08 ` oreo639
@ 2022-10-09 20:08 ` Duncaen
2022-10-09 20:10 ` orowith2os
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Duncaen @ 2022-10-09 20:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272618578
Comment:
No the issue is that when we want to build `xdg-desktop-portal` and `flatpak` from source or update both at the same time, then there is no way to build them because the added dependency is cyclic.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
` (4 preceding siblings ...)
2022-10-09 20:08 ` Duncaen
@ 2022-10-09 20:10 ` orowith2os
2022-10-09 20:12 ` Duncaen
2022-10-09 20:14 ` orowith2os
7 siblings, 0 replies; 9+ messages in thread
From: orowith2os @ 2022-10-09 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New comment by orowith2os on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272618917
Comment:
Ah, that makes a lot more sense. I didn't really understand the original comment.
Is there a workaround for this, or is this going to be how it is for the foreseeable future?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
` (5 preceding siblings ...)
2022-10-09 20:10 ` orowith2os
@ 2022-10-09 20:12 ` Duncaen
2022-10-09 20:14 ` orowith2os
7 siblings, 0 replies; 9+ messages in thread
From: Duncaen @ 2022-10-09 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272619250
Comment:
Only workaround would be to create a second separate "bootstrap" package of flatpak without the dependency that is used to build `xdg-desktop-portal`, but I don't think its wroth the trouble.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Adds xdg-desktop-portal as a dependency for flatpak
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
` (6 preceding siblings ...)
2022-10-09 20:12 ` Duncaen
@ 2022-10-09 20:14 ` orowith2os
7 siblings, 0 replies; 9+ messages in thread
From: orowith2os @ 2022-10-09 20:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
New comment by orowith2os on void-packages repository
https://github.com/void-linux/void-packages/pull/39844#issuecomment-1272619428
Comment:
Alrighty. Would it be possible to add a comment to the build template so that anybody looking on this in the future doesn't go through the same process of getting denied?
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-10-09 20:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-09 19:50 [PR PATCH] Adds xdg-desktop-portal as a dependency for flatpak orowith2os
2022-10-09 19:59 ` Duncaen
2022-10-09 19:59 ` [PR PATCH] [Closed]: " Duncaen
2022-10-09 20:02 ` orowith2os
2022-10-09 20:08 ` oreo639
2022-10-09 20:08 ` Duncaen
2022-10-09 20:10 ` orowith2os
2022-10-09 20:12 ` Duncaen
2022-10-09 20:14 ` orowith2os
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).