* Re: [PR PATCH] [Updated] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
@ 2022-10-15 20:05 ` drichline
2022-10-15 21:09 ` [PR REVIEW] " classabbyamp
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: drichline @ 2022-10-15 20:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
There is an updated pull request by drichline against master on the void-packages repository
https://github.com/drichline/void-packages alass-branch
https://github.com/void-linux/void-packages/pull/39972
New package: alass-2.0.0
Closes #38965
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
- aarch64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/39972.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-alass-branch-39972.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]
From 9100037fcf9fff4385f2af188feb4faafdb4bacb Mon Sep 17 00:00:00 2001
From: Dakota Richline <43507179+drichline@users.noreply.github.com>
Date: Sat, 15 Oct 2022 15:33:48 -0400
Subject: [PATCH] New package: alass-2.0.0
---
srcpkgs/alass/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/alass/template
diff --git a/srcpkgs/alass/template b/srcpkgs/alass/template
new file mode 100644
index 000000000000..18940c3de4f6
--- /dev/null
+++ b/srcpkgs/alass/template
@@ -0,0 +1,21 @@
+# Template file for 'alass'
+pkgname=alass
+version=2.0.0
+revision=1
+build_style=cargo
+depends="ffmpeg"
+short_desc="Command line tool to synchronize subtitles to movies"
+maintainer="Dakota Richline <drichline@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/kaegi/alass"
+distfiles="https://github.com/kaegi/alass/archive/refs/tags/v${version}.tar.gz"
+checksum=ce88f92c7a427b623edcabb1b64e80be70cca2777f3da4b96702820a6cdf1e26
+
+do_install() {
+ vbin target/${RUST_TARGET}/release/alass-cli
+ vdoc README.md
+}
+
+if [ "$XBPS_TARGET_MACHINE" = "i686" ]; then
+ make_check=ci-skip # Tests fail to build on i686 container with error "ran out of registers during register allocation"
+fi
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
2022-10-15 20:05 ` [PR PATCH] [Updated] " drichline
@ 2022-10-15 21:09 ` classabbyamp
2022-10-15 21:09 ` classabbyamp
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-10-15 21:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r996354544
Comment:
```suggestion
post_install() {
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
2022-10-15 20:05 ` [PR PATCH] [Updated] " drichline
2022-10-15 21:09 ` [PR REVIEW] " classabbyamp
@ 2022-10-15 21:09 ` classabbyamp
2022-10-15 21:09 ` classabbyamp
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-10-15 21:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r996355070
Comment:
let's use a case statement here instead because, while we don't currently have i686-musl, we should still consider it
and also change the `ci-skip` to `no` because it fails locally too
```suggestion
case "$XBPS_TARGET_MACHINE" in
i686*)
make_check=no # Tests fail to build on i686 with error "ran out of registers during register allocation"
;;
esac
```
and, as a stylistic thing, let's put this before the functions and after the main variable block
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (2 preceding siblings ...)
2022-10-15 21:09 ` classabbyamp
@ 2022-10-15 21:09 ` classabbyamp
2022-10-17 15:49 ` drichline
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-10-15 21:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r996354516
Comment:
this will make it install properly
```suggestion
build_style=cargo
make_install_target="--path alass-cli"
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (3 preceding siblings ...)
2022-10-15 21:09 ` classabbyamp
@ 2022-10-17 15:49 ` drichline
2022-10-17 15:49 ` drichline
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: drichline @ 2022-10-17 15:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
New review comment by drichline on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r997235261
Comment:
Thanks again for the help!! With the new `make_install_target`, I'm still getting the same error "`found a virtual manifest at `/builddir/alass-2.0.0/Cargo.toml` instead of a package manifest`" as before. It seems like the path should be right, but this is my first time using cargo.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (4 preceding siblings ...)
2022-10-17 15:49 ` drichline
@ 2022-10-17 15:49 ` drichline
2022-10-17 15:50 ` drichline
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: drichline @ 2022-10-17 15:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
New review comment by drichline on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r997235261
Comment:
Thanks again for the help!! With the new `make_install_target`, I'm still getting the same error "`found a virtual manifest at /builddir/alass-2.0.0/Cargo.toml instead of a package manifest`" as before. It seems like the path should be right, but this is my first time using cargo.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (5 preceding siblings ...)
2022-10-17 15:49 ` drichline
@ 2022-10-17 15:50 ` drichline
2022-10-18 9:52 ` classabbyamp
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: drichline @ 2022-10-17 15:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
New review comment by drichline on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r997235261
Comment:
Thanks again for the help!! With the new `make_install_target`, I'm still getting the same error "`found a virtual manifest at /builddir/alass-2.0.0/Cargo.toml instead of a package manifest`" as before (even after an xbps-src clean). It seems like the path should be right, but this is my first time using cargo.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (6 preceding siblings ...)
2022-10-17 15:50 ` drichline
@ 2022-10-18 9:52 ` classabbyamp
2023-01-17 1:59 ` github-actions
2023-01-31 2:01 ` [PR PATCH] [Closed]: " github-actions
9 siblings, 0 replies; 11+ messages in thread
From: classabbyamp @ 2022-10-18 9:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#discussion_r997984706
Comment:
hm weird, it worked for me when I tried it locally
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (7 preceding siblings ...)
2022-10-18 9:52 ` classabbyamp
@ 2023-01-17 1:59 ` github-actions
2023-01-31 2:01 ` [PR PATCH] [Closed]: " github-actions
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2023-01-17 1:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/39972#issuecomment-1384741694
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Closed]: New package: alass-2.0.0
2022-10-15 19:34 [PR PATCH] New package: alass-2.0.0 drichline
` (8 preceding siblings ...)
2023-01-17 1:59 ` github-actions
@ 2023-01-31 2:01 ` github-actions
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2023-01-31 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
There's a closed pull request on the void-packages repository
New package: alass-2.0.0
https://github.com/void-linux/void-packages/pull/39972
Description:
Closes #38965
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
- aarch64-glibc
^ permalink raw reply [flat|nested] 11+ messages in thread