* [PR PATCH] miniflux: log stderr too
@ 2022-10-16 20:02 steinex
2022-10-16 20:19 ` [PR REVIEW] " paper42
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: steinex @ 2022-10-16 20:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
There is a new pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages miniflux
https://github.com/void-linux/void-packages/pull/39995
miniflux: log stderr too
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39995.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-miniflux-39995.patch --]
[-- Type: text/x-diff, Size: 1028 bytes --]
From 10064f138eb085987916762d52e92bdb68f4ff4d Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sun, 16 Oct 2022 21:59:42 +0200
Subject: [PATCH] miniflux: log stderr too
---
srcpkgs/miniflux/files/miniflux/run | 2 +-
srcpkgs/miniflux/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/miniflux/files/miniflux/run b/srcpkgs/miniflux/files/miniflux/run
index 61db0e0442a6..714286c00271 100644
--- a/srcpkgs/miniflux/files/miniflux/run
+++ b/srcpkgs/miniflux/files/miniflux/run
@@ -1,3 +1,3 @@
#!/bin/sh
[ -r conf ] && . ./conf
-exec chpst -u _miniflux miniflux.app
+exec chpst -u _miniflux miniflux.app 2>&1
diff --git a/srcpkgs/miniflux/template b/srcpkgs/miniflux/template
index 43c616ec284e..77f747c5f349 100644
--- a/srcpkgs/miniflux/template
+++ b/srcpkgs/miniflux/template
@@ -1,7 +1,7 @@
# Template file for 'miniflux'
pkgname=miniflux
version=2.0.38
-revision=1
+revision=2
wrksrc="v2-${version}"
build_style=go
go_import_path="miniflux.app"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR REVIEW] miniflux: log stderr too
2022-10-16 20:02 [PR PATCH] miniflux: log stderr too steinex
@ 2022-10-16 20:19 ` paper42
2022-10-16 20:22 ` [PR PATCH] [Updated] " steinex
2022-10-16 20:24 ` [PR PATCH] [Merged]: " paper42
2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2022-10-16 20:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/39995#discussion_r996489767
Comment:
we usually add `exec 2>&1` before the last exec line
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Updated] miniflux: log stderr too
2022-10-16 20:02 [PR PATCH] miniflux: log stderr too steinex
2022-10-16 20:19 ` [PR REVIEW] " paper42
@ 2022-10-16 20:22 ` steinex
2022-10-16 20:24 ` [PR PATCH] [Merged]: " paper42
2 siblings, 0 replies; 4+ messages in thread
From: steinex @ 2022-10-16 20:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
There is an updated pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages miniflux
https://github.com/void-linux/void-packages/pull/39995
miniflux: log stderr too
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39995.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-miniflux-39995.patch --]
[-- Type: text/x-diff, Size: 994 bytes --]
From ce6bcbd824ec66ba1eb8ece545d59cfd0351fbea Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sun, 16 Oct 2022 21:59:42 +0200
Subject: [PATCH] miniflux: log stderr too
---
srcpkgs/miniflux/files/miniflux/run | 1 +
srcpkgs/miniflux/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/miniflux/files/miniflux/run b/srcpkgs/miniflux/files/miniflux/run
index 61db0e0442a6..513bcac9a769 100644
--- a/srcpkgs/miniflux/files/miniflux/run
+++ b/srcpkgs/miniflux/files/miniflux/run
@@ -1,3 +1,4 @@
#!/bin/sh
[ -r conf ] && . ./conf
+exec 2>&1
exec chpst -u _miniflux miniflux.app
diff --git a/srcpkgs/miniflux/template b/srcpkgs/miniflux/template
index 43c616ec284e..77f747c5f349 100644
--- a/srcpkgs/miniflux/template
+++ b/srcpkgs/miniflux/template
@@ -1,7 +1,7 @@
# Template file for 'miniflux'
pkgname=miniflux
version=2.0.38
-revision=1
+revision=2
wrksrc="v2-${version}"
build_style=go
go_import_path="miniflux.app"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Merged]: miniflux: log stderr too
2022-10-16 20:02 [PR PATCH] miniflux: log stderr too steinex
2022-10-16 20:19 ` [PR REVIEW] " paper42
2022-10-16 20:22 ` [PR PATCH] [Updated] " steinex
@ 2022-10-16 20:24 ` paper42
2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2022-10-16 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
There's a merged pull request on the void-packages repository
miniflux: log stderr too
https://github.com/void-linux/void-packages/pull/39995
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-16 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-16 20:02 [PR PATCH] miniflux: log stderr too steinex
2022-10-16 20:19 ` [PR REVIEW] " paper42
2022-10-16 20:22 ` [PR PATCH] [Updated] " steinex
2022-10-16 20:24 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).