* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
@ 2022-10-20 0:34 ` classabbyamp
2022-10-20 7:10 ` JamiKettunen
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2022-10-20 0:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1284739054
Comment:
this all seems to be in the same repo. could it be split up with subpackages?
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
2022-10-20 0:34 ` New package: portablemc-3.1.1 classabbyamp
@ 2022-10-20 7:10 ` JamiKettunen
2022-10-20 7:13 ` JamiKettunen
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-20 7:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1285050110
Comment:
@classabbyamp Indeed, I was wondering the same thing too. There is https://github.com/mindstorm38/portablemc/blob/master/src/workspace.py which is mainly "intended for development" but maybe we could re-use it somehow as per https://github.com/mindstorm38/portablemc#setup-environment
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
2022-10-20 0:34 ` New package: portablemc-3.1.1 classabbyamp
2022-10-20 7:10 ` JamiKettunen
@ 2022-10-20 7:13 ` JamiKettunen
2022-10-20 7:14 ` JamiKettunen
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-20 7:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1285050110
Comment:
@classabbyamp Indeed, I was wondering the same thing too. There is https://github.com/mindstorm38/portablemc/blob/master/src/workspace.py which is mainly "intended for development" but maybe we could re-use it somehow as per https://github.com/mindstorm38/portablemc#setup-environment.
I'm mainly wondering how the version upgrades would work with the addon sub-packages then, PyPI cannot be used as a source as it's all just minified versions of the source for the specific addon.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (2 preceding siblings ...)
2022-10-20 7:13 ` JamiKettunen
@ 2022-10-20 7:14 ` JamiKettunen
2022-10-20 7:39 ` classabbyamp
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-20 7:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1285050110
Comment:
@classabbyamp Indeed, I was wondering the same thing too. There is https://github.com/mindstorm38/portablemc/blob/master/src/workspace.py which is mainly "intended for development" but maybe we could re-use it somehow as per https://github.com/mindstorm38/portablemc#setup-environment.
I'm mainly wondering how the version upgrades would work with the addon sub-packages then, PyPI cannot be used as a source as it's all just minified versions of the source for the specific addon and we definitely don't want a vendored-style `_archives_version=2.0.0` or whatever.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (3 preceding siblings ...)
2022-10-20 7:14 ` JamiKettunen
@ 2022-10-20 7:39 ` classabbyamp
2022-10-20 13:50 ` icp1994
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2022-10-20 7:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1285081334
Comment:
maybe @icp1994 has a suggestion? they do lots of python packaging
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (4 preceding siblings ...)
2022-10-20 7:39 ` classabbyamp
@ 2022-10-20 13:50 ` icp1994
2022-10-22 14:35 ` [PR PATCH] [Updated] " JamiKettunen
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: icp1994 @ 2022-10-20 13:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1285579420
Comment:
Looking at the add-ons, they seem to be developed and released independently of each other and the core. The upstream monorepo setup is likely just for convenience. So I'd say the add-ons are probably better off as separate packages rather than sub-packages.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (5 preceding siblings ...)
2022-10-20 13:50 ` icp1994
@ 2022-10-22 14:35 ` JamiKettunen
2022-10-22 14:39 ` JamiKettunen
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-22 14:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages portablemc
https://github.com/void-linux/void-packages/pull/40049
New package: portablemc-3.1.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40049.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-portablemc-40049.patch --]
[-- Type: text/x-diff, Size: 9841 bytes --]
From 00203638e00aa1d452caee47b27f5888e31add28 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:07:35 +0300
Subject: [PATCH 1/6] New package: portablemc-3.1.1
---
srcpkgs/portablemc/files/README.voidlinux | 21 +++++++++++++++++++++
srcpkgs/portablemc/template | 17 +++++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 srcpkgs/portablemc/files/README.voidlinux
create mode 100644 srcpkgs/portablemc/template
diff --git a/srcpkgs/portablemc/files/README.voidlinux b/srcpkgs/portablemc/files/README.voidlinux
new file mode 100644
index 000000000000..87960094849e
--- /dev/null
+++ b/srcpkgs/portablemc/files/README.voidlinux
@@ -0,0 +1,21 @@
+Void-specific instructions:
+============================
+
+By default (similar to the official launcher) PortableMC will download a
+public JVM build from Mojang servers; for example with openjdk17-jre installed
+you can use it with the following:
+
+ $ portablemc start --jvm /usr/lib/jvm/openjdk17/bin/java ...
+
+NOTE: On musl libc you will always have to provide your own JVM as well as
+use an older LWJGL 3.2.x release to launch modern (>=1.19) versions of the game:
+
+ $ portablemc start --lwjgl 3.2.3 ...
+
+Currently LWJGL 3.3.1 does not work due to weird behavior in how it's linked
+against glibc, causing a crash if attempted to be used.
+
+This package merely contains the bare minimum to use portablemc, check out the
+various add-ons packaged as well:
+
+ $ xbps-query -Rs portablemc
diff --git a/srcpkgs/portablemc/template b/srcpkgs/portablemc/template
new file mode 100644
index 000000000000..71235c31de55
--- /dev/null
+++ b/srcpkgs/portablemc/template
@@ -0,0 +1,17 @@
+# Template file for 'portablemc'
+pkgname=portablemc
+version=3.1.1
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="python3"
+short_desc="Easy-to-use Python CLI Minecraft launcher"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc"
+distfiles="${PYPI_SITE}/p/portablemc/portablemc-${version}.tar.gz"
+checksum=3ea5f66dc936d3aa6782d91a21b9f1e6cd66ef97ef8e7b8e3ded54224406b37a
+
+post_install() {
+ vdoc ${FILESDIR}/README.voidlinux
+}
From e3322e8c1912a66b7669a3d2c3d5ea0965107212 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:31:08 +0300
Subject: [PATCH 2/6] New package: portablemc-archives-2.0.0
---
srcpkgs/portablemc-archives/template | 13 +++++++++++++
srcpkgs/portablemc-archives/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-archives/template
create mode 100644 srcpkgs/portablemc-archives/update
diff --git a/srcpkgs/portablemc-archives/template b/srcpkgs/portablemc-archives/template
new file mode 100644
index 000000000000..4ed3d4591e6e
--- /dev/null
+++ b/srcpkgs/portablemc-archives/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-archives'
+pkgname=portablemc-archives
+version=2.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Archives add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/archives"
+distfiles="${PYPI_SITE}/p/portablemc-archives/portablemc-archives-${version}.tar.gz"
+checksum=62ea7b90a184e08711eff8ace54ba21f8e2860c16bdc8d6c8af64dd8620523b1
diff --git a/srcpkgs/portablemc-archives/update b/srcpkgs/portablemc-archives/update
new file mode 100644
index 000000000000..8fd45066ddb3
--- /dev/null
+++ b/srcpkgs/portablemc-archives/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-archives/"
From 6e5614f8c18e03f25894c2cf354e961050abc77f Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:31:35 +0300
Subject: [PATCH 3/6] New package: portablemc-console-2.0.0
---
srcpkgs/portablemc-console/template | 13 +++++++++++++
srcpkgs/portablemc-console/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-console/template
create mode 100644 srcpkgs/portablemc-console/update
diff --git a/srcpkgs/portablemc-console/template b/srcpkgs/portablemc-console/template
new file mode 100644
index 000000000000..cf30edacf0b2
--- /dev/null
+++ b/srcpkgs/portablemc-console/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-console'
+pkgname=portablemc-console
+version=2.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc python3-prompt_toolkit"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Console add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/console"
+distfiles="${PYPI_SITE}/p/portablemc-console/portablemc-console-${version}.tar.gz"
+checksum=5efe27db7f83767c1a751949719750970fae9eae0354b46c6af884de8a25889d
diff --git a/srcpkgs/portablemc-console/update b/srcpkgs/portablemc-console/update
new file mode 100644
index 000000000000..0f1e90e87166
--- /dev/null
+++ b/srcpkgs/portablemc-console/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-console/"
From a1188f2dfbe4e44d41b81e791a383759c28d3273 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:32:33 +0300
Subject: [PATCH 4/6] New package: portablemc-fabric-2.0.1
---
srcpkgs/portablemc-fabric/template | 13 +++++++++++++
srcpkgs/portablemc-fabric/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-fabric/template
create mode 100644 srcpkgs/portablemc-fabric/update
diff --git a/srcpkgs/portablemc-fabric/template b/srcpkgs/portablemc-fabric/template
new file mode 100644
index 000000000000..4e2cf0bc8ee2
--- /dev/null
+++ b/srcpkgs/portablemc-fabric/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-fabric'
+pkgname=portablemc-fabric
+version=2.0.1
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Fabric add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/fabric"
+distfiles="${PYPI_SITE}/p/portablemc-fabric/portablemc-fabric-${version}.tar.gz"
+checksum=5dbfd59f34dd7389dd6b03a09d1899f5eac0a7eb09f6dbb2a7b344389bc33c13
diff --git a/srcpkgs/portablemc-fabric/update b/srcpkgs/portablemc-fabric/update
new file mode 100644
index 000000000000..c50b8380fa0f
--- /dev/null
+++ b/srcpkgs/portablemc-fabric/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-fabric/"
From e311f2b0b2d7a66520860527a0e149a20f3eb5f4 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:34:13 +0300
Subject: [PATCH 5/6] New package: portablemc-forge-2.0.1
---
srcpkgs/portablemc-forge/template | 13 +++++++++++++
srcpkgs/portablemc-forge/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-forge/template
create mode 100644 srcpkgs/portablemc-forge/update
diff --git a/srcpkgs/portablemc-forge/template b/srcpkgs/portablemc-forge/template
new file mode 100644
index 000000000000..c811477133ea
--- /dev/null
+++ b/srcpkgs/portablemc-forge/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-forge'
+pkgname=portablemc-forge
+version=2.0.1
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Forge add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/forge"
+distfiles="${PYPI_SITE}/p/portablemc-forge/portablemc-forge-${version}.tar.gz"
+checksum=3c87bda4829ebc1e547873804408ff68670ede5bcea7a6a70860ff761e08724c
diff --git a/srcpkgs/portablemc-forge/update b/srcpkgs/portablemc-forge/update
new file mode 100644
index 000000000000..f15a516fee22
--- /dev/null
+++ b/srcpkgs/portablemc-forge/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-forge/"
From a222c1d397f94a50cb6553dbfaacae6606a06827 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:34:15 +0300
Subject: [PATCH 6/6] New package: portablemc-quilt-1.0.0
---
srcpkgs/portablemc-quilt/template | 13 +++++++++++++
srcpkgs/portablemc-quilt/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-quilt/template
create mode 100644 srcpkgs/portablemc-quilt/update
diff --git a/srcpkgs/portablemc-quilt/template b/srcpkgs/portablemc-quilt/template
new file mode 100644
index 000000000000..aab8372c974a
--- /dev/null
+++ b/srcpkgs/portablemc-quilt/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-quilt'
+pkgname=portablemc-quilt
+version=1.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Quilt add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/quilt"
+distfiles="${PYPI_SITE}/p/portablemc-quilt/portablemc-quilt-${version}.tar.gz"
+checksum=9eef98a3a953d9e367b26d8044b256ca722817104747469bbff2911d1d1b6466
diff --git a/srcpkgs/portablemc-quilt/update b/srcpkgs/portablemc-quilt/update
new file mode 100644
index 000000000000..5b3d1024f7da
--- /dev/null
+++ b/srcpkgs/portablemc-quilt/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-quilt/"
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (6 preceding siblings ...)
2022-10-22 14:35 ` [PR PATCH] [Updated] " JamiKettunen
@ 2022-10-22 14:39 ` JamiKettunen
2022-10-22 14:39 ` JamiKettunen
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-22 14:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1287812929
Comment:
I've dropped the `virtual?java-runtime` dependency of `portablemc` as it'll download Mojang provides JVM binaries by default which I've mentioned in the `README.voidlinux`. I've also filed https://github.com/mindstorm38/portablemc/issues/110 regarding the current behaviors under `musl` after testing under `x86_64-musl`.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (7 preceding siblings ...)
2022-10-22 14:39 ` JamiKettunen
@ 2022-10-22 14:39 ` JamiKettunen
2022-10-23 2:12 ` JamiKettunen
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-22 14:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1287812929
Comment:
I've dropped the `virtual?java-runtime` dependency of `portablemc` as it'll download Mojang provided JVM binaries by default which I've mentioned in the `README.voidlinux`. I've also filed https://github.com/mindstorm38/portablemc/issues/110 regarding the current behaviors under `musl` after testing under `x86_64-musl`.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (8 preceding siblings ...)
2022-10-22 14:39 ` JamiKettunen
@ 2022-10-23 2:12 ` JamiKettunen
2022-11-04 0:08 ` JamiKettunen
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-10-23 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1287812929
Comment:
I've dropped the `virtual?java-runtime` dependency of `portablemc` as it'll download Mojang provided JVM binaries by default which I've mentioned in the `README.voidlinux`. I've also filed https://github.com/mindstorm38/portablemc/issues/110 regarding the current behaviors under `musl` after testing under `x86_64-musl`.
Though now that I think about it perhaps it already makes sense to `depends+=" virtual?java-runtime"` on `musl` since it would be needed anyway.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (9 preceding siblings ...)
2022-10-23 2:12 ` JamiKettunen
@ 2022-11-04 0:08 ` JamiKettunen
2022-11-10 15:19 ` [PR PATCH] [Updated] " JamiKettunen
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-11-04 0:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1302809871
Comment:
Drafting until [version 3.2.0](https://github.com/mindstorm38/portablemc/pull/115) is released, it contains some improvements that make it trivial to start the game under `x86_64-musl` & `aarch64-musl` systems which I could test as well which I'll document the relevant pieces about in `README.voidlinux`.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] New package: portablemc-3.1.1
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (10 preceding siblings ...)
2022-11-04 0:08 ` JamiKettunen
@ 2022-11-10 15:19 ` JamiKettunen
2022-12-04 14:38 ` New package: portablemc-3.2.0 JamiKettunen
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-11-10 15:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages portablemc
https://github.com/void-linux/void-packages/pull/40049
New package: portablemc-3.1.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40049.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-portablemc-40049.patch --]
[-- Type: text/x-diff, Size: 10718 bytes --]
From cb7f98d149be1d170ef4c9fc963c4ece166d1b14 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:07:35 +0300
Subject: [PATCH 1/6] New package: portablemc-3.2.0
---
srcpkgs/portablemc/files/README.voidlinux | 38 +++++++++++++++++++++++
srcpkgs/portablemc/template | 22 +++++++++++++
2 files changed, 60 insertions(+)
create mode 100644 srcpkgs/portablemc/files/README.voidlinux
create mode 100644 srcpkgs/portablemc/template
diff --git a/srcpkgs/portablemc/files/README.voidlinux b/srcpkgs/portablemc/files/README.voidlinux
new file mode 100644
index 000000000000..7a41cb240e61
--- /dev/null
+++ b/srcpkgs/portablemc/files/README.voidlinux
@@ -0,0 +1,38 @@
+Void-specific instructions:
+============================
+
+By default (similar to the official launcher) PortableMC will download a
+public JVM build from Mojang servers; for example with openjdk17-jre installed
+you can use distro provided runtime with the following:
+
+ $ portablemc start --jvm /usr/lib/jvm/openjdk17/bin/java ...
+
+For Minecraft versions <=1.16 you'd want openjdk8-jre instead.
+
+NOTE: On musl libc you will always have to provide your own JVM (default to java
+from PATH) as well as use an older LWJGL 3.2.x release to launch modern (>=1.19)
+versions of the game:
+
+ $ portablemc start --lwjgl 3.2.3 ...
+
+Currently LWJGL 3.3.1 (or 3.3.0) does not work due to weird behavior in how it's
+linked against glibc, causing a native code crash if attempted to be used.
+
+Similar to above on aarch64-musl at least you also currently have to provide
+various natives from your host environment like so:
+
+ # xbps-install -S glfw libopenal
+ $ portablemc start --lwjgl 3.2.3 \
+ --exclude-lib lwjgl-glfw::natives --exclude-lib lwjgl-openal::natives \
+ --include-bin /lib/libglfw.so.3 --include-bin /lib/libopenal.so.1 ...
+
+More details on how this works: https://github.com/mindstorm38/portablemc#fix-unsupported-systems
+
+In case you have OpenGL or GLSL related issues please see the following:
+https://github.com/mindstorm38/portablemc#lwjgl-version-and-arm-support
+
+This package merely contains the bare minimum to use portablemc, check out the
+various add-ons packaged as well:
+
+ $ xbps-query -Rs portablemc
+
diff --git a/srcpkgs/portablemc/template b/srcpkgs/portablemc/template
new file mode 100644
index 000000000000..079782ffd188
--- /dev/null
+++ b/srcpkgs/portablemc/template
@@ -0,0 +1,22 @@
+# Template file for 'portablemc'
+pkgname=portablemc
+version=3.2.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="python3"
+short_desc="Easy-to-use Python CLI Minecraft launcher"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc"
+distfiles="${PYPI_SITE}/p/portablemc/portablemc-${version}.tar.gz"
+checksum=caab5075c136cc576c3c1b9d024bd2d29ca6d82aa01fb3272a8a7bc3c26c528f
+
+# Mojang only provides JRE linked against glibc
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+ depends+=" virtual?java-runtime"
+fi
+
+post_install() {
+ vdoc ${FILESDIR}/README.voidlinux
+}
From af246cf9f1e1b34d5c842b71f97f0f2ea5578d55 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:31:08 +0300
Subject: [PATCH 2/6] New package: portablemc-archives-2.0.0
---
srcpkgs/portablemc-archives/template | 13 +++++++++++++
srcpkgs/portablemc-archives/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-archives/template
create mode 100644 srcpkgs/portablemc-archives/update
diff --git a/srcpkgs/portablemc-archives/template b/srcpkgs/portablemc-archives/template
new file mode 100644
index 000000000000..4ed3d4591e6e
--- /dev/null
+++ b/srcpkgs/portablemc-archives/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-archives'
+pkgname=portablemc-archives
+version=2.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Archives add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/archives"
+distfiles="${PYPI_SITE}/p/portablemc-archives/portablemc-archives-${version}.tar.gz"
+checksum=62ea7b90a184e08711eff8ace54ba21f8e2860c16bdc8d6c8af64dd8620523b1
diff --git a/srcpkgs/portablemc-archives/update b/srcpkgs/portablemc-archives/update
new file mode 100644
index 000000000000..8fd45066ddb3
--- /dev/null
+++ b/srcpkgs/portablemc-archives/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-archives/"
From 392ccb5ff8a66f4682caf0b725c8d094a1540f61 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:31:35 +0300
Subject: [PATCH 3/6] New package: portablemc-console-2.0.0
---
srcpkgs/portablemc-console/template | 13 +++++++++++++
srcpkgs/portablemc-console/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-console/template
create mode 100644 srcpkgs/portablemc-console/update
diff --git a/srcpkgs/portablemc-console/template b/srcpkgs/portablemc-console/template
new file mode 100644
index 000000000000..cf30edacf0b2
--- /dev/null
+++ b/srcpkgs/portablemc-console/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-console'
+pkgname=portablemc-console
+version=2.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc python3-prompt_toolkit"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Console add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/console"
+distfiles="${PYPI_SITE}/p/portablemc-console/portablemc-console-${version}.tar.gz"
+checksum=5efe27db7f83767c1a751949719750970fae9eae0354b46c6af884de8a25889d
diff --git a/srcpkgs/portablemc-console/update b/srcpkgs/portablemc-console/update
new file mode 100644
index 000000000000..0f1e90e87166
--- /dev/null
+++ b/srcpkgs/portablemc-console/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-console/"
From 4b87e9cc0db9ae5a1509e98adc0130c21441a320 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:32:33 +0300
Subject: [PATCH 4/6] New package: portablemc-fabric-2.0.1
---
srcpkgs/portablemc-fabric/template | 13 +++++++++++++
srcpkgs/portablemc-fabric/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-fabric/template
create mode 100644 srcpkgs/portablemc-fabric/update
diff --git a/srcpkgs/portablemc-fabric/template b/srcpkgs/portablemc-fabric/template
new file mode 100644
index 000000000000..4e2cf0bc8ee2
--- /dev/null
+++ b/srcpkgs/portablemc-fabric/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-fabric'
+pkgname=portablemc-fabric
+version=2.0.1
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Fabric add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/fabric"
+distfiles="${PYPI_SITE}/p/portablemc-fabric/portablemc-fabric-${version}.tar.gz"
+checksum=5dbfd59f34dd7389dd6b03a09d1899f5eac0a7eb09f6dbb2a7b344389bc33c13
diff --git a/srcpkgs/portablemc-fabric/update b/srcpkgs/portablemc-fabric/update
new file mode 100644
index 000000000000..c50b8380fa0f
--- /dev/null
+++ b/srcpkgs/portablemc-fabric/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-fabric/"
From 7bc5fac78b4ceb06371a4ce3efa74aa4d8ae137c Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:34:13 +0300
Subject: [PATCH 5/6] New package: portablemc-forge-2.0.1
---
srcpkgs/portablemc-forge/template | 13 +++++++++++++
srcpkgs/portablemc-forge/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-forge/template
create mode 100644 srcpkgs/portablemc-forge/update
diff --git a/srcpkgs/portablemc-forge/template b/srcpkgs/portablemc-forge/template
new file mode 100644
index 000000000000..c811477133ea
--- /dev/null
+++ b/srcpkgs/portablemc-forge/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-forge'
+pkgname=portablemc-forge
+version=2.0.1
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Forge add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/forge"
+distfiles="${PYPI_SITE}/p/portablemc-forge/portablemc-forge-${version}.tar.gz"
+checksum=3c87bda4829ebc1e547873804408ff68670ede5bcea7a6a70860ff761e08724c
diff --git a/srcpkgs/portablemc-forge/update b/srcpkgs/portablemc-forge/update
new file mode 100644
index 000000000000..f15a516fee22
--- /dev/null
+++ b/srcpkgs/portablemc-forge/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-forge/"
From b95262e0876cf368c55374d6d009cbecf5091ac1 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Thu, 20 Oct 2022 00:34:15 +0300
Subject: [PATCH 6/6] New package: portablemc-quilt-1.0.0
---
srcpkgs/portablemc-quilt/template | 13 +++++++++++++
srcpkgs/portablemc-quilt/update | 1 +
2 files changed, 14 insertions(+)
create mode 100644 srcpkgs/portablemc-quilt/template
create mode 100644 srcpkgs/portablemc-quilt/update
diff --git a/srcpkgs/portablemc-quilt/template b/srcpkgs/portablemc-quilt/template
new file mode 100644
index 000000000000..aab8372c974a
--- /dev/null
+++ b/srcpkgs/portablemc-quilt/template
@@ -0,0 +1,13 @@
+# Template file for 'portablemc-quilt'
+pkgname=portablemc-quilt
+version=1.0.0
+revision=1
+build_style=python3-pep517
+hostmakedepends="python3-poetry-core"
+depends="portablemc"
+short_desc="Easy-to-use Python CLI Minecraft launcher - Quilt add-on"
+maintainer="Jami Kettunen <jami.kettunen@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://github.com/mindstorm38/portablemc/tree/master/src/quilt"
+distfiles="${PYPI_SITE}/p/portablemc-quilt/portablemc-quilt-${version}.tar.gz"
+checksum=9eef98a3a953d9e367b26d8044b256ca722817104747469bbff2911d1d1b6466
diff --git a/srcpkgs/portablemc-quilt/update b/srcpkgs/portablemc-quilt/update
new file mode 100644
index 000000000000..5b3d1024f7da
--- /dev/null
+++ b/srcpkgs/portablemc-quilt/update
@@ -0,0 +1 @@
+site="https://pypi.org/simple/portablemc-quilt/"
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.2.0
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (11 preceding siblings ...)
2022-11-10 15:19 ` [PR PATCH] [Updated] " JamiKettunen
@ 2022-12-04 14:38 ` JamiKettunen
2023-03-05 2:09 ` github-actions
2023-03-20 1:58 ` [PR PATCH] [Closed]: " github-actions
14 siblings, 0 replies; 16+ messages in thread
From: JamiKettunen @ 2022-12-04 14:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1336428571
Comment:
Drafting once more as Python 3.11 upgrade broke the `portablemc-console` add-on: https://github.com/mindstorm38/portablemc/issues/124
On another note I could exclude that package for now if someone wants to review this again and could merge it :)
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: New package: portablemc-3.2.0
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (12 preceding siblings ...)
2022-12-04 14:38 ` New package: portablemc-3.2.0 JamiKettunen
@ 2023-03-05 2:09 ` github-actions
2023-03-20 1:58 ` [PR PATCH] [Closed]: " github-actions
14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-03-05 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/40049#issuecomment-1454959897
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Closed]: New package: portablemc-3.2.0
2022-10-19 21:43 [PR PATCH] Portablemc JamiKettunen
` (13 preceding siblings ...)
2023-03-05 2:09 ` github-actions
@ 2023-03-20 1:58 ` github-actions
14 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2023-03-20 1:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]
There's a closed pull request on the void-packages repository
New package: portablemc-3.2.0
https://github.com/void-linux/void-packages/pull/40049
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 16+ messages in thread