[PR PATCH] pdf.js: update to 2.16.105, switch to legacy build

[PR PATCH] pdf.js: update to 2.16.105, switch to legacy build

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages pdf.js
https://github.com/void-linux/void-packages/pull/40078

pdf.js: update to 2.16.105, switch to legacy build
The legacy build fix the regression in #40061. I don't know whether there is a reason *not* to use the legacy build; if so, we'll need a separate package.

Closes #40061.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc: @heittpr 

A patch file from https://github.com/void-linux/void-packages/pull/40078.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pdf.js-40078.patch --]
[-- Type: text/x-diff, Size: 1243 bytes --]

From d5004627b373715b6a4945129045d21c2497fce6 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Thu, 20 Oct 2022 22:23:01 -0400
Subject: [PATCH] pdf.js: update to 2.16.105, switch to legacy build

Closes #40061.
---
 srcpkgs/pdf.js/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pdf.js/template b/srcpkgs/pdf.js/template
index 83449dc8ca07..0164d76b324c 100644
--- a/srcpkgs/pdf.js/template
+++ b/srcpkgs/pdf.js/template
@@ -1,15 +1,14 @@
 # Template file for 'pdf.js'
 pkgname=pdf.js
-reverts="2.16.105_1"
-version=2.14.305
+version=2.16.105
 revision=2
 create_wrksrc=yes
 short_desc="Portable Document Format (PDF) viewer built with HTML5"
 maintainer="Daniel Santana <daniel@santana.tech>"
 license="Apache-2.0"
 homepage="https://mozilla.github.io/pdf.js/"
-distfiles="https://github.com/mozilla/pdf.js/releases/download/v${version}/pdfjs-${version}-dist.zip"
-checksum=1929a00d26d7cd631033ab5a06dcd7d6c283b7d3b06c76083fb840bd1e014896
+distfiles="https://github.com/mozilla/pdf.js/releases/download/v${version}/pdfjs-${version}-legacy-dist.zip"
+checksum=4fce357e8c665a25d44498f466ad93829f672f782eb95d6db8f20ee479dd6af4
 
 do_install() {
 	vmkdir usr/share/$pkgname/

Re: pdf.js: update to 2.16.105, switch to legacy build

[heittpr]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by heittpr on void-packages repository

https://github.com/void-linux/void-packages/pull/40078#issuecomment-1286791711

Comment:
I don't know any reason to prefer the non-legacy build other than avoid polyfills ([relevant FAQ section](https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#which-browsersenvironments-are-supported)), maybe we could ask upstream? Also, https://github.com/mozilla/pdf.js/issues/14343#issuecomment-986064030 states there aren't any plans to remove the legacy build.

Re: pdf.js: update to 2.16.105, switch to legacy build

[heittpr]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New comment by heittpr on void-packages repository

https://github.com/void-linux/void-packages/pull/40078#issuecomment-1286791711

Comment:
I don't know any reason to prefer the non-legacy build other than avoiding polyfills ([relevant FAQ section](https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#which-browsersenvironments-are-supported)), maybe we could ask upstream? Also, https://github.com/mozilla/pdf.js/issues/14343#issuecomment-986064030 states there aren't any plans to remove the legacy build.

Re: [PR PATCH] [Merged]: pdf.js: update to 2.16.105, switch to legacy build

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

There's a merged pull request on the void-packages repository

pdf.js: update to 2.16.105, switch to legacy build
https://github.com/void-linux/void-packages/pull/40078

Description:
The legacy build fixes the regression in #40061. I don't know whether there is a reason *not* to use the legacy build; if so, we'll need a separate package.

Closes #40061.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc: @heittpr 

Re: pdf.js: update to 2.16.105, switch to legacy build

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/40078#issuecomment-1288270520

Comment:
The legacy build solves a known compatibility problem. Let's defer consideration of the non-legacy alternative until somebody needs it.