Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [NOMERGE] asunder: use gtk3 port
@ 2022-10-22 21:13 paper42
  2022-10-23 12:14 ` [PR REVIEW] " sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: paper42 @ 2022-10-22 21:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages asunder-gtk3
https://github.com/void-linux/void-packages/pull/40119

[NOMERGE] asunder: use gtk3 port
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

this should not be merged yet, they don't have a release and are discussing renaming the project: https://gitlab.gnome.org/Salamandar/asunder/-/issues/2

cc @Chocimier
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asunder-gtk3-40119.patch --]
[-- Type: text/x-diff, Size: 1570 bytes --]

From e82cc60a42b5158f2caecb6deec9e9f7cbfb56e1 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 22 Oct 2022 23:11:03 +0200
Subject: [PATCH] asunder: use gtk3 port

---
 srcpkgs/asunder/template | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/asunder/template b/srcpkgs/asunder/template
index b176114f1f49..40c9fd89565e 100644
--- a/srcpkgs/asunder/template
+++ b/srcpkgs/asunder/template
@@ -1,18 +1,16 @@
 # Template file for 'asunder'
 pkgname=asunder
 version=2.9.7
-revision=1
-build_style=gnu-configure
-hostmakedepends="intltool pkg-config"
-makedepends="gtk+-devel libcddb-devel"
+revision=2
+_commit=eab23fd4d989c1f08a08f386a71245521e230faa
+wrksrc="${pkgname}-${_commit}"
+build_style=meson
+hostmakedepends="gettext pkg-config"
+makedepends="gtk+3-devel libcddb-devel"
 depends="MonkeysAudio cdparanoia flac lame opus vorbis-tools wavpack"
 short_desc="Graphical Audio CD ripper and encoder"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later"
-homepage="http://littlesvr.ca/asunder/"
-distfiles="http://littlesvr.ca/asunder/releases/asunder-${version}.tar.bz2"
-checksum=c1c97cd34c04b8595e95df8a9a7dbc64a1e61f494b7a0cd2873802ad111874f4
-
-pre_build() {
-	vsed -i 's:cd syslogng && $(MAKE) install:true:' Makefile.in
-}
+homepage="https://gitlab.gnome.org/Salamandar/asunder/"
+distfiles="https://gitlab.gnome.org/Salamandar/asunder/-/archive/${_commit}/asunder-${_commit}.tar.gz"
+checksum=de10c881ec6e31abc19ca318eaac4fe38e0c4e5c197d06eccf0258875789ec65

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] [NOMERGE] asunder: use gtk3 port
  2022-10-22 21:13 [PR PATCH] [NOMERGE] asunder: use gtk3 port paper42
@ 2022-10-23 12:14 ` sgn
  2022-11-18 12:28 ` [PR PATCH] [Updated] " paper42
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2022-10-23 12:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/40119#discussion_r1002700556

Comment:
Please remove MonkeysAudio, it's non-distributable. #40123 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] [NOMERGE] asunder: use gtk3 port
  2022-10-22 21:13 [PR PATCH] [NOMERGE] asunder: use gtk3 port paper42
  2022-10-23 12:14 ` [PR REVIEW] " sgn
@ 2022-11-18 12:28 ` paper42
  2023-02-17  2:04 ` github-actions
  2024-04-01 19:32 ` biopsin
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-11-18 12:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages asunder-gtk3
https://github.com/void-linux/void-packages/pull/40119

[NOMERGE] asunder: use gtk3 port
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

this should not be merged yet, they don't have a release and are discussing renaming the project: https://gitlab.gnome.org/Salamandar/asunder/-/issues/2

cc @Hoshpak
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asunder-gtk3-40119.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 2570b1b1fc2a9668f01534eadfeaaa6d569b91e7 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 22 Oct 2022 23:11:03 +0200
Subject: [PATCH] asunder: use gtk3 port

---
 srcpkgs/asunder/template | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/asunder/template b/srcpkgs/asunder/template
index fac1dfecab3c..a20c6c7a01f6 100644
--- a/srcpkgs/asunder/template
+++ b/srcpkgs/asunder/template
@@ -1,18 +1,15 @@
 # Template file for 'asunder'
 pkgname=asunder
 version=2.9.7
-revision=2
-build_style=gnu-configure
-hostmakedepends="intltool pkg-config"
-makedepends="gtk+-devel libcddb-devel"
+revision=3
+_commit=eab23fd4d989c1f08a08f386a71245521e230faa
+build_style=meson
+hostmakedepends="gettext pkg-config"
+makedepends="gtk+3-devel libcddb-devel"
 depends="cdparanoia flac lame opus vorbis-tools wavpack"
 short_desc="Graphical Audio CD ripper and encoder"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later"
-homepage="http://littlesvr.ca/asunder/"
-distfiles="http://littlesvr.ca/asunder/releases/asunder-${version}.tar.bz2"
-checksum=c1c97cd34c04b8595e95df8a9a7dbc64a1e61f494b7a0cd2873802ad111874f4
-
-pre_build() {
-	vsed -i 's:cd syslogng && $(MAKE) install:true:' Makefile.in
-}
+homepage="https://gitlab.gnome.org/Salamandar/asunder/"
+distfiles="https://gitlab.gnome.org/Salamandar/asunder/-/archive/${_commit}/asunder-${_commit}.tar.gz"
+checksum=de10c881ec6e31abc19ca318eaac4fe38e0c4e5c197d06eccf0258875789ec65

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [NOMERGE] asunder: use gtk3 port
  2022-10-22 21:13 [PR PATCH] [NOMERGE] asunder: use gtk3 port paper42
  2022-10-23 12:14 ` [PR REVIEW] " sgn
  2022-11-18 12:28 ` [PR PATCH] [Updated] " paper42
@ 2023-02-17  2:04 ` github-actions
  2024-04-01 19:32 ` biopsin
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2023-02-17  2:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40119#issuecomment-1433992795

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [NOMERGE] asunder: use gtk3 port
  2022-10-22 21:13 [PR PATCH] [NOMERGE] asunder: use gtk3 port paper42
                   ` (2 preceding siblings ...)
  2023-02-17  2:04 ` github-actions
@ 2024-04-01 19:32 ` biopsin
  3 siblings, 0 replies; 5+ messages in thread
From: biopsin @ 2024-04-01 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/40119#issuecomment-2030419154

Comment:
@paper42 seems they change their name too
https://gitlab.gnome.org/Salamandar/GrimRipper/-/releases

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-01 19:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-22 21:13 [PR PATCH] [NOMERGE] asunder: use gtk3 port paper42
2022-10-23 12:14 ` [PR REVIEW] " sgn
2022-11-18 12:28 ` [PR PATCH] [Updated] " paper42
2023-02-17  2:04 ` github-actions
2024-04-01 19:32 ` biopsin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).