[PR PATCH] i3: update to 4.21.1

[PR PATCH] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

There is a new pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-i3
https://github.com/void-linux/void-packages/pull/40161

i3: update to 4.21.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)

A patch file from https://github.com/void-linux/void-packages/pull/40161.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-i3-40161.patch --]
[-- Type: text/x-diff, Size: 968 bytes --]

From a57da05bcfa16fdc6d309b714e975319ba472ab6 Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 25 Oct 2022 14:31:02 -0300
Subject: [PATCH] i3: update to 4.21.1

---
 srcpkgs/i3/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/i3/template b/srcpkgs/i3/template
index c91a0faea66b..f3292eef565b 100644
--- a/srcpkgs/i3/template
+++ b/srcpkgs/i3/template
@@ -1,6 +1,6 @@
 # Template file for 'i3'
 pkgname=i3
-version=4.21
+version=4.21.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config perl"
@@ -14,7 +14,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://i3wm.org/"
 distfiles="${homepage}/downloads/${pkgname}-${version}.tar.xz"
-checksum=8dc5205e0f3443d58661e30783521fd9c6d426d1e7f3667ab12f2ac1b2d32078
+checksum=edfd781285c654a05dc6db272ce0300c4428e6fbd875d99964e57de25b41bc1e
 
 do_check() {
 	: "Michael disables tests in Debian rules, too"

Re: [PR REVIEW] i3: update to 4.21.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005335597

Comment:
```suggestion
homepage="https://i3wm.org/"
changelog="https://i3wm.org/downloads/RELEASE-NOTES-${version}.txt"
```

Re: [PR REVIEW] i3: update to 4.21.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005335485

Comment:
```suggestion
distfiles="https://i3wm.org/downloads/i3-${version}.tar.xz"
```

Re: [PR REVIEW] i3: update to 4.21.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005596307

Comment:
make_check=no # comment

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005705121

Comment:
hi, can I know why use the literals instead of variables? just curious (as still in early stages on contributing to void) 

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005705121

Comment:
hi, can I know why use the literals instead of variables? just curious (as still in early stages on contributing to void) 

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005707276

Comment:
sorry, don't understand why add this, can you explain to me?

Re: [PR REVIEW] i3: update to 4.21.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005804353

Comment:
Replace the `do_check()` function with `make_check=no # comment`, it's shorter and the preferred way to skip tests nowadays.

Re: [PR REVIEW] i3: update to 4.21.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005807715

Comment:
$pkgname isn't really variable, it can easily change when the package is renamed and $homepage is annoying because people can not easily get to the downloads page by just clicking on the link and it gets in the way of grepping through templates without evaluating them. It's not wrong to use the variables, many maintainers just prefer to not use them.

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005922397

Comment:
cool, makes sense, will update this PR asap, thanks!

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1005924008

Comment:
perfect, thanks!

Re: [PR PATCH] [Updated] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-i3
https://github.com/void-linux/void-packages/pull/40161

i3: update to 4.21.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)

A patch file from https://github.com/void-linux/void-packages/pull/40161.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-i3-40161.patch --]
[-- Type: text/x-diff, Size: 1282 bytes --]

From ba6deaac12592bd728f7b68cf1aaa6aaca75f9c0 Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 25 Oct 2022 14:31:02 -0300
Subject: [PATCH] i3: update to 4.21.1

---
 srcpkgs/i3/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/i3/template b/srcpkgs/i3/template
index c91a0faea66b..510f341b16a5 100644
--- a/srcpkgs/i3/template
+++ b/srcpkgs/i3/template
@@ -1,6 +1,6 @@
 # Template file for 'i3'
 pkgname=i3
-version=4.21
+version=4.21.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config perl"
@@ -13,12 +13,11 @@ short_desc="Improved tiling window manager"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://i3wm.org/"
-distfiles="${homepage}/downloads/${pkgname}-${version}.tar.xz"
-checksum=8dc5205e0f3443d58661e30783521fd9c6d426d1e7f3667ab12f2ac1b2d32078
+changelog="https://i3wm.org/downloads/RELEASE-NOTES-${version}.txt"
+distfiles="https://i3wm.org/downloads/i3-${version}.tar.xz"
+checksum=edfd781285c654a05dc6db272ce0300c4428e6fbd875d99964e57de25b41bc1e
 
-do_check() {
-	: "Michael disables tests in Debian rules, too"
-}
+make_check=no # Michael disables tests in Debian rules, too
 post_install() {
 	vlicense LICENSE
 	vmkdir usr/share/man/man1

Re: [PR REVIEW] i3: update to 4.21.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1006039739

Comment:
one more style nitpick, move $make_check to the first main block (after checksum), it's a variable and we put most of the variables to that block. xlint only checks the first block, so it won't warn you about this.

Re: [PR REVIEW] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1006080607

Comment:
right, it makes sense to put in there :)

Re: i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1292483535

Comment:
general question: how can one adopt a package? (I'm interested on adopting this one and others in the future)

Re: [PR PATCH] [Updated] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-i3
https://github.com/void-linux/void-packages/pull/40161

i3: update to 4.21.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)

A patch file from https://github.com/void-linux/void-packages/pull/40161.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-i3-40161.patch --]
[-- Type: text/x-diff, Size: 1282 bytes --]

From b7b85cb1876c661e492cfa20a09782fa8566e1ef Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 25 Oct 2022 14:31:02 -0300
Subject: [PATCH] i3: update to 4.21.1

---
 srcpkgs/i3/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/i3/template b/srcpkgs/i3/template
index c91a0faea66b..c1e244f995af 100644
--- a/srcpkgs/i3/template
+++ b/srcpkgs/i3/template
@@ -1,6 +1,6 @@
 # Template file for 'i3'
 pkgname=i3
-version=4.21
+version=4.21.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config perl"
@@ -13,12 +13,11 @@ short_desc="Improved tiling window manager"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://i3wm.org/"
-distfiles="${homepage}/downloads/${pkgname}-${version}.tar.xz"
-checksum=8dc5205e0f3443d58661e30783521fd9c6d426d1e7f3667ab12f2ac1b2d32078
+changelog="https://i3wm.org/downloads/RELEASE-NOTES-${version}.txt"
+distfiles="https://i3wm.org/downloads/i3-${version}.tar.xz"
+checksum=edfd781285c654a05dc6db272ce0300c4428e6fbd875d99964e57de25b41bc1e
+make_check=no # Michael disables tests in Debian rules, too
 
-do_check() {
-	: "Michael disables tests in Debian rules, too"
-}
 post_install() {
 	vlicense LICENSE
 	vmkdir usr/share/man/man1

Re: i3: update to 4.21.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1292506187

Comment:
if it's orphaned, just put your `name <email@example.com>` in the maintainer field and mention it in your commit message

if it's not orphaned, adoption can still happen if the previous maintainer has been absent for a long while and/or you get their permission. (look at the commit history and git blame of the template for this)

Re: [PR PATCH] [Updated] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-i3
https://github.com/void-linux/void-packages/pull/40161

i3: update to 4.21.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)

A patch file from https://github.com/void-linux/void-packages/pull/40161.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-i3-40161.patch --]
[-- Type: text/x-diff, Size: 1478 bytes --]

From 9977d7b9220b6d85e12d9c1a9c6a0b0af6e5ff06 Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 25 Oct 2022 14:31:02 -0300
Subject: [PATCH] i3: update to 4.21.1, adopt

---
 srcpkgs/i3/template | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/i3/template b/srcpkgs/i3/template
index c91a0faea66b..6a00d484746a 100644
--- a/srcpkgs/i3/template
+++ b/srcpkgs/i3/template
@@ -1,6 +1,6 @@
 # Template file for 'i3'
 pkgname=i3
-version=4.21
+version=4.21.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config perl"
@@ -10,15 +10,14 @@ makedepends="pcre2-devel yajl-devel libxcb-devel libev-devel
  xcb-util-xrm-devel"
 conf_files="/etc/i3/config /etc/i3/config.keycodes"
 short_desc="Improved tiling window manager"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Rodrigo Oliveira <mdkcore@qtrnn.io>"
 license="BSD-3-Clause"
 homepage="https://i3wm.org/"
-distfiles="${homepage}/downloads/${pkgname}-${version}.tar.xz"
-checksum=8dc5205e0f3443d58661e30783521fd9c6d426d1e7f3667ab12f2ac1b2d32078
+changelog="https://i3wm.org/downloads/RELEASE-NOTES-${version}.txt"
+distfiles="https://i3wm.org/downloads/i3-${version}.tar.xz"
+checksum=edfd781285c654a05dc6db272ce0300c4428e6fbd875d99964e57de25b41bc1e
+make_check=no # Michael disables tests in Debian rules, too
 
-do_check() {
-	: "Michael disables tests in Debian rules, too"
-}
 post_install() {
 	vlicense LICENSE
 	vmkdir usr/share/man/man1

Re: i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1292555066

Comment:
done :)

> if it's orphaned, just put your `name <email@example.com>` in the maintainer field and mention it in your commit message
> 
> if it's not orphaned, adoption can still happen if the previous maintainer has been absent for a long while and/or you get their permission. (look at the commit history and git blame of the template for this)

Re: [PR REVIEW] i3: update to 4.21.1

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1006830227

Comment:
```suggestion
	vmkdir usr/share/man/man1
```

Re: [PR REVIEW] i3: update to 4.21.1

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#discussion_r1006830227

Comment:
```suggestion
	vmkdir usr/share/man/man1
```

Re: i3: update to 4.21.1

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1293506478

Comment:
I've successful tested the PKG also on my machine (x86_64).

When suggested change is made the PKG is good to go. :+1:

Re: i3: update to 4.21.1

[dataCobra]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by dataCobra on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1293506478

Comment:
I've successful tested the PKG also on my machine (x86_64).

When the suggested change is made the PKG is good to go. :+1:

Re: [PR PATCH] [Updated] i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

There is an updated pull request by mdkcore0 against master on the void-packages repository

https://github.com/mdkcore0/void-packages update-i3
https://github.com/void-linux/void-packages/pull/40161

i3: update to 4.21.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)

A patch file from https://github.com/void-linux/void-packages/pull/40161.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-i3-40161.patch --]
[-- Type: text/x-diff, Size: 1561 bytes --]

From 71ec79acde57b41eb25e8c62cd57eb3e017b854c Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 25 Oct 2022 14:31:02 -0300
Subject: [PATCH] i3: update to 4.21.1, adopt

---
 srcpkgs/i3/template | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/i3/template b/srcpkgs/i3/template
index c91a0faea66b..74a8ac62743d 100644
--- a/srcpkgs/i3/template
+++ b/srcpkgs/i3/template
@@ -1,6 +1,6 @@
 # Template file for 'i3'
 pkgname=i3
-version=4.21
+version=4.21.1
 revision=1
 build_style=meson
 hostmakedepends="pkg-config perl"
@@ -10,19 +10,16 @@ makedepends="pcre2-devel yajl-devel libxcb-devel libev-devel
  xcb-util-xrm-devel"
 conf_files="/etc/i3/config /etc/i3/config.keycodes"
 short_desc="Improved tiling window manager"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Rodrigo Oliveira <mdkcore@qtrnn.io>"
 license="BSD-3-Clause"
 homepage="https://i3wm.org/"
-distfiles="${homepage}/downloads/${pkgname}-${version}.tar.xz"
-checksum=8dc5205e0f3443d58661e30783521fd9c6d426d1e7f3667ab12f2ac1b2d32078
+changelog="https://i3wm.org/downloads/RELEASE-NOTES-${version}.txt"
+distfiles="https://i3wm.org/downloads/i3-${version}.tar.xz"
+checksum=edfd781285c654a05dc6db272ce0300c4428e6fbd875d99964e57de25b41bc1e
+make_check=no # Michael disables tests in Debian rules, too
 
-do_check() {
-	: "Michael disables tests in Debian rules, too"
-}
 post_install() {
 	vlicense LICENSE
-	vmkdir usr/share/man/man1
-	install -m644 man/*.1 ${DESTDIR}/usr/share/man/man1
 }
 
 i3-devel_package() {

Re: i3: update to 4.21.1

[mdkcore0]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by mdkcore0 on void-packages repository

https://github.com/void-linux/void-packages/pull/40161#issuecomment-1293619077

Comment:
> I've successful tested the PKG also on my machine (x86_64).
> 
> When the suggested change is made the PKG is good to go. +1

done :)

Re: [PR PATCH] [Merged]: i3: update to 4.21.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

There's a merged pull request on the void-packages repository

i3: update to 4.21.1
https://github.com/void-linux/void-packages/pull/40161

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l (crossbuild)
  - i686-libc (crossbuild)