Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] google-chrome: don't depend on qt5-{core,gui,widgets}
@ 2022-10-31  9:18 mvf
  2022-10-31  9:26 ` atk
  2022-10-31 12:30 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 2 replies; 3+ messages in thread
From: mvf @ 2022-10-31  9:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2116 bytes --]

There is a new pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/google-chrome
https://github.com/void-linux/void-packages/pull/40239

google-chrome: don't depend on qt5-{core,gui,widgets}
#### Testing the changes
- I tested the changes in this PR: **YES** (on a machine without any `qt5*` packages)

---

This disables rdep scanning for `libqt5_shim.so`, as does upstream:

https://chromium.googlesource.com/chromium/src/+/8fcee9b26219683fb20bc51826629cac2e3584a0%5E%21/#F0

Otherwise it pulls in `qt5-widgets`, etc.:

```
# xbps-install -R . google-chrome

Name                Action    Version           New version            Download size
double-conversion   install   -                 3.1.5_1                29KB
qt5-core            install   -                 5.15.5+20220728_1      2408KB
libevdev            install   -                 1.12.0_1               38KB
libwacom            install   -                 1.12_1                 92KB
mtdev               install   -                 1.1.6_1                12KB
libinput            install   -                 1.21.0_1               253KB
libxkbcommon-x11    install   -                 1.4.1_1                13KB
qt5-dbus            install   -                 5.15.5+20220728_1      194KB
qt5-network         install   -                 5.15.5+20220728_1      692KB
tslib               install   -                 1.22_1                 50KB
xcb-util-image      install   -                 0.4.0_3                9436B
xcb-util-renderutil install   -                 0.3.9_3                7632B
qt5-gui             install   -                 5.15.5+20220728_1      3935KB
qt5-widgets         install   -                 5.15.5+20220728_1      2587KB
google-chrome       update    106.0.5249.119_1  107.0.5304.87_1        -

Size to download:               10MB
Size required on disk:         321MB
Space available on disk:       112GB
```

Maintainer ping: @atk

A patch file from https://github.com/void-linux/void-packages/pull/40239.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/google-chrome-40239.patch --]
[-- Type: text/x-diff, Size: 1034 bytes --]

From 8b0ae92f0d8138d2ccac8fbf527ba43035da8af1 Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 31 Oct 2022 09:26:46 +0100
Subject: [PATCH] google-chrome: don't depend on qt5-{core,gui,widgets}

---
 srcpkgs/google-chrome/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 752a86704109..70d751f4f122 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,7 +1,7 @@
 # Template file for 'google-chrome'
 pkgname=google-chrome
 version=107.0.5304.87
-revision=1
+revision=2
 _channel=stable
 archs="x86_64"
 hostmakedepends="tar xz python3 python3-html2text python3-setuptools"
@@ -13,6 +13,7 @@ homepage="https://www.google.com/chrome/"
 nostrip=yes
 restricted=yes
 repository=nonfree
+skiprdeps="/opt/google/chrome/libqt5_shim.so"
 
 _baseUrl="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable"
 _filename="google-chrome-${_channel}_${version}-1_amd64.deb"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: google-chrome: don't depend on qt5-{core,gui,widgets}
  2022-10-31  9:18 [PR PATCH] google-chrome: don't depend on qt5-{core,gui,widgets} mvf
@ 2022-10-31  9:26 ` atk
  2022-10-31 12:30 ` [PR PATCH] [Merged]: " sgn
  1 sibling, 0 replies; 3+ messages in thread
From: atk @ 2022-10-31  9:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/40239#issuecomment-1296820608

Comment:
Looks good to me. 👍

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: google-chrome: don't depend on qt5-{core,gui,widgets}
  2022-10-31  9:18 [PR PATCH] google-chrome: don't depend on qt5-{core,gui,widgets} mvf
  2022-10-31  9:26 ` atk
@ 2022-10-31 12:30 ` sgn
  1 sibling, 0 replies; 3+ messages in thread
From: sgn @ 2022-10-31 12:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]

There's a merged pull request on the void-packages repository

google-chrome: don't depend on qt5-{core,gui,widgets}
https://github.com/void-linux/void-packages/pull/40239

Description:
#### Testing the changes
- I tested the changes in this PR: **YES** (on a machine without any `qt5*` packages)

---

This disables rdep scanning for `libqt5_shim.so`, as does upstream:

https://chromium.googlesource.com/chromium/src/+/8fcee9b26219683fb20bc51826629cac2e3584a0%5E%21/#F0

Otherwise it pulls in `qt5-widgets`, etc.:

```
# xbps-install -R . google-chrome

Name                Action    Version           New version            Download size
double-conversion   install   -                 3.1.5_1                29KB
qt5-core            install   -                 5.15.5+20220728_1      2408KB
libevdev            install   -                 1.12.0_1               38KB
libwacom            install   -                 1.12_1                 92KB
mtdev               install   -                 1.1.6_1                12KB
libinput            install   -                 1.21.0_1               253KB
libxkbcommon-x11    install   -                 1.4.1_1                13KB
qt5-dbus            install   -                 5.15.5+20220728_1      194KB
qt5-network         install   -                 5.15.5+20220728_1      692KB
tslib               install   -                 1.22_1                 50KB
xcb-util-image      install   -                 0.4.0_3                9436B
xcb-util-renderutil install   -                 0.3.9_3                7632B
qt5-gui             install   -                 5.15.5+20220728_1      3935KB
qt5-widgets         install   -                 5.15.5+20220728_1      2587KB
google-chrome       update    106.0.5249.119_1  107.0.5304.87_1        -

Size to download:               10MB
Size required on disk:         321MB
Space available on disk:       112GB
```

Maintainer ping: @atk

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-31 12:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31  9:18 [PR PATCH] google-chrome: don't depend on qt5-{core,gui,widgets} mvf
2022-10-31  9:26 ` atk
2022-10-31 12:30 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).