Re: electron19: update to 19.1.3.

Re: electron19: update to 19.1.3.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299274480

Comment:
is it possible to move this to py3?

Re: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299286410

Comment:
Should be some easy fixes hopefully, but `s/python2/python3/` is not enough.

Re: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299305838

Comment:
The fix was a bit more trivial than expected. Just one `iteritems` -> `items` in a script that probably nobody except us even uses.

Re: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299305838

Comment:
The fix was a bit more trivial than expected. Just one `iteritems` -> `items` in a script that probably nobody except us even uses.

Re: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299308694

Comment:
Wondering if I should probably start maintainging the patches outside of void-packages, or just fetch a pre patched tarball, `electron19` dir is currently 35MB

Re: electron19: update to 19.1.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299318997

Comment:
electron19 in the current version doesn't build with gcc 12: https://github.com/void-linux/void-packages/issues/39809, [log](https://vasilek.cz/logs/gcc12-musl/bad/electron19.txt), I will be able to check this version tomorrow, could we wait for that before merging this update?

Re: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1299431562

Comment:
https://github.com/archlinux/svntogit-community/blob/packages/electron19/trunk/iwyu-add-utility-for-std-exchange.patch

Just a missing header, can add the patch tomorrow.

Re: electron19: update to 19.1.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1319894671

Comment:
the current version and this update now fail to build with Python 3.11:
```
=> electron19-19.1.3_1: running do_configure ...
Please use python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
Node.js configure: Found Python 3.11.0...
=> ERROR: electron19-19.1.3_1: do_configure: './configure --prefix=/usr --shared-zlib --shared-libuv --shared-openssl --shared-cares --openssl-use-def-ca-store --without-npm --without-dtrace --without-bundled-v8 ${conf_args}' exited with 1
=> ERROR:   in do_configure() at srcpkgs/electron19/template:281
```

Re: electron19: update to 19.1.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1319902470

Comment:
It's from nodejs and not fixed in any 16 release, this commit fixes it https://github.com/nodejs/node/commit/cf748ad2b7f760e2df1bc8a811f887161b892534

Re: electron19: update to 19.1.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1370968287

Comment:
python 3.11 and gcc 12 failures are now fixed, but they are just vseds in the template, so if they are still required with this update, they should probably be converted to proper patches

Re: electron19: update to 19.1.3.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40281#issuecomment-1496809718

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: electron19: update to 19.1.3.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There's a closed pull request on the void-packages repository

electron19: update to 19.1.3.
https://github.com/void-linux/void-packages/pull/40281

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->