* [PR PATCH] Package lib3mf
@ 2022-11-02 22:13 enderger
2022-11-02 22:49 ` enderger
` (24 more replies)
0 siblings, 25 replies; 26+ messages in thread
From: enderger @ 2022-11-02 22:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
There is a new pull request by enderger against master on the void-packages repository
https://github.com/enderger/void-packages pkg/pkg-lib3mf
https://github.com/void-linux/void-packages/pull/40307
Package lib3mf
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40307.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/pkg-lib3mf-40307.patch --]
[-- Type: text/x-diff, Size: 3836 bytes --]
From 561a7bbae0ebd35a1f7457498047f6ef60ebb88a Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:07:59 -0700
Subject: [PATCH 1/2] New package: lib3mf-2.2.0
---
common/shlibs | 1 +
srcpkgs/lib3mf-devel | 1 +
srcpkgs/lib3mf/template | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+)
create mode 120000 srcpkgs/lib3mf-devel
create mode 100644 srcpkgs/lib3mf/template
diff --git a/common/shlibs b/common/shlibs
index e48e6f352375..d56df6a68066 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4196,3 +4196,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+lib3mf.so.2 lib3mf-2.2.0_1
diff --git a/srcpkgs/lib3mf-devel b/srcpkgs/lib3mf-devel
new file mode 120000
index 000000000000..9352a6a9f9c8
--- /dev/null
+++ b/srcpkgs/lib3mf-devel
@@ -0,0 +1 @@
+lib3mf
\ No newline at end of file
diff --git a/srcpkgs/lib3mf/template b/srcpkgs/lib3mf/template
new file mode 100644
index 000000000000..65badd22a1ba
--- /dev/null
+++ b/srcpkgs/lib3mf/template
@@ -0,0 +1,36 @@
+# Template file for 'lib3mf'
+shopt -s extglob
+
+pkgname=lib3mf
+version=2.2.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_INCLUDED_LIBZIP=OFF -DUSE_INCLUDED_ZLIB=OFF
+ -DUSE_INCLUDED_GTEST=OFF -DUSE_INCLUDED_SSL=OFF
+ -DCMAKE_INSTALL_INCLUDEDIR='include/$pkgname' -DCMAKE_INSTALL_PREFIX=/usr
+ $([ "$XBPS_CHECK_PKGS" ] || echo '-DLIB3MF_TESTS=OFF')"
+hostmakedepends="pkg-config"
+makedepends="zlib-devel libzip-devel"
+checkdepends="gtest-devel openssl-devel"
+short_desc="Official 3mf format implementation"
+maintainer="Danielle Hutzley <endergeryt@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://3mf.io"
+distfiles="https://github.com/3MFConsortium/lib3mf/archive/refs/tags/v${version}.tar.gz"
+checksum=96e85e278fc5474123e3c47237dd42faaf1fdf8e182541a84af7fe84ddd3cbde
+
+post_install() {
+ vdoc README.md
+ vlicense LICENSE
+}
+
+lib3mf-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision} $makedepends"
+ short_desc+=" - development files"
+ pkg_install() {
+ ln -rst "$DESTDIR/usr/include/lib3mf" "$DESTDIR"/usr/include/lib3mf/Bindings/C?(pp)/*
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
From 0c13bf63e20c746e41d57e893bd62512153a7179 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:14:19 -0700
Subject: [PATCH 2/2] openscad: support 3mf
---
srcpkgs/openscad/template | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/openscad/template b/srcpkgs/openscad/template
index a3951a1a2201..2aa1b58a9d71 100644
--- a/srcpkgs/openscad/template
+++ b/srcpkgs/openscad/template
@@ -1,14 +1,25 @@
# Template file for 'openscad'
pkgname=openscad
version=2021.01
-revision=3
+revision=4
build_style=qmake
hostmakedepends="bison flex pkg-config gettext qt5-qmake qt5-host-tools"
makedepends="cgal-devel harfbuzz-devel opencsg-devel qscintilla-qt5-devel
- qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel"
+ qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel
+ $(vopt_if 3mf lib3mf-devel)"
short_desc="Solid 3D CAD modeller"
maintainer="Pierre Allegraud <pierre.allegraud@crans.org>"
license="GPL-2.0-or-later"
homepage="http://www.openscad.org"
distfiles="http://files.openscad.org/${pkgname}-${version}.src.tar.gz"
checksum=d938c297e7e5f65dbab1461cac472fc60dfeaa4999ea2c19b31a4184f2d70359
+
+pre_patch() {
+ if [ "$build_option_3mf" ]; then
+ vsed -i features/lib3mf.prf -e "s/lib3MF/lib3mf/g"
+ fi
+}
+
+build_options="3mf"
+desc_option_png="Enable support for 3MF models"
+build_options_default="3mf"
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
@ 2022-11-02 22:49 ` enderger
2022-11-02 22:59 ` [PR REVIEW] " paper42
` (23 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 22:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1301463562
Comment:
Should be ready to merge, I just used the OpenSCAD build to successfully compile a decently complicated design into 3mf.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
2022-11-02 22:49 ` enderger
@ 2022-11-02 22:59 ` paper42
2022-11-02 23:10 ` [PR PATCH] [Updated] " enderger
` (22 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-11-02 22:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012365377
Comment:
I think this can cause problems when xbps-src sources multiple templates
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR PATCH] [Updated] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
2022-11-02 22:49 ` enderger
2022-11-02 22:59 ` [PR REVIEW] " paper42
@ 2022-11-02 23:10 ` enderger
2022-11-02 23:10 ` [PR REVIEW] " enderger
` (21 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
There is an updated pull request by enderger against master on the void-packages repository
https://github.com/enderger/void-packages pkg/pkg-lib3mf
https://github.com/void-linux/void-packages/pull/40307
Package lib3mf
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40307.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/pkg-lib3mf-40307.patch --]
[-- Type: text/x-diff, Size: 3855 bytes --]
From bdcfac9dd3df27fb12278ba41abf22a54673b3ad Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:07:59 -0700
Subject: [PATCH 1/2] New package: lib3mf-2.2.0
---
common/shlibs | 1 +
srcpkgs/lib3mf-devel | 1 +
srcpkgs/lib3mf/template | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+)
create mode 120000 srcpkgs/lib3mf-devel
create mode 100644 srcpkgs/lib3mf/template
diff --git a/common/shlibs b/common/shlibs
index e48e6f352375..d56df6a68066 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4196,3 +4196,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+lib3mf.so.2 lib3mf-2.2.0_1
diff --git a/srcpkgs/lib3mf-devel b/srcpkgs/lib3mf-devel
new file mode 120000
index 000000000000..9352a6a9f9c8
--- /dev/null
+++ b/srcpkgs/lib3mf-devel
@@ -0,0 +1 @@
+lib3mf
\ No newline at end of file
diff --git a/srcpkgs/lib3mf/template b/srcpkgs/lib3mf/template
new file mode 100644
index 000000000000..371d99dcf332
--- /dev/null
+++ b/srcpkgs/lib3mf/template
@@ -0,0 +1,36 @@
+# Template file for 'lib3mf'
+pkgname=lib3mf
+version=2.2.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_INCLUDED_LIBZIP=OFF -DUSE_INCLUDED_ZLIB=OFF
+ -DUSE_INCLUDED_GTEST=OFF -DUSE_INCLUDED_SSL=OFF
+ -DCMAKE_INSTALL_INCLUDEDIR='include/$pkgname' -DCMAKE_INSTALL_PREFIX=/usr
+ $([ "$XBPS_CHECK_PKGS" ] || echo '-DLIB3MF_TESTS=OFF')"
+hostmakedepends="pkg-config"
+makedepends="zlib-devel libzip-devel"
+checkdepends="gtest-devel openssl-devel"
+short_desc="Official 3mf format implementation"
+maintainer="Danielle Hutzley <endergeryt@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://3mf.io"
+distfiles="https://github.com/3MFConsortium/lib3mf/archive/refs/tags/v${version}.tar.gz"
+checksum=96e85e278fc5474123e3c47237dd42faaf1fdf8e182541a84af7fe84ddd3cbde
+
+post_install() {
+ vdoc README.md
+ vlicense LICENSE
+}
+
+lib3mf-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision} $makedepends"
+ short_desc+=" - development files"
+ pkg_install() {
+ INCDIR="$DESTDIR/usr/include/lib3mf/"
+ BINDDIR="$INCDIR/Bindings"
+ ln -rst "$INCDIR" "$BINDDIR"/C/* "$BINDDIR"/Cpp/*
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
From ecef56bdab639d732eed3e040a50cd639f6edde8 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:14:19 -0700
Subject: [PATCH 2/2] openscad: support 3mf
---
srcpkgs/openscad/template | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/openscad/template b/srcpkgs/openscad/template
index a3951a1a2201..2aa1b58a9d71 100644
--- a/srcpkgs/openscad/template
+++ b/srcpkgs/openscad/template
@@ -1,14 +1,25 @@
# Template file for 'openscad'
pkgname=openscad
version=2021.01
-revision=3
+revision=4
build_style=qmake
hostmakedepends="bison flex pkg-config gettext qt5-qmake qt5-host-tools"
makedepends="cgal-devel harfbuzz-devel opencsg-devel qscintilla-qt5-devel
- qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel"
+ qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel
+ $(vopt_if 3mf lib3mf-devel)"
short_desc="Solid 3D CAD modeller"
maintainer="Pierre Allegraud <pierre.allegraud@crans.org>"
license="GPL-2.0-or-later"
homepage="http://www.openscad.org"
distfiles="http://files.openscad.org/${pkgname}-${version}.src.tar.gz"
checksum=d938c297e7e5f65dbab1461cac472fc60dfeaa4999ea2c19b31a4184f2d70359
+
+pre_patch() {
+ if [ "$build_option_3mf" ]; then
+ vsed -i features/lib3mf.prf -e "s/lib3MF/lib3mf/g"
+ fi
+}
+
+build_options="3mf"
+desc_option_png="Enable support for 3MF models"
+build_options_default="3mf"
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (2 preceding siblings ...)
2022-11-02 23:10 ` [PR PATCH] [Updated] " enderger
@ 2022-11-02 23:10 ` enderger
2022-11-02 23:15 ` [PR PATCH] [Updated] " enderger
` (20 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012371739
Comment:
Alright, switched to environment variables
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR PATCH] [Updated] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (3 preceding siblings ...)
2022-11-02 23:10 ` [PR REVIEW] " enderger
@ 2022-11-02 23:15 ` enderger
2022-11-02 23:17 ` enderger
` (19 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
There is an updated pull request by enderger against master on the void-packages repository
https://github.com/enderger/void-packages pkg/pkg-lib3mf
https://github.com/void-linux/void-packages/pull/40307
Package lib3mf
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40307.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/pkg-lib3mf-40307.patch --]
[-- Type: text/x-diff, Size: 3851 bytes --]
From 86d4fb681aa8736d820cc5331579de34b05ceb5e Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:07:59 -0700
Subject: [PATCH 1/2] New package: lib3mf-2.2.0
---
common/shlibs | 1 +
srcpkgs/lib3mf-devel | 1 +
srcpkgs/lib3mf/template | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+)
create mode 120000 srcpkgs/lib3mf-devel
create mode 100644 srcpkgs/lib3mf/template
diff --git a/common/shlibs b/common/shlibs
index e48e6f352375..d56df6a68066 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4196,3 +4196,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+lib3mf.so.2 lib3mf-2.2.0_1
diff --git a/srcpkgs/lib3mf-devel b/srcpkgs/lib3mf-devel
new file mode 120000
index 000000000000..9352a6a9f9c8
--- /dev/null
+++ b/srcpkgs/lib3mf-devel
@@ -0,0 +1 @@
+lib3mf
\ No newline at end of file
diff --git a/srcpkgs/lib3mf/template b/srcpkgs/lib3mf/template
new file mode 100644
index 000000000000..a1554cf2e1d7
--- /dev/null
+++ b/srcpkgs/lib3mf/template
@@ -0,0 +1,36 @@
+# Template file for 'lib3mf'
+pkgname=lib3mf
+version=2.2.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_INCLUDED_LIBZIP=OFF -DUSE_INCLUDED_ZLIB=OFF
+ -DUSE_INCLUDED_GTEST=OFF -DUSE_INCLUDED_SSL=OFF
+ -DCMAKE_INSTALL_INCLUDEDIR='include/$pkgname' -DCMAKE_INSTALL_PREFIX=/usr
+ $([ "$XBPS_CHECK_PKGS" ] || echo '-DLIB3MF_TESTS=OFF')"
+hostmakedepends="pkg-config"
+makedepends="zlib-devel libzip-devel"
+checkdepends="gtest-devel openssl-devel"
+short_desc="Official 3mf format implementation"
+maintainer="Danielle Hutzley <endergeryt@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://3mf.io"
+distfiles="https://github.com/3MFConsortium/lib3mf/archive/refs/tags/v${version}.tar.gz"
+checksum=96e85e278fc5474123e3c47237dd42faaf1fdf8e182541a84af7fe84ddd3cbde
+
+post_install() {
+ vdoc README.md
+ vlicense LICENSE
+}
+
+lib3mf-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision} $makedepends"
+ short_desc+=" - development files"
+ pkg_install() {
+ INCDIR="$DESTDIR/usr/include/lib3mf/"
+ BINDDIR="$INCDIR/Bindings"
+ ln -rst "$INCDIR" "$BINDDIR"/C/* "$BINDDIR"/Cpp/*
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
From ede624e434aac534d82e6c07c5ac245d4c632415 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:14:19 -0700
Subject: [PATCH 2/2] openscad: support 3mf
---
srcpkgs/openscad/template | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/openscad/template b/srcpkgs/openscad/template
index a3951a1a2201..2aa1b58a9d71 100644
--- a/srcpkgs/openscad/template
+++ b/srcpkgs/openscad/template
@@ -1,14 +1,25 @@
# Template file for 'openscad'
pkgname=openscad
version=2021.01
-revision=3
+revision=4
build_style=qmake
hostmakedepends="bison flex pkg-config gettext qt5-qmake qt5-host-tools"
makedepends="cgal-devel harfbuzz-devel opencsg-devel qscintilla-qt5-devel
- qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel"
+ qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel
+ $(vopt_if 3mf lib3mf-devel)"
short_desc="Solid 3D CAD modeller"
maintainer="Pierre Allegraud <pierre.allegraud@crans.org>"
license="GPL-2.0-or-later"
homepage="http://www.openscad.org"
distfiles="http://files.openscad.org/${pkgname}-${version}.src.tar.gz"
checksum=d938c297e7e5f65dbab1461cac472fc60dfeaa4999ea2c19b31a4184f2d70359
+
+pre_patch() {
+ if [ "$build_option_3mf" ]; then
+ vsed -i features/lib3mf.prf -e "s/lib3MF/lib3mf/g"
+ fi
+}
+
+build_options="3mf"
+desc_option_png="Enable support for 3MF models"
+build_options_default="3mf"
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (4 preceding siblings ...)
2022-11-02 23:15 ` [PR PATCH] [Updated] " enderger
@ 2022-11-02 23:17 ` enderger
2022-11-02 23:23 ` enderger
` (18 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
New comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1301481914
Comment:
Probably should have ran the linter...
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (5 preceding siblings ...)
2022-11-02 23:17 ` enderger
@ 2022-11-02 23:23 ` enderger
2022-11-02 23:46 ` enderger
` (17 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1301485636
Comment:
Just fixed the indentation and rebuilt, the only change was the indentation so it should be fine if the rest of the checks pass.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (6 preceding siblings ...)
2022-11-02 23:23 ` enderger
@ 2022-11-02 23:46 ` enderger
2022-11-03 0:16 ` [PR REVIEW] " classabbyamp
` (16 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-02 23:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
New comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1301498316
Comment:
@paper42 - Sorry for any confusion, I pushed another commit during the CI run so it does actually need to run again. This time, I've ensured that the linter passes and the project compiles, so CI should pass this time.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (8 preceding siblings ...)
2022-11-03 0:16 ` [PR REVIEW] " classabbyamp
@ 2022-11-03 0:16 ` classabbyamp
2022-11-03 0:16 ` classabbyamp
` (14 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-11-03 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012399266
Comment:
why do this instead of just `mv ${DESTDIR}/Bindings/C/* ${DESTDIR}/Bindings/Cpp/* ${DESTDIR}/usr/include/$pkgname`?
also, this would fit more in `post_install()`
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (7 preceding siblings ...)
2022-11-02 23:46 ` enderger
@ 2022-11-03 0:16 ` classabbyamp
2022-11-03 0:16 ` classabbyamp
` (15 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-11-03 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012399627
Comment:
why make this a build option?
also, these variables should go before the `pre_patch()` function
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (9 preceding siblings ...)
2022-11-03 0:16 ` classabbyamp
@ 2022-11-03 0:16 ` classabbyamp
2022-11-03 0:16 ` classabbyamp
` (13 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-11-03 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012398085
Comment:
> `-DCMAKE_INSTALL_INCLUDEDIR='include/$pkgname'`
this is the [default already](https://github.com/3MFConsortium/lib3mf/blob/v2.2.0/CMakeLists.txt#L23)
> `-DCMAKE_INSTALL_PREFIX=/usr`
this is [already specified](https://github.com/void-linux/void-packages/blob/master/common/build-style/cmake.sh#L54)
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (10 preceding siblings ...)
2022-11-03 0:16 ` classabbyamp
@ 2022-11-03 0:16 ` classabbyamp
2022-11-03 0:23 ` enderger
` (12 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-11-03 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012396754
Comment:
this would be better as an if block below:
```bash
if [ -z "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -DLIB3MF_TESTS=OFF"
fi
```
however, I don't think it will affect the final build if the tests are always built
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (12 preceding siblings ...)
2022-11-03 0:23 ` enderger
@ 2022-11-03 0:23 ` enderger
2022-11-03 0:23 ` enderger
` (10 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012401753
Comment:
Yeah, it was being a bit finicky so I tried adding those like the AUR build does.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (11 preceding siblings ...)
2022-11-03 0:16 ` classabbyamp
@ 2022-11-03 0:23 ` enderger
2022-11-03 0:23 ` enderger
` (11 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012401485
Comment:
Not having it is the behavior beforehand and the library is optional, so I figured it qualified as an optional feature.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (13 preceding siblings ...)
2022-11-03 0:23 ` enderger
@ 2022-11-03 0:23 ` enderger
2022-11-03 0:29 ` enderger
` (9 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012401040
Comment:
Both formats might be used, so it's best to just use symlinks in case the original locations are needed.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (14 preceding siblings ...)
2022-11-03 0:23 ` enderger
@ 2022-11-03 0:29 ` enderger
2022-11-03 0:32 ` classabbyamp
` (8 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012403812
Comment:
The tests have dependencies, so they won't compile correctly by default AFAIK.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (15 preceding siblings ...)
2022-11-03 0:29 ` enderger
@ 2022-11-03 0:32 ` classabbyamp
2022-11-03 0:48 ` [PR PATCH] [Updated] " enderger
` (7 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-11-03 0:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012404774
Comment:
that can be added to make_depends
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR PATCH] [Updated] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (16 preceding siblings ...)
2022-11-03 0:32 ` classabbyamp
@ 2022-11-03 0:48 ` enderger
2022-11-03 0:58 ` [PR REVIEW] " enderger
` (6 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
There is an updated pull request by enderger against master on the void-packages repository
https://github.com/enderger/void-packages pkg/pkg-lib3mf
https://github.com/void-linux/void-packages/pull/40307
Package lib3mf
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40307.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/pkg-lib3mf-40307.patch --]
[-- Type: text/x-diff, Size: 3799 bytes --]
From 8418849473a999a56685df8e944b678cebc0061e Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:07:59 -0700
Subject: [PATCH 1/2] New package: lib3mf-2.2.0
---
common/shlibs | 1 +
srcpkgs/lib3mf-devel | 1 +
srcpkgs/lib3mf/template | 38 ++++++++++++++++++++++++++++++++++++++
3 files changed, 40 insertions(+)
create mode 120000 srcpkgs/lib3mf-devel
create mode 100644 srcpkgs/lib3mf/template
diff --git a/common/shlibs b/common/shlibs
index e48e6f352375..d56df6a68066 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4196,3 +4196,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+lib3mf.so.2 lib3mf-2.2.0_1
diff --git a/srcpkgs/lib3mf-devel b/srcpkgs/lib3mf-devel
new file mode 120000
index 000000000000..9352a6a9f9c8
--- /dev/null
+++ b/srcpkgs/lib3mf-devel
@@ -0,0 +1 @@
+lib3mf
\ No newline at end of file
diff --git a/srcpkgs/lib3mf/template b/srcpkgs/lib3mf/template
new file mode 100644
index 000000000000..396932bfe53a
--- /dev/null
+++ b/srcpkgs/lib3mf/template
@@ -0,0 +1,38 @@
+# Template file for 'lib3mf'
+pkgname=lib3mf
+version=2.2.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_INCLUDED_LIBZIP=OFF -DUSE_INCLUDED_ZLIB=OFF
+ -DUSE_INCLUDED_GTEST=OFF -DUSE_INCLUDED_SSL=OFF"
+hostmakedepends="pkg-config"
+makedepends="zlib-devel libzip-devel"
+checkdepends="gtest-devel openssl-devel"
+short_desc="Official 3mf format implementation"
+maintainer="Danielle Hutzley <endergeryt@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://3mf.io"
+distfiles="https://github.com/3MFConsortium/lib3mf/archive/refs/tags/v${version}.tar.gz"
+checksum=96e85e278fc5474123e3c47237dd42faaf1fdf8e182541a84af7fe84ddd3cbde
+
+if [ -z "$XBPS_CHECK_PKGS" ]; then
+ configure_args+=" -DLIB3MF_TESTS=OFF"
+fi
+
+post_install() {
+ vdoc README.md
+ vlicense LICENSE
+ INCDIR="$DESTDIR/usr/include/lib3mf/"
+ BINDDIR="$INCDIR/Bindings"
+ ln -rst "$INCDIR" "$BINDDIR"/C/* "$BINDDIR"/Cpp/*
+}
+
+lib3mf-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision} $makedepends"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
From 6b6d69abb1f0396e23f9126f6eb1ff1cf06b52d1 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:14:19 -0700
Subject: [PATCH 2/2] openscad: support 3mf
---
srcpkgs/openscad/template | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/openscad/template b/srcpkgs/openscad/template
index a3951a1a2201..f5cf9f8f9008 100644
--- a/srcpkgs/openscad/template
+++ b/srcpkgs/openscad/template
@@ -1,14 +1,25 @@
# Template file for 'openscad'
pkgname=openscad
version=2021.01
-revision=3
+revision=4
build_style=qmake
hostmakedepends="bison flex pkg-config gettext qt5-qmake qt5-host-tools"
makedepends="cgal-devel harfbuzz-devel opencsg-devel qscintilla-qt5-devel
- qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel"
+ qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel
+ $(vopt_if 3mf lib3mf-devel)"
short_desc="Solid 3D CAD modeller"
maintainer="Pierre Allegraud <pierre.allegraud@crans.org>"
license="GPL-2.0-or-later"
homepage="http://www.openscad.org"
distfiles="http://files.openscad.org/${pkgname}-${version}.src.tar.gz"
checksum=d938c297e7e5f65dbab1461cac472fc60dfeaa4999ea2c19b31a4184f2d70359
+
+build_options="3mf"
+desc_option_png="Enable support for 3MF models"
+build_options_default="3mf"
+
+pre_patch() {
+ if [ "$build_option_3mf" ]; then
+ vsed -i features/lib3mf.prf -e "s/lib3MF/lib3mf/g"
+ fi
+}
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (17 preceding siblings ...)
2022-11-03 0:48 ` [PR PATCH] [Updated] " enderger
@ 2022-11-03 0:58 ` enderger
2022-11-03 0:59 ` enderger
` (5 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012413174
Comment:
Not entirely sure what the point of check dependencies are then, but if it's more idiomatic I'll merge them.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (18 preceding siblings ...)
2022-11-03 0:58 ` [PR REVIEW] " enderger
@ 2022-11-03 0:59 ` enderger
2022-11-03 1:12 ` [PR PATCH] [Updated] " enderger
` (4 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 0:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012413305
Comment:
Fixed the positioning
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR PATCH] [Updated] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (19 preceding siblings ...)
2022-11-03 0:59 ` enderger
@ 2022-11-03 1:12 ` enderger
2022-11-03 1:16 ` enderger
` (3 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 1:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
There is an updated pull request by enderger against master on the void-packages repository
https://github.com/enderger/void-packages pkg/pkg-lib3mf
https://github.com/void-linux/void-packages/pull/40307
Package lib3mf
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40307.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/pkg-lib3mf-40307.patch --]
[-- Type: text/x-diff, Size: 3826 bytes --]
From df7eff4131ab49c6d0811a66663f29c01b5b13e8 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:07:59 -0700
Subject: [PATCH 1/2] New package: lib3mf-2.2.0
---
common/shlibs | 1 +
srcpkgs/lib3mf-devel | 1 +
srcpkgs/lib3mf/template | 40 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 42 insertions(+)
create mode 120000 srcpkgs/lib3mf-devel
create mode 100644 srcpkgs/lib3mf/template
diff --git a/common/shlibs b/common/shlibs
index e48e6f352375..d56df6a68066 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4196,3 +4196,4 @@ libabsl_strings.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_throw_delegate.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_time_zone.so.2206.0.0 abseil-cpp-20220623.1_1
libabsl_spinlock_wait.so.2206.0.0 abseil-cpp-20220623.1_1
+lib3mf.so.2 lib3mf-2.2.0_1
diff --git a/srcpkgs/lib3mf-devel b/srcpkgs/lib3mf-devel
new file mode 120000
index 000000000000..9352a6a9f9c8
--- /dev/null
+++ b/srcpkgs/lib3mf-devel
@@ -0,0 +1 @@
+lib3mf
\ No newline at end of file
diff --git a/srcpkgs/lib3mf/template b/srcpkgs/lib3mf/template
new file mode 100644
index 000000000000..1ba9f3de4534
--- /dev/null
+++ b/srcpkgs/lib3mf/template
@@ -0,0 +1,40 @@
+# Template file for 'lib3mf'
+pkgname=lib3mf
+version=2.2.0
+revision=1
+build_style=cmake
+configure_args="-DUSE_INCLUDED_LIBZIP=OFF -DUSE_INCLUDED_ZLIB=OFF
+ -DUSE_INCLUDED_GTEST=OFF -DUSE_INCLUDED_SSL=OFF"
+hostmakedepends="pkg-config"
+makedepends="zlib-devel libzip-devel"
+checkdepends="gtest-devel openssl-devel"
+short_desc="Official 3mf format implementation"
+maintainer="Danielle Hutzley <endergeryt@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://3mf.io"
+distfiles="https://github.com/3MFConsortium/lib3mf/archive/refs/tags/v${version}.tar.gz"
+checksum=96e85e278fc5474123e3c47237dd42faaf1fdf8e182541a84af7fe84ddd3cbde
+
+if [ -z "$XBPS_CHECK_PKGS" ]; then
+ configure_args+=" -DLIB3MF_TESTS=OFF"
+fi
+
+post_install() {
+ vdoc README.md
+ vlicense LICENSE
+}
+
+lib3mf-devel_package() {
+ depends="${sourcepkg}>=${version}_${revision} $makedepends"
+ short_desc+=" - development files"
+ pre_install() {
+ INCDIR="$DESTDIR/usr/include/lib3mf/"
+ BINDDIR="$INCDIR/Bindings"
+ ln -rst "$INCDIR" "$BINDDIR"/C/* "$BINDDIR"/Cpp/*
+ }
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.so"
+ }
+}
From 3af85cd177a994d1e0426757b6d6f61eab815bf6 Mon Sep 17 00:00:00 2001
From: Hutzdog <endergeryt@gmail.com>
Date: Wed, 2 Nov 2022 15:14:19 -0700
Subject: [PATCH 2/2] openscad: support 3mf
---
srcpkgs/openscad/template | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/openscad/template b/srcpkgs/openscad/template
index a3951a1a2201..f5cf9f8f9008 100644
--- a/srcpkgs/openscad/template
+++ b/srcpkgs/openscad/template
@@ -1,14 +1,25 @@
# Template file for 'openscad'
pkgname=openscad
version=2021.01
-revision=3
+revision=4
build_style=qmake
hostmakedepends="bison flex pkg-config gettext qt5-qmake qt5-host-tools"
makedepends="cgal-devel harfbuzz-devel opencsg-devel qscintilla-qt5-devel
- qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel"
+ qt5-multimedia-devel libxml2-devel libzip-devel double-conversion-devel
+ $(vopt_if 3mf lib3mf-devel)"
short_desc="Solid 3D CAD modeller"
maintainer="Pierre Allegraud <pierre.allegraud@crans.org>"
license="GPL-2.0-or-later"
homepage="http://www.openscad.org"
distfiles="http://files.openscad.org/${pkgname}-${version}.src.tar.gz"
checksum=d938c297e7e5f65dbab1461cac472fc60dfeaa4999ea2c19b31a4184f2d70359
+
+build_options="3mf"
+desc_option_png="Enable support for 3MF models"
+build_options_default="3mf"
+
+pre_patch() {
+ if [ "$build_option_3mf" ]; then
+ vsed -i features/lib3mf.prf -e "s/lib3MF/lib3mf/g"
+ fi
+}
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (20 preceding siblings ...)
2022-11-03 1:12 ` [PR PATCH] [Updated] " enderger
@ 2022-11-03 1:16 ` enderger
2022-11-03 1:32 ` [PR REVIEW] " enderger
` (2 subsequent siblings)
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 1:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1301540710
Comment:
Alright, I had to move the symlinking to `pre_install` for the development package to allow it to build.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR REVIEW] Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (21 preceding siblings ...)
2022-11-03 1:16 ` enderger
@ 2022-11-03 1:32 ` enderger
2023-02-01 2:07 ` github-actions
2023-02-16 2:01 ` [PR PATCH] [Closed]: " github-actions
24 siblings, 0 replies; 26+ messages in thread
From: enderger @ 2022-11-03 1:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New review comment by enderger on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#discussion_r1012429302
Comment:
Putting it in `post_install` didn't work, so I used `pre_install` instead. Seems to have fixed it.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (22 preceding siblings ...)
2022-11-03 1:32 ` [PR REVIEW] " enderger
@ 2023-02-01 2:07 ` github-actions
2023-02-16 2:01 ` [PR PATCH] [Closed]: " github-actions
24 siblings, 0 replies; 26+ messages in thread
From: github-actions @ 2023-02-01 2:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/40307#issuecomment-1411343916
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PR PATCH] [Closed]: Package lib3mf
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
` (23 preceding siblings ...)
2023-02-01 2:07 ` github-actions
@ 2023-02-16 2:01 ` github-actions
24 siblings, 0 replies; 26+ messages in thread
From: github-actions @ 2023-02-16 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
There's a closed pull request on the void-packages repository
Package lib3mf
https://github.com/void-linux/void-packages/pull/40307
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2023-02-16 2:01 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 22:13 [PR PATCH] Package lib3mf enderger
2022-11-02 22:49 ` enderger
2022-11-02 22:59 ` [PR REVIEW] " paper42
2022-11-02 23:10 ` [PR PATCH] [Updated] " enderger
2022-11-02 23:10 ` [PR REVIEW] " enderger
2022-11-02 23:15 ` [PR PATCH] [Updated] " enderger
2022-11-02 23:17 ` enderger
2022-11-02 23:23 ` enderger
2022-11-02 23:46 ` enderger
2022-11-03 0:16 ` [PR REVIEW] " classabbyamp
2022-11-03 0:16 ` classabbyamp
2022-11-03 0:16 ` classabbyamp
2022-11-03 0:16 ` classabbyamp
2022-11-03 0:23 ` enderger
2022-11-03 0:23 ` enderger
2022-11-03 0:23 ` enderger
2022-11-03 0:29 ` enderger
2022-11-03 0:32 ` classabbyamp
2022-11-03 0:48 ` [PR PATCH] [Updated] " enderger
2022-11-03 0:58 ` [PR REVIEW] " enderger
2022-11-03 0:59 ` enderger
2022-11-03 1:12 ` [PR PATCH] [Updated] " enderger
2022-11-03 1:16 ` enderger
2022-11-03 1:32 ` [PR REVIEW] " enderger
2023-02-01 2:07 ` github-actions
2023-02-16 2:01 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).