From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] env/setup/sourcepkg: unset all exported variables
Date: Mon, 07 Nov 2022 16:00:36 +0100 [thread overview]
Message-ID: <20221107150036.VPT4ghm1D3ngUIvto_n77LANpQx9lnwn3EtDK06Hdzk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40359@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages unset-exported-var
https://github.com/void-linux/void-packages/pull/40359
env/setup/sourcepkg: unset all exported variables
except known to be good one.
See 581cdacc5b and 253b9f0b98
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/40359.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-unset-exported-var-40359.patch --]
[-- Type: text/x-diff, Size: 2146 bytes --]
From 3ab06450d14cd152dfe22e3240c56ab7b5223382 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Sun, 6 Nov 2022 22:54:39 +0700
Subject: [PATCH] env/setup/sourcepkg: unset all exported variables
except known to be good one.
See 581cdacc5b and 253b9f0b98
---
common/environment/setup/sourcepkg.sh | 32 +++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/common/environment/setup/sourcepkg.sh b/common/environment/setup/sourcepkg.sh
index 048096f24b22..1a27a4b868f5 100644
--- a/common/environment/setup/sourcepkg.sh
+++ b/common/environment/setup/sourcepkg.sh
@@ -1,6 +1,37 @@
# This shell snippet unsets all variables/functions that can be used in
# the package template (excluding subpackages).
+# Exported variables
+for var in $(env | sed -e 's/=.*//'); do
+ # Those variables in chroot.sh will be kept
+ case "$var" in
+ XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH)
+ # xbps-src specific
+ ;;
+ SOURCEFORGE_SITE | NONGNU_SITE | XORG_SITE | DEBIAN_SITE | GNOME_SITE)
+ ;;
+ KERNEL_SITE | CPAN_SITE | PYPI_SITE | MOZILLA_SITE | GNU_SITE)
+ ;;
+ FREEDESKTOP_SITE | KDE_SITE | VIDEOLAN_SITE)
+ ;;
+ _ | PWD | SHLVL | USER | PATH | SHELL | HOME | LC_COLLATE | LANG | TERM | PS1)
+ # known variables for shell
+ ;;
+ DISTCC_HOSTS | DISTCC_DIR)
+ ;;
+ CCACHE_DIR | CCACHE_COMPRESS)
+ ;;
+ HTTP_PROXY | HTTPS_PROXY | SOCKS_PROXY | NO_PROXY | HTTP_PROXY_AUTH)
+ ;;
+ FTP_PROXY | FTP_RETRIES)
+ ;;
+ *)
+ unset -v "$var"
+ ;;
+ esac
+done
+unset -v var
+
## VARIABLES
unset -v pkgname version revision short_desc homepage license maintainer
unset -v archs distfiles checksum build_style build_helper nocross broken
@@ -20,6 +51,7 @@ unset -v nopie build_options build_options_default bootstrap repository reverts
unset -v CFLAGS CXXFLAGS FFLAGS CPPFLAGS LDFLAGS LD_LIBRARY_PATH
unset -v CC CXX CPP GCC LD AR AS RANLIB NM OBJDUMP OBJCOPY STRIP READELF PKG_CONFIG
unset -v CMAKE_GENERATOR
+unset -v scons_use_destdir
# build-helper python3
unset -v PYPREFIX LDSHARED PYTHON_CONFIG PYTHONPATH _PYTHON_SYSCONFIGDATA_NAME
next prev parent reply other threads:[~2022-11-07 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 15:56 [PR PATCH] " sgn
2022-11-07 2:23 ` [PR PATCH] [Updated] " sgn
2022-11-07 3:00 ` sgn
2022-11-07 15:00 ` sgn [this message]
2022-11-30 16:25 ` sgn
2022-12-03 10:27 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107150036.VPT4ghm1D3ngUIvto_n77LANpQx9lnwn3EtDK06Hdzk@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).