Re: [PR PATCH] [Updated] env/setup/sourcepkg: unset all exported variables

[sgn <sgn@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages unset-exported-var
https://github.com/void-linux/void-packages/pull/40359

env/setup/sourcepkg: unset all exported variables
except known to be good one.

See 581cdacc5b and 253b9f0b98

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40359.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-unset-exported-var-40359.patch --]
[-- Type: text/x-diff, Size: 2146 bytes --]

From a95837787154d9be4d1f1528e064113391a91a18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 6 Nov 2022 22:54:39 +0700
Subject: [PATCH] env/setup/sourcepkg: unset all exported variables

except known to be good one.

See 581cdacc5b and 253b9f0b98
---
 common/environment/setup/sourcepkg.sh | 32 +++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/common/environment/setup/sourcepkg.sh b/common/environment/setup/sourcepkg.sh
index 048096f24b22..1a27a4b868f5 100644
--- a/common/environment/setup/sourcepkg.sh
+++ b/common/environment/setup/sourcepkg.sh
@@ -1,6 +1,37 @@
 # This shell snippet unsets all variables/functions that can be used in
 # the package template (excluding subpackages).
 
+# Exported variables
+for var in $(env | sed -e 's/=.*//'); do
+	# Those variables in chroot.sh will be kept
+	case "$var" in
+	XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH)
+		# xbps-src specific
+		;;
+	SOURCEFORGE_SITE | NONGNU_SITE | XORG_SITE | DEBIAN_SITE | GNOME_SITE)
+		;;
+	KERNEL_SITE | CPAN_SITE | PYPI_SITE | MOZILLA_SITE | GNU_SITE)
+		;;
+	FREEDESKTOP_SITE | KDE_SITE | VIDEOLAN_SITE)
+		;;
+	_ | PWD | SHLVL | USER | PATH | SHELL | HOME | LC_COLLATE | LANG | TERM | PS1)
+		# known variables for shell
+		;;
+	DISTCC_HOSTS | DISTCC_DIR)
+		;;
+	CCACHE_DIR | CCACHE_COMPRESS)
+		;;
+	HTTP_PROXY | HTTPS_PROXY | SOCKS_PROXY | NO_PROXY | HTTP_PROXY_AUTH)
+		;;
+	FTP_PROXY | FTP_RETRIES)
+		;;
+	*)
+		unset -v "$var"
+		;;
+	esac
+done
+unset -v var
+
 ## VARIABLES
 unset -v pkgname version revision short_desc homepage license maintainer
 unset -v archs distfiles checksum build_style build_helper nocross broken
@@ -20,6 +51,7 @@ unset -v nopie build_options build_options_default bootstrap repository reverts
 unset -v CFLAGS CXXFLAGS FFLAGS CPPFLAGS LDFLAGS LD_LIBRARY_PATH
 unset -v CC CXX CPP GCC LD AR AS RANLIB NM OBJDUMP OBJCOPY STRIP READELF PKG_CONFIG
 unset -v CMAKE_GENERATOR
+unset -v scons_use_destdir
 # build-helper python3
 unset -v PYPREFIX LDSHARED PYTHON_CONFIG PYTHONPATH _PYTHON_SYSCONFIGDATA_NAME