* [PR PATCH] ogmrip: remove libglade-devel from makedepends
@ 2022-11-07 21:01 kruceter
2022-11-08 19:14 ` paper42
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: kruceter @ 2022-11-07 21:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
There is a new pull request by kruceter against master on the void-packages repository
https://github.com/kruceter/void-packages ogmrip
https://github.com/void-linux/void-packages/pull/40376
ogmrip: remove libglade-devel from makedepends
This library is not used by ogmrip.
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40376.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ogmrip-40376.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]
From 635984f48511aec67958542d1f3db0b88c7b111b Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Mon, 7 Nov 2022 23:31:41 +0300
Subject: [PATCH] ogmrip: remove libglade-devel from makedepends
This library is not used by ogmrip.
---
srcpkgs/ogmrip/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/ogmrip/template b/srcpkgs/ogmrip/template
index 1905d67b6abc..051e19828c65 100644
--- a/srcpkgs/ogmrip/template
+++ b/srcpkgs/ogmrip/template
@@ -1,12 +1,12 @@
# Template file for 'ogmrip'
pkgname=ogmrip
version=1.0.1
-revision=9
+revision=10
build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="intltool pkg-config"
makedepends="dbus-glib-devel enca-devel enchant2-devel lame-devel
- libdvdread-devel libglade-devel libnotify-devel libtheora-devel mplayer
+ libdvdread-devel libnotify-devel libtheora-devel mplayer
vorbis-tools x264-devel xvidcore-devel"
depends="desktop-file-utils mplayer vorbis-tools ogmtools mkvtoolnix tesseract-ocr"
short_desc="Application to rip and encode DVDs into AVI, OGM, MP4, or Matroska"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ogmrip: remove libglade-devel from makedepends
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
@ 2022-11-08 19:14 ` paper42
2022-11-08 19:54 ` [PR PATCH] [Updated] " kruceter
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-11-08 19:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40376#issuecomment-1307710975
Comment:
> This library is not used by ogmrip.
It would be used if we were building the GTK2 GUI which we are not, could you adjust the commit message?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] ogmrip: remove libglade-devel from makedepends
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
2022-11-08 19:14 ` paper42
@ 2022-11-08 19:54 ` kruceter
2022-11-08 19:55 ` kruceter
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kruceter @ 2022-11-08 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
There is an updated pull request by kruceter against master on the void-packages repository
https://github.com/kruceter/void-packages ogmrip
https://github.com/void-linux/void-packages/pull/40376
ogmrip: remove libglade-devel from makedepends
This library is not used by ogmrip.
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/40376.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ogmrip-40376.patch --]
[-- Type: text/x-diff, Size: 1136 bytes --]
From cf48aabd7b39b0f3eb952113020081108e8ce2bc Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Mon, 7 Nov 2022 23:31:41 +0300
Subject: [PATCH] ogmrip: remove libglade-devel from makedepends
It would be used for building GTK2 GUI which is not enabled.
---
srcpkgs/ogmrip/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/ogmrip/template b/srcpkgs/ogmrip/template
index 1905d67b6abc..051e19828c65 100644
--- a/srcpkgs/ogmrip/template
+++ b/srcpkgs/ogmrip/template
@@ -1,12 +1,12 @@
# Template file for 'ogmrip'
pkgname=ogmrip
version=1.0.1
-revision=9
+revision=10
build_style=gnu-configure
configure_args="--disable-static"
hostmakedepends="intltool pkg-config"
makedepends="dbus-glib-devel enca-devel enchant2-devel lame-devel
- libdvdread-devel libglade-devel libnotify-devel libtheora-devel mplayer
+ libdvdread-devel libnotify-devel libtheora-devel mplayer
vorbis-tools x264-devel xvidcore-devel"
depends="desktop-file-utils mplayer vorbis-tools ogmtools mkvtoolnix tesseract-ocr"
short_desc="Application to rip and encode DVDs into AVI, OGM, MP4, or Matroska"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ogmrip: remove libglade-devel from makedepends
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
2022-11-08 19:14 ` paper42
2022-11-08 19:54 ` [PR PATCH] [Updated] " kruceter
@ 2022-11-08 19:55 ` kruceter
2022-11-08 20:07 ` paper42
2022-11-08 20:07 ` [PR PATCH] [Merged]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: kruceter @ 2022-11-08 19:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by kruceter on void-packages repository
https://github.com/void-linux/void-packages/pull/40376#issuecomment-1307754570
Comment:
@paper42, my apologies for the delay. The commit message has been corrected.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ogmrip: remove libglade-devel from makedepends
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
` (2 preceding siblings ...)
2022-11-08 19:55 ` kruceter
@ 2022-11-08 20:07 ` paper42
2022-11-08 20:07 ` [PR PATCH] [Merged]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-11-08 20:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40376#issuecomment-1307767561
Comment:
1h isn't a delay, I didn't expect you to fix it so quickly :slightly_smiling_face:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: ogmrip: remove libglade-devel from makedepends
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
` (3 preceding siblings ...)
2022-11-08 20:07 ` paper42
@ 2022-11-08 20:07 ` paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-11-08 20:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
There's a merged pull request on the void-packages repository
ogmrip: remove libglade-devel from makedepends
https://github.com/void-linux/void-packages/pull/40376
Description:
It would be used for building GTK2 GUI which is not enabled.
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-08 20:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 21:01 [PR PATCH] ogmrip: remove libglade-devel from makedepends kruceter
2022-11-08 19:14 ` paper42
2022-11-08 19:54 ` [PR PATCH] [Updated] " kruceter
2022-11-08 19:55 ` kruceter
2022-11-08 20:07 ` paper42
2022-11-08 20:07 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).