From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
Date: Tue, 08 Nov 2022 23:09:32 +0100 [thread overview]
Message-ID: <20221108220932.zy8TAkerN_uOWFTFOCvzCvnq_BbzihTZQS-L6qf5i68@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40346@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages pkglint-gschemas.compiled
https://github.com/void-linux/void-packages/pull/40346
hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
gschemas.compiled is generated by glib-compile-schemas and should not be overriden by a package
#### Testing the changes
- I tested the changes in this PR: **YES**
discovered in #40311 which should be merged before this PR
xdaliclock fixed in https://github.com/void-linux/void-packages/commit/04f25c019da19c9d0bb4162551afc0115441c853
A patch file from https://github.com/void-linux/void-packages/pull/40346.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkglint-gschemas.compiled-40346.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]
From e2621a56dfd5a0a59956815ca8a010189166ffb3 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 5 Nov 2022 13:59:57 +0100
Subject: [PATCH] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
gschemas.compiled is generated by glib-compile-schemas and should not be
overriden by a package
---
common/hooks/pre-pkg/99-pkglint.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/hooks/pre-pkg/99-pkglint.sh b/common/hooks/pre-pkg/99-pkglint.sh
index a63e37207929..bdafd7b9b11d 100644
--- a/common/hooks/pre-pkg/99-pkglint.sh
+++ b/common/hooks/pre-pkg/99-pkglint.sh
@@ -128,6 +128,11 @@ hook() {
error=1
fi
+ if [ -e ${PKGDESTDIR}/usr/share/glib-2.0/schemas/gschemas.compiled ]; then
+ msg_red "${pkgver}: /usr/share/glib-2.0/schemas/gschemas.compiled is forbidden. Delete it.\n"
+ error=1
+ fi
+
# Forbid files would be generated by mimedb trigger
for f in XMLnamespaces aliases generic-icons globs globs2 icons \
magic mime.cache subclasses treemagic types version ; do
next prev parent reply other threads:[~2022-11-08 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 15:12 [PR PATCH] " paper42
2022-11-08 22:09 ` paper42 [this message]
2022-11-22 21:51 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108220932.zy8TAkerN_uOWFTFOCvzCvnq_BbzihTZQS-L6qf5i68@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).