[PR PATCH] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

[PR PATCH] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

[paper42]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pkglint-gschemas.compiled
https://github.com/void-linux/void-packages/pull/40346

hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
gschemas.compiled is generated by glib-compile-schemas and should not be overriden by a package

#### Testing the changes
- I tested the changes in this PR: **YES**

discovered in #40311 which should be merged before this PR
xdaliclock fixed in https://github.com/void-linux/void-packages/commit/04f25c019da19c9d0bb4162551afc0115441c853

A patch file from https://github.com/void-linux/void-packages/pull/40346.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkglint-gschemas.compiled-40346.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

From 1563c986205d3f9103ef8142dd633ba75ccc4354 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 5 Nov 2022 13:59:57 +0100
Subject: [PATCH] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

gschemas.compiled is generated by glib-compile-schemas and should not be
overriden by a package
---
 common/hooks/pre-pkg/99-pkglint.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/hooks/pre-pkg/99-pkglint.sh b/common/hooks/pre-pkg/99-pkglint.sh
index a63e37207929..bdafd7b9b11d 100644
--- a/common/hooks/pre-pkg/99-pkglint.sh
+++ b/common/hooks/pre-pkg/99-pkglint.sh
@@ -128,6 +128,11 @@ hook() {
 		error=1
 	fi
 
+	if [ -e ${PKGDESTDIR}/usr/share/glib-2.0/schemas/gschemas.compiled ]; then
+		msg_red "${pkgver}: /usr/share/glib-2.0/schemas/gschemas.compiled is forbidden. Delete it.\n"
+		error=1
+	fi
+
 	# Forbid files would be generated by mimedb trigger
 	for f in XMLnamespaces aliases generic-icons globs globs2 icons \
 		magic mime.cache subclasses treemagic types version ; do

Re: [PR PATCH] [Updated] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

[paper42]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pkglint-gschemas.compiled
https://github.com/void-linux/void-packages/pull/40346

hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
gschemas.compiled is generated by glib-compile-schemas and should not be overriden by a package

#### Testing the changes
- I tested the changes in this PR: **YES**

discovered in #40311 which should be merged before this PR
xdaliclock fixed in https://github.com/void-linux/void-packages/commit/04f25c019da19c9d0bb4162551afc0115441c853

A patch file from https://github.com/void-linux/void-packages/pull/40346.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkglint-gschemas.compiled-40346.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

From e2621a56dfd5a0a59956815ca8a010189166ffb3 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 5 Nov 2022 13:59:57 +0100
Subject: [PATCH] hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

gschemas.compiled is generated by glib-compile-schemas and should not be
overriden by a package
---
 common/hooks/pre-pkg/99-pkglint.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/hooks/pre-pkg/99-pkglint.sh b/common/hooks/pre-pkg/99-pkglint.sh
index a63e37207929..bdafd7b9b11d 100644
--- a/common/hooks/pre-pkg/99-pkglint.sh
+++ b/common/hooks/pre-pkg/99-pkglint.sh
@@ -128,6 +128,11 @@ hook() {
 		error=1
 	fi
 
+	if [ -e ${PKGDESTDIR}/usr/share/glib-2.0/schemas/gschemas.compiled ]; then
+		msg_red "${pkgver}: /usr/share/glib-2.0/schemas/gschemas.compiled is forbidden. Delete it.\n"
+		error=1
+	fi
+
 	# Forbid files would be generated by mimedb trigger
 	for f in XMLnamespaces aliases generic-icons globs globs2 icons \
 		magic mime.cache subclasses treemagic types version ; do

Re: [PR PATCH] [Merged]: hooks/99-pkglint.sh: error when pkg ships gschemas.compiled

[paper42]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

There's a merged pull request on the void-packages repository

hooks/99-pkglint.sh: error when pkg ships gschemas.compiled
https://github.com/void-linux/void-packages/pull/40346

Description:
gschemas.compiled is generated by glib-compile-schemas and should not be overriden by a package

#### Testing the changes
- I tested the changes in this PR: **YES**

discovered in #40311 which should be merged before this PR
xdaliclock fixed in https://github.com/void-linux/void-packages/commit/04f25c019da19c9d0bb4162551afc0115441c853