Github messages for voidlinux
 help / color / mirror / Atom feed
From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: vtk: update to 9.2.2
Date: Thu, 10 Nov 2022 23:32:00 +0100	[thread overview]
Message-ID: <20221110223200.ucwuaTfpb01g02KIrLMJyl8UonhU-e-pxyBsBaK5mKw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40423@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/40423#issuecomment-1310986041

Comment:
Failing build for x86_64-musl (possibly?) can be fixed with this patch:

```diff
diff --color -u -r VTK-9.2.2-src/ThirdParty/ioss/vtkioss/Ioss_FileInfo.C VTK-9.2.2/ThirdParty/ioss/vtkioss/Ioss_FileInfo.C
--- VTK-9.2.2-src/ThirdParty/ioss/vtkioss/Ioss_FileInfo.C	2022-11-10 19:57:10.104509831 +0300
+++ VTK-9.2.2/ThirdParty/ioss/vtkioss/Ioss_FileInfo.C	2022-11-10 21:30:44.327591097 +0300
@@ -26,7 +26,11 @@
 #define S_ISDIR(m) (((m)&_S_IFMT) == _S_IFDIR)
 #endif
 #else
+#ifdef __GLIBC__
 #include <sys/unistd.h>
+#else
+#include <unistd.h>
+#endif
 #endif
 
 #ifdef SEACAS_HAVE_MPI
@@ -35,9 +39,6 @@
 
 #include <cstdio>
 #include <sys/stat.h>
-#ifndef _MSC_VER
-#include <unistd.h>
-#endif
 
 namespace {
   bool internal_access(const std::string &name, int mode);
```

I see that the patch fixing build with GCC 12 has been removed, meaning that vtk has to be tested against GCC 12 once again.

  parent reply	other threads:[~2022-11-10 22:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 23:56 [PR PATCH] " ar-jan
2022-11-09 23:59 ` [PR PATCH] [Updated] " ar-jan
2022-11-10 22:32 ` kruceter [this message]
2022-11-10 22:32 ` kruceter
2022-11-11  9:22 ` [PR PATCH] [Updated] " ar-jan
2022-11-11  9:24 ` ar-jan
2022-11-11  9:44 ` paper42
2022-11-12 15:08 ` ar-jan
2022-11-12 20:55 ` paper42
2022-11-12 21:24 ` [PR PATCH] [Updated] " ar-jan
2022-11-12 21:41 ` paper42
2022-11-12 21:42 ` paper42
2022-11-12 21:45 ` [PR REVIEW] " paper42
2022-11-12 22:43 ` ar-jan
2022-11-12 22:51 ` [PR REVIEW] " ar-jan
2022-11-12 22:52 ` ar-jan
2022-11-12 22:53 ` paper42
2022-11-12 23:08 ` ar-jan
2022-11-12 23:10 ` ar-jan
2022-11-14 15:55 ` kruceter
2022-11-14 15:59 ` kruceter
2022-11-14 16:40 ` [PR PATCH] [Updated] " ar-jan
2022-11-14 16:48 ` [PR REVIEW] " paper42
2022-11-14 16:57 ` ar-jan
2022-11-14 16:58 ` paper42
2022-11-14 17:02 ` [PR PATCH] [Updated] " ar-jan
2022-11-14 17:02 ` [PR REVIEW] " ar-jan
2022-11-15 18:05 ` kruceter
2022-11-17 12:26 ` paper42
2022-11-20  2:12 ` kruceter
2022-11-20 16:01 ` [PR PATCH] [Updated] " ar-jan
2022-11-20 16:03 ` ar-jan
2022-12-02 12:28 ` ar-jan
2022-12-02 16:52 ` ar-jan
2022-12-03 20:38 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110223200.ucwuaTfpb01g02KIrLMJyl8UonhU-e-pxyBsBaK5mKw@z \
    --to=kruceter@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).