Github messages for voidlinux
 help / color / mirror / Atom feed
From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: vtk: update to 9.2.2
Date: Sun, 20 Nov 2022 03:12:50 +0100	[thread overview]
Message-ID: <20221120021250.4CS39X2SVT2oI6lgyNzgadLqOgjkP_PzV8R3WodGeWE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40423@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/pull/40423#issuecomment-1321014818

Comment:
> We definitely want to use system dependencies, can we fix it by adding json-c++ to makedepends?

Certainly.

Also fmt-devel and eigen are already present in the repository, so they are used in my case, too.

[vtk.txt](https://github.com/void-linux/void-packages/files/10048296/vtk.txt)
[vtk-query.txt](https://github.com/void-linux/void-packages/files/10048300/vtk-query.txt)

```diff
diff --git a/srcpkgs/vtk/template b/srcpkgs/vtk/template
index dfabbb649a..147718c690 100644
--- a/srcpkgs/vtk/template
+++ b/srcpkgs/vtk/template
@@ -6,21 +6,21 @@ build_style=cmake
 # vtk can be huge, especially with -DVTK_BUILD_ALL_MODULES=ON"
 # Build only the core modules plus python bindings for now
 configure_args="-DBUILD_SHARED_LIBS=ON -DVTK_FORBID_DOWNLOADS=ON
- -DVTK_USE_EXTERNAL=OFF
+ -DVTK_USE_EXTERNAL=ON
  -DVTK_MODULE_USE_EXTERNAL_VTK_utf8=OFF
  -DVTK_MODULE_USE_EXTERNAL_VTK_pegtl=OFF
  -DVTK_MODULE_USE_EXTERNAL_VTK_libharu=OFF
  -DVTK_MODULE_USE_EXTERNAL_VTK_exprtk=OFF
- -DVTK_MODULE_USE_EXTERNAL_VTK_fmt=OFF
- -DVTK_MODULE_USE_EXTERNAL_vtknlohmannjson=OFF
- -DVTK_MODULE_USE_EXTERNAL_vtkeigen=OFF
+ -DVTK_MODULE_USE_EXTERNAL_VTK_cgns=OFF
+ -DVTK_MODULE_USE_EXTERNAL_VTK_ioss=OFF
+ -DVTK_MODULE_USE_EXTERNAL_VTK_verdict=OFF
  -DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3"
 # vtk forks libharu, bumps to v2.4.0, and requires libharu>=2.4.0
 makedepends="zlib-devel freetype-devel liblz4-devel expat-devel MesaLib-devel
  libXt-devel libjpeg-turbo-devel tiff-devel hdf5-devel netcdf-devel
  libxml2-devel jsoncpp-devel openmpi-devel libogg-devel libtheora-devel
  eigen double-conversion-devel glew-devel pugixml-devel sqlite-devel
- gl2ps-devel proj-devel python3-devel"
+ gl2ps-devel proj-devel python3-devel json-c++ fmt-devel"
 short_desc="System for 3D computer graphics, image processing, and visualization"
 maintainer="Piraty <piraty1@inbox.ru>"
 license="BSD-3-Clause"
```

  parent reply	other threads:[~2022-11-20  2:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 23:56 [PR PATCH] " ar-jan
2022-11-09 23:59 ` [PR PATCH] [Updated] " ar-jan
2022-11-10 22:32 ` kruceter
2022-11-10 22:32 ` kruceter
2022-11-11  9:22 ` [PR PATCH] [Updated] " ar-jan
2022-11-11  9:24 ` ar-jan
2022-11-11  9:44 ` paper42
2022-11-12 15:08 ` ar-jan
2022-11-12 20:55 ` paper42
2022-11-12 21:24 ` [PR PATCH] [Updated] " ar-jan
2022-11-12 21:41 ` paper42
2022-11-12 21:42 ` paper42
2022-11-12 21:45 ` [PR REVIEW] " paper42
2022-11-12 22:43 ` ar-jan
2022-11-12 22:51 ` [PR REVIEW] " ar-jan
2022-11-12 22:52 ` ar-jan
2022-11-12 22:53 ` paper42
2022-11-12 23:08 ` ar-jan
2022-11-12 23:10 ` ar-jan
2022-11-14 15:55 ` kruceter
2022-11-14 15:59 ` kruceter
2022-11-14 16:40 ` [PR PATCH] [Updated] " ar-jan
2022-11-14 16:48 ` [PR REVIEW] " paper42
2022-11-14 16:57 ` ar-jan
2022-11-14 16:58 ` paper42
2022-11-14 17:02 ` [PR PATCH] [Updated] " ar-jan
2022-11-14 17:02 ` [PR REVIEW] " ar-jan
2022-11-15 18:05 ` kruceter
2022-11-17 12:26 ` paper42
2022-11-20  2:12 ` kruceter [this message]
2022-11-20 16:01 ` [PR PATCH] [Updated] " ar-jan
2022-11-20 16:03 ` ar-jan
2022-12-02 12:28 ` ar-jan
2022-12-02 16:52 ` ar-jan
2022-12-03 20:38 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221120021250.4CS39X2SVT2oI6lgyNzgadLqOgjkP_PzV8R3WodGeWE@z \
    --to=kruceter@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).