* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
@ 2022-11-10 21:34 ` TrueTechie
2022-11-10 21:41 ` classabbyamp
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: TrueTechie @ 2022-11-10 21:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1310926019
Comment:
Closes #40456
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
2022-11-10 21:34 ` TrueTechie
@ 2022-11-10 21:41 ` classabbyamp
2022-11-11 2:27 ` sgn
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: classabbyamp @ 2022-11-10 21:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1310940066
Comment:
> Closes #40456
put this in the PR description and/or the commit body so it automatically closes it
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
2022-11-10 21:34 ` TrueTechie
2022-11-10 21:41 ` classabbyamp
@ 2022-11-11 2:27 ` sgn
2022-11-11 2:55 ` TrueTechie
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: sgn @ 2022-11-11 2:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1311150342
Comment:
smplayer can use mplayer as backend, mpv is not a hard dependencies.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (2 preceding siblings ...)
2022-11-11 2:27 ` sgn
@ 2022-11-11 2:55 ` TrueTechie
2022-11-11 2:59 ` TrueTechie
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: TrueTechie @ 2022-11-11 2:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1310926019
Comment:
Closes #40456
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (3 preceding siblings ...)
2022-11-11 2:55 ` TrueTechie
@ 2022-11-11 2:59 ` TrueTechie
2022-11-11 7:54 ` paper42
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: TrueTechie @ 2022-11-11 2:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1311169268
Comment:
> smplayer can use mplayer as backend, mpv is not a hard dependencies.
So should `mplayer` be the dependency or what?
Unlike other packages that are broken without "optional" dependencies such as `steam`, there is no documentation in the package about this.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (4 preceding siblings ...)
2022-11-11 2:59 ` TrueTechie
@ 2022-11-11 7:54 ` paper42
2022-11-11 16:16 ` TrueTechie
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-11-11 7:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1311352866
Comment:
If you run smplayer and don't have mpv or mplayer installed, do you get a descriptive error message?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (5 preceding siblings ...)
2022-11-11 7:54 ` paper42
@ 2022-11-11 16:16 ` TrueTechie
2022-11-11 16:16 ` TrueTechie
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: TrueTechie @ 2022-11-11 16:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1311904669
Comment:
> If you run smplayer and don't have mpv or mplayer installed, do you get a descriptive error message?
I guess that is up to interpretation:
```
MPlayer/mpv failed to start. Please check the MPlayer/mpv path in preferences.
```
This is a little cryptic as it tells the user it is improperly configured, possibly implying the need for a standalone version of `mpv` or `mplayer`, rather than missing a package.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (6 preceding siblings ...)
2022-11-11 16:16 ` TrueTechie
@ 2022-11-11 16:16 ` TrueTechie
2022-11-11 20:06 ` lxlml
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: TrueTechie @ 2022-11-11 16:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
New comment by TrueTechie on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1311904669
Comment:
> If you run smplayer and don't have mpv or mplayer installed, do you get a descriptive error message?
I guess that is up to interpretation:
```
MPlayer/mpv failed to start. Please check the MPlayer/mpv path in preferences.
```
This is a little cryptic as it tells the user it is improperly configured, possibly implying the need for a standalone version of `mpv` or `mplayer`, rather than missing a package.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (7 preceding siblings ...)
2022-11-11 16:16 ` TrueTechie
@ 2022-11-11 20:06 ` lxlml
2022-11-11 20:07 ` lxlml
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: lxlml @ 2022-11-11 20:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
New comment by lxlml on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312152258
Comment:
I personally prefer smplayer as it is now because I need to complile MPV with vapoursynth support and I am not sure how it would interact if smplayer comes with a hard mpv dependecy.
Besides if one were to search up smplayer, it specifically states it's a frontend of MPV or Mplayer so there should be no confusion. I think letting people choose what they want is the better choice.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (8 preceding siblings ...)
2022-11-11 20:06 ` lxlml
@ 2022-11-11 20:07 ` lxlml
2022-11-11 20:08 ` lxlml
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: lxlml @ 2022-11-11 20:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
New comment by lxlml on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312152258
Comment:
I personally prefer smplayer as it is now because I need to compile MPV with vapoursynth support and I am not sure how it would interact if smplayer comes with a hard mpv dependency.
Besides if one were to search up smplayer, it specifically states it's a frontend of MPV or Mplayer so there should be no confusion. I think letting people choose what backend they want is the better choice.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (9 preceding siblings ...)
2022-11-11 20:07 ` lxlml
@ 2022-11-11 20:08 ` lxlml
2022-11-11 20:10 ` lxlml
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: lxlml @ 2022-11-11 20:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
New comment by lxlml on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312152258
Comment:
I personally prefer smplayer as it is now because I need to compile MPV with vapoursynth support and I am not sure how it would interact if smplayer comes with a hard mpv dependency.
Besides if one were to search up smplayer, you will easily find information that states it's a frontend of MPV or Mplayer. So there should be no confusion. I think letting people choose what backend they want is the better choice.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (10 preceding siblings ...)
2022-11-11 20:08 ` lxlml
@ 2022-11-11 20:10 ` lxlml
2022-11-11 20:20 ` classabbyamp
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: lxlml @ 2022-11-11 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
New comment by lxlml on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312152258
Comment:
I personally prefer smplayer as it is now because I need to compile MPV with vapoursynth support and I am not sure how it would interact if smplayer comes with a hard mpv dependency.
Besides if one were to search up smplayer, you will easily find information that states it's a frontend for MPV or Mplayer. So there should be no confusion. I think letting people choose what backend they want is the better choice.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (11 preceding siblings ...)
2022-11-11 20:10 ` lxlml
@ 2022-11-11 20:20 ` classabbyamp
2022-11-13 12:30 ` sgn
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: classabbyamp @ 2022-11-11 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312162360
Comment:
if it is not a dependency caused by requiring a shared library, it is possible to use [ignorepkg](https://man.voidlinux.org/xbps.d#ignorepkg=pkgname) to not install it
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (12 preceding siblings ...)
2022-11-11 20:20 ` classabbyamp
@ 2022-11-13 12:30 ` sgn
2022-11-13 14:31 ` paper42
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: sgn @ 2022-11-13 12:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312719589
Comment:
I prefer to patch `smplayer` to provide better error message. I dont use smplayer, so I don't care much, anyway.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (13 preceding siblings ...)
2022-11-13 12:30 ` sgn
@ 2022-11-13 14:31 ` paper42
2022-11-13 14:31 ` paper42
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-11-13 14:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312744730
Comment:
> I prefer to patch `smplayer` to provide better error message. I dont use smplayer, so I don't care much, anyway.
I second that, but the patch should be upstream, we shouldn't carry functional patches like this one in the distribution.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (14 preceding siblings ...)
2022-11-13 14:31 ` paper42
@ 2022-11-13 14:31 ` paper42
2022-11-14 1:12 ` sgn
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: paper42 @ 2022-11-13 14:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312744730
Comment:
> I prefer to patch `smplayer` to provide better error message. I dont use smplayer, so I don't care much, anyway.
I second that, but the patch should be upstreamed, we shouldn't carry functional patches like this one in the distribution.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (15 preceding siblings ...)
2022-11-13 14:31 ` paper42
@ 2022-11-14 1:12 ` sgn
2022-11-19 20:35 ` ahesford
2022-11-19 20:35 ` [PR PATCH] [Closed]: " ahesford
18 siblings, 0 replies; 20+ messages in thread
From: sgn @ 2022-11-14 1:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1312918019
Comment:
Even if we want to put one optional dependency to `smplayer`, it should be `mplayer` not `mpv`.
Quoting from their homepage:
> SMPlayer is a graphical user interface (GUI) for the award-winning [**MPlayer**](http://www.mplayerhq.hu/design7/info.html), which is capable of playing almost all known video and audio formats. But apart from providing access for the most common and useful options of **MPlayer**, SMPlayer adds other interesting features like the possibility to play Youtube videos or download subtitles.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (16 preceding siblings ...)
2022-11-14 1:12 ` sgn
@ 2022-11-19 20:35 ` ahesford
2022-11-19 20:35 ` [PR PATCH] [Closed]: " ahesford
18 siblings, 0 replies; 20+ messages in thread
From: ahesford @ 2022-11-19 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/40457#issuecomment-1320964279
Comment:
I disagree that the error message, "MPlayer/mpv failed to start", is particularly cryptic. "Please check the path" is a recommendation about how to solve the problem, and a user who tries to inspect the path should be able to determine that neither of these alternatives is available.
Although I would be very happy to see a decent implementation of optional dependencies for XBPS, we currently have no facility for this. Our policy is not to force hard dependencies on software that works with several viable alternatives and, as sgn noted, the natural choice would be `mplayer` anyway because that seems to be the first-class backend for SMplayer. Of course, forcing a user to `ignorepkg` something to swap backends is at least as lousy an experience (and less obviously resolved) than the current situation.
Any team member disagreeing with me can reopen this PR, but it seems like a WONTFIX for now.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Closed]: smplayer: Add mpv as runtime dependency
2022-11-10 21:33 [PR PATCH] smplayer: Add mpv as runtime dependency TrueTechie
` (17 preceding siblings ...)
2022-11-19 20:35 ` ahesford
@ 2022-11-19 20:35 ` ahesford
18 siblings, 0 replies; 20+ messages in thread
From: ahesford @ 2022-11-19 20:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
There's a closed pull request on the void-packages repository
smplayer: Add mpv as runtime dependency
https://github.com/void-linux/void-packages/pull/40457
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
Closes #40456
^ permalink raw reply [flat|nested] 20+ messages in thread