Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] cloudflared: update to version 2022.10.3
@ 2022-11-14  9:04 marmeladema
  2022-11-14  9:19 ` [PR REVIEW] " paper42
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: marmeladema @ 2022-11-14  9:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

There is a new pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages cloudflared-2022.10.3
https://github.com/void-linux/void-packages/pull/40515

cloudflared: update to version 2022.10.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/40515.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cloudflared-2022.10.3-40515.patch --]
[-- Type: text/x-diff, Size: 1500 bytes --]

From e89075af74c09b284eba22fddfb4e4af46c85b9c Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Mon, 14 Nov 2022 08:59:57 +0000
Subject: [PATCH] cloudflared: update to version 2022.10.3

---
 srcpkgs/cloudflared/template | 4 ++--
 srcpkgs/cloudflared/update   | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/cloudflared/update

diff --git a/srcpkgs/cloudflared/template b/srcpkgs/cloudflared/template
index 64ca8edd8feb..8219fbe0f0af 100644
--- a/srcpkgs/cloudflared/template
+++ b/srcpkgs/cloudflared/template
@@ -1,6 +1,6 @@
 # Template file for 'cloudflared'
 pkgname=cloudflared
-version=2022.9.1
+version=2022.10.3
 revision=1
 build_style=go
 go_import_path=github.com/cloudflare/cloudflared
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://developers.cloudflare.com/argo-tunnel/"
 changelog="https://raw.githubusercontent.com/cloudflare/cloudflared/master/CHANGES.md"
 distfiles="https://github.com/cloudflare/cloudflared/archive/${version}.tar.gz"
-checksum=4919eef5814b4ecc41e1359f9546389688194c9e893b4de3c40b0e3cd2919605
+checksum=e49db875da7513d8ae950b20c636225016022866850ff3df2484c0f56cdc4bc4
 
 pre_build() {
 	go_ldflags+=" -X \"main.BuildTime=$(date -u '+%Y-%m-%d-%H:%M UTC')\""
diff --git a/srcpkgs/cloudflared/update b/srcpkgs/cloudflared/update
new file mode 100644
index 000000000000..f2e9875b3374
--- /dev/null
+++ b/srcpkgs/cloudflared/update
@@ -0,0 +1 @@
+site=https://github.com/cloudflare/cloudflared/releases

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
@ 2022-11-14  9:19 ` paper42
  2022-11-14  9:37 ` marmeladema
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-11-14  9:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021249615

Comment:
Or does date respect SOURCE_DATE_EPOCH?
```suggestion
	go_ldflags+=" -X \"main.BuildTime=$(date --date "@$SOURCE_DATE_EPOCH" '+%Y-%m-%d-%H:%M UTC')\""
```

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
  2022-11-14  9:19 ` [PR REVIEW] " paper42
@ 2022-11-14  9:37 ` marmeladema
  2022-11-14  9:40 ` paper42
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: marmeladema @ 2022-11-14  9:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021269216

Comment:
According to @ericonr in https://github.com/void-linux/void-packages/pull/26888#discussion_r723785148

> If you use date inside some of the pre_ functions then it uses SOURCE_DATE_EPOCH automatically.

We agreed at the time that it was fine to use `date -u` here. Additionally, I prefer having the correct build date when building locally.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
  2022-11-14  9:19 ` [PR REVIEW] " paper42
  2022-11-14  9:37 ` marmeladema
@ 2022-11-14  9:40 ` paper42
  2022-11-14  9:52 ` marmeladema
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-11-14  9:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021272199

Comment:
Is this really needed? update-check detects 2022.10.3 for me without this.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
                   ` (2 preceding siblings ...)
  2022-11-14  9:40 ` paper42
@ 2022-11-14  9:52 ` marmeladema
  2022-11-14 10:07 ` paper42
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: marmeladema @ 2022-11-14  9:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021285823

Comment:
Definitely not if it works already :D I just thought with an update file, the package would get automatically updated?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
                   ` (3 preceding siblings ...)
  2022-11-14  9:52 ` marmeladema
@ 2022-11-14 10:07 ` paper42
  2022-11-14 10:28 ` [PR PATCH] [Updated] " marmeladema
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-11-14 10:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021302547

Comment:
The update file is used for [checking for new upstream releases](https://github.com/void-linux/void-packages/blob/master/Manual.md#checking-for-new-upstream-releases), every day all packages are checked and the result is available on https://repo-default.voidlinux.org/void-updates/void-updates.txt. Packages do not ever get automatically updated, they have to be bumped and tested manually. Updating them automatically would only lead to low quality packages and a lot of issues.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
                   ` (4 preceding siblings ...)
  2022-11-14 10:07 ` paper42
@ 2022-11-14 10:28 ` marmeladema
  2022-11-14 10:29 ` [PR REVIEW] " marmeladema
  2022-11-14 10:50 ` [PR PATCH] [Merged]: " paper42
  7 siblings, 0 replies; 9+ messages in thread
From: marmeladema @ 2022-11-14 10:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

There is an updated pull request by marmeladema against master on the void-packages repository

https://github.com/marmeladema/void-packages cloudflared-2022.10.3
https://github.com/void-linux/void-packages/pull/40515

cloudflared: update to version 2022.10.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/40515.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cloudflared-2022.10.3-40515.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From ec934b1b6751d37dd4f631fd912ff624287c479f Mon Sep 17 00:00:00 2001
From: marmeladema <xademax@gmail.com>
Date: Mon, 14 Nov 2022 08:59:57 +0000
Subject: [PATCH] cloudflared: update to version 2022.10.3

---
 srcpkgs/cloudflared/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cloudflared/template b/srcpkgs/cloudflared/template
index 64ca8edd8feb..8219fbe0f0af 100644
--- a/srcpkgs/cloudflared/template
+++ b/srcpkgs/cloudflared/template
@@ -1,6 +1,6 @@
 # Template file for 'cloudflared'
 pkgname=cloudflared
-version=2022.9.1
+version=2022.10.3
 revision=1
 build_style=go
 go_import_path=github.com/cloudflare/cloudflared
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://developers.cloudflare.com/argo-tunnel/"
 changelog="https://raw.githubusercontent.com/cloudflare/cloudflared/master/CHANGES.md"
 distfiles="https://github.com/cloudflare/cloudflared/archive/${version}.tar.gz"
-checksum=4919eef5814b4ecc41e1359f9546389688194c9e893b4de3c40b0e3cd2919605
+checksum=e49db875da7513d8ae950b20c636225016022866850ff3df2484c0f56cdc4bc4
 
 pre_build() {
 	go_ldflags+=" -X \"main.BuildTime=$(date -u '+%Y-%m-%d-%H:%M UTC')\""

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
                   ` (5 preceding siblings ...)
  2022-11-14 10:28 ` [PR PATCH] [Updated] " marmeladema
@ 2022-11-14 10:29 ` marmeladema
  2022-11-14 10:50 ` [PR PATCH] [Merged]: " paper42
  7 siblings, 0 replies; 9+ messages in thread
From: marmeladema @ 2022-11-14 10:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by marmeladema on void-packages repository

https://github.com/void-linux/void-packages/pull/40515#discussion_r1021325922

Comment:
All right, thanks for the detailed explanation :)
Just removed the file.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: cloudflared: update to version 2022.10.3
  2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
                   ` (6 preceding siblings ...)
  2022-11-14 10:29 ` [PR REVIEW] " marmeladema
@ 2022-11-14 10:50 ` paper42
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-11-14 10:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

There's a merged pull request on the void-packages repository

cloudflared: update to version 2022.10.3
https://github.com/void-linux/void-packages/pull/40515

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-11-14 10:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14  9:04 [PR PATCH] cloudflared: update to version 2022.10.3 marmeladema
2022-11-14  9:19 ` [PR REVIEW] " paper42
2022-11-14  9:37 ` marmeladema
2022-11-14  9:40 ` paper42
2022-11-14  9:52 ` marmeladema
2022-11-14 10:07 ` paper42
2022-11-14 10:28 ` [PR PATCH] [Updated] " marmeladema
2022-11-14 10:29 ` [PR REVIEW] " marmeladema
2022-11-14 10:50 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).